Openembedded Core Discussions
 help / color / mirror / Atom feed
From: <mark.jonas@de.bosch.com>
To: <openembedded-core@lists.openembedded.org>
Cc: <ross.burton@arm.com>,
	Ricardo Simoes <ricardo.simoes@pt.bosch.com>,
	"Mark Jonas" <mark.jonas@de.bosch.com>
Subject: [PATCH] udev-extraconf: Add missing commas in udev rules
Date: Mon, 21 Sep 2026 15:47:24 +0200	[thread overview]
Message-ID: <20260921134724.1974-1-mark.jonas@de.bosch.com> (raw)

From: Ricardo Simoes <ricardo.simoes@pt.bosch.com>

As per udev(7) man page, each key-operator-value must be separated by a
comma.

```
$ udevadm verify /etc/udev/rules.d/auto*
/etc/udev/rules.d/automount.rules:17 style: a comma between tokens is expected.
/etc/udev/rules.d/automount.rules:18 style: a comma between tokens is expected.
/etc/udev/rules.d/automount.rules:19 style: a comma between tokens is expected.
/etc/udev/rules.d/automount.rules: udev rules have style issues.
/etc/udev/rules.d/autonet.rules:17 style: a comma between tokens is expected.
/etc/udev/rules.d/autonet.rules:18 style: a comma between tokens is expected.
/etc/udev/rules.d/autonet.rules: udev rules have style issues.

2 udev rules files have been checked.
  Success: 0
  Fail:    2
```

This patch fixes the errors shown above.

Signed-off-by: Ricardo Simoes <ricardo.simoes@pt.bosch.com>
Signed-off-by: Mark Jonas <mark.jonas@de.bosch.com>
---
 meta/recipes-core/udev/udev-extraconf/automount.rules | 6 +++---
 meta/recipes-core/udev/udev-extraconf/autonet.rules   | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/meta/recipes-core/udev/udev-extraconf/automount.rules b/meta/recipes-core/udev/udev-extraconf/automount.rules
index 62578ea631..88842f5247 100644
--- a/meta/recipes-core/udev/udev-extraconf/automount.rules
+++ b/meta/recipes-core/udev/udev-extraconf/automount.rules
@@ -14,6 +14,6 @@
 #
 
 # Media automounting
-SUBSYSTEM=="block", ACTION=="add"    RUN+="/etc/udev/scripts/mount.sh"
-SUBSYSTEM=="block", ACTION=="remove" RUN+="/etc/udev/scripts/mount.sh"
-SUBSYSTEM=="block", ACTION=="change", ENV{DISK_MEDIA_CHANGE}=="1" RUN+="/etc/udev/scripts/mount.sh"
+SUBSYSTEM=="block", ACTION=="add",    RUN+="/etc/udev/scripts/mount.sh"
+SUBSYSTEM=="block", ACTION=="remove", RUN+="/etc/udev/scripts/mount.sh"
+SUBSYSTEM=="block", ACTION=="change", ENV{DISK_MEDIA_CHANGE}=="1", RUN+="/etc/udev/scripts/mount.sh"
diff --git a/meta/recipes-core/udev/udev-extraconf/autonet.rules b/meta/recipes-core/udev/udev-extraconf/autonet.rules
index 19676aa13b..2c02668097 100644
--- a/meta/recipes-core/udev/udev-extraconf/autonet.rules
+++ b/meta/recipes-core/udev/udev-extraconf/autonet.rules
@@ -14,6 +14,6 @@
 #
 
 # Handle network interface setup
-SUBSYSTEM=="net", ACTION=="add" RUN+="/etc/udev/scripts/network.sh"
-SUBSYSTEM=="net", ACTION=="remove" RUN+="/etc/udev/scripts/network.sh"
+SUBSYSTEM=="net", ACTION=="add", RUN+="/etc/udev/scripts/network.sh"
+SUBSYSTEM=="net", ACTION=="remove", RUN+="/etc/udev/scripts/network.sh"
 
-- 
2.34.1



                 reply	other threads:[~2026-09-21 13:48 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260921134724.1974-1-mark.jonas@de.bosch.com \
    --to=mark.jonas@de.bosch.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ricardo.simoes@pt.bosch.com \
    --cc=ross.burton@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox