Openembedded Core Discussions
 help / color / mirror / Atom feed
* [PATCH] udev-extraconf: Add missing commas in udev rules
@ 2026-09-21 13:47 mark.jonas
  0 siblings, 0 replies; only message in thread
From: mark.jonas @ 2026-09-21 13:47 UTC (permalink / raw)
  To: openembedded-core; +Cc: ross.burton, Ricardo Simoes, Mark Jonas

From: Ricardo Simoes <ricardo.simoes@pt.bosch.com>

As per udev(7) man page, each key-operator-value must be separated by a
comma.

```
$ udevadm verify /etc/udev/rules.d/auto*
/etc/udev/rules.d/automount.rules:17 style: a comma between tokens is expected.
/etc/udev/rules.d/automount.rules:18 style: a comma between tokens is expected.
/etc/udev/rules.d/automount.rules:19 style: a comma between tokens is expected.
/etc/udev/rules.d/automount.rules: udev rules have style issues.
/etc/udev/rules.d/autonet.rules:17 style: a comma between tokens is expected.
/etc/udev/rules.d/autonet.rules:18 style: a comma between tokens is expected.
/etc/udev/rules.d/autonet.rules: udev rules have style issues.

2 udev rules files have been checked.
  Success: 0
  Fail:    2
```

This patch fixes the errors shown above.

Signed-off-by: Ricardo Simoes <ricardo.simoes@pt.bosch.com>
Signed-off-by: Mark Jonas <mark.jonas@de.bosch.com>
---
 meta/recipes-core/udev/udev-extraconf/automount.rules | 6 +++---
 meta/recipes-core/udev/udev-extraconf/autonet.rules   | 4 ++--
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/meta/recipes-core/udev/udev-extraconf/automount.rules b/meta/recipes-core/udev/udev-extraconf/automount.rules
index 62578ea631..88842f5247 100644
--- a/meta/recipes-core/udev/udev-extraconf/automount.rules
+++ b/meta/recipes-core/udev/udev-extraconf/automount.rules
@@ -14,6 +14,6 @@
 #
 
 # Media automounting
-SUBSYSTEM=="block", ACTION=="add"    RUN+="/etc/udev/scripts/mount.sh"
-SUBSYSTEM=="block", ACTION=="remove" RUN+="/etc/udev/scripts/mount.sh"
-SUBSYSTEM=="block", ACTION=="change", ENV{DISK_MEDIA_CHANGE}=="1" RUN+="/etc/udev/scripts/mount.sh"
+SUBSYSTEM=="block", ACTION=="add",    RUN+="/etc/udev/scripts/mount.sh"
+SUBSYSTEM=="block", ACTION=="remove", RUN+="/etc/udev/scripts/mount.sh"
+SUBSYSTEM=="block", ACTION=="change", ENV{DISK_MEDIA_CHANGE}=="1", RUN+="/etc/udev/scripts/mount.sh"
diff --git a/meta/recipes-core/udev/udev-extraconf/autonet.rules b/meta/recipes-core/udev/udev-extraconf/autonet.rules
index 19676aa13b..2c02668097 100644
--- a/meta/recipes-core/udev/udev-extraconf/autonet.rules
+++ b/meta/recipes-core/udev/udev-extraconf/autonet.rules
@@ -14,6 +14,6 @@
 #
 
 # Handle network interface setup
-SUBSYSTEM=="net", ACTION=="add" RUN+="/etc/udev/scripts/network.sh"
-SUBSYSTEM=="net", ACTION=="remove" RUN+="/etc/udev/scripts/network.sh"
+SUBSYSTEM=="net", ACTION=="add", RUN+="/etc/udev/scripts/network.sh"
+SUBSYSTEM=="net", ACTION=="remove", RUN+="/etc/udev/scripts/network.sh"
 
-- 
2.34.1



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-09-21 13:48 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-21 13:47 [PATCH] udev-extraconf: Add missing commas in udev rules mark.jonas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox