[PATCH] sanity: fix NameError when upgrading a TMPDIR from ABI 14

[PATCH] sanity: fix NameError when upgrading a TMPDIR from ABI 14

[Prasanth R]

drop_v14_cross_builds() calls sstate_clean_manifest(), which is defined
in sstate.bbclass. Since the sanity code moved to lib/oe in 4efa61f049
("sanity: Move code to lib/oe"), that name is no longer in scope, so a
TMPDIR with ABI 14 fails with:

  NameError: name 'sstate_clean_manifest' is not defined

Call it through bb.utils.exec_flat_python_func().

AI-Generated: Uses Claude
Signed-off-by: Prasanth R <prasanth.r@lineo.co.jp>
---
 meta/lib/oe/sanity.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/lib/oe/sanity.py b/meta/lib/oe/sanity.py
index c9149ec974..77cea4ed24 100644
--- a/meta/lib/oe/sanity.py
+++ b/meta/lib/oe/sanity.py
@@ -474,7 +474,7 @@ def drop_v14_cross_builds(d):
                 for m in glob.glob(manifest + ".*"):
                     if m.endswith(".postrm"):
                         continue
-                    sstate_clean_manifest(m, d)
+                    bb.utils.exec_flat_python_func("sstate_clean_manifest", m, d)
                 bb.utils.remove(stamp + "*")
                 bb.utils.remove(workdir, recurse = True)
 
-- 
2.34.1

Re: [OE-core] [PATCH] sanity: fix NameError when upgrading a TMPDIR from ABI 14

[Ross Burton]

On 6 Nov 2026, at 02:54, prasanth via openembedded-core <ragaprasanth=gmail.com@lists.openembedded.org> wrote:
> 
> drop_v14_cross_builds() calls sstate_clean_manifest(), which is defined
> in sstate.bbclass. Since the sanity code moved to lib/oe in 4efa61f049
> ("sanity: Move code to lib/oe"), that name is no longer in scope, so a
> TMPDIR with ABI 14 fails with:

Whilst I agree that upgrading from ABI 14 shouldn’t cause an error, 15 was introduced in kirkstone so you’re presumably trying to use a build tree that previously was used to build gatesgarth/hardknott/honister?

> -                    sstate_clean_manifest(m, d)
> +                    bb.utils.exec_flat_python_func("sstate_clean_manifest", m, d)

Why exec_flat_python_func?  Literally nothing has used this function since 2016, I’ll send a patch to remove it.

Ross

Re: [OE-core] [PATCH] sanity: fix NameError when upgrading a TMPDIR from ABI 14

[Prasanth Ramesh]

[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]

Hi Ross,

I saw your commit, fair point.
As ABI 14 trees are honister or older, would it be better to drop the 14 ->
15 conversion instead? Those trees would then get the normal layout-change
message rather than a traceback. I can send a v2.

Thanks,
Prasanth


On Thu, Nov 12, 2026 at 2:45 AM Ross Burton <Ross.Burton@arm.com> wrote:

> On 6 Nov 2026, at 02:54, prasanth via openembedded-core <ragaprasanth=
> gmail.com@lists.openembedded.org> wrote:
> >
> > drop_v14_cross_builds() calls sstate_clean_manifest(), which is defined
> > in sstate.bbclass. Since the sanity code moved to lib/oe in 4efa61f049
> > ("sanity: Move code to lib/oe"), that name is no longer in scope, so a
> > TMPDIR with ABI 14 fails with:
>
> Whilst I agree that upgrading from ABI 14 shouldn’t cause an error, 15 was
> introduced in kirkstone so you’re presumably trying to use a build tree
> that previously was used to build gatesgarth/hardknott/honister?
>
> > -                    sstate_clean_manifest(m, d)
> > +
> bb.utils.exec_flat_python_func("sstate_clean_manifest", m, d)
>
> Why exec_flat_python_func?  Literally nothing has used this function since
> 2016, I’ll send a patch to remove it.
>
> Ross
>
>

[-- Attachment #2: Type: text/html, Size: 1748 bytes --]