From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: JC <jc@vtkloud.com>
Cc: JC Verdie <jc.verdie@innotis.org>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] Integration of former (deprecated?) libao recipe from https://github.com/tworaz/oe-tworaz/blob/master/meta-jlime/recipes-support/libao/libao_1.1.0.bb
Date: Tue, 17 Sep 2013 14:18:17 +0100 [thread overview]
Message-ID: <2046387.NLfZYpzpll@helios> (raw)
In-Reply-To: <CANyK_8dVMs0gt59z7fL0Woa-zjKW2M6p+qczQBBjJXSibhsNQg@mail.gmail.com>
On Tuesday 17 September 2013 14:07:01 Paul Barker wrote:
> On 17 September 2013 12:22, JC <jc@vtkloud.com> wrote:
> > From: JC Verdie <jc.verdie@innotis.org>
> >
> > Signed-off-by: JC Verdie <jc.verdie@innotis.org>
>
> Couple of tips on the commit message:
>
> First line of the commit message should be "libao: add version 1.1.0"
> or similar and should be and fairly short, put the link to the source
> within the body of the commit message and possibly reference the
> author of the recipe you're copying this from if you can.
Right. A few other things:
1) Since nothing in OE-Core needs this at the moment, this should really be
added to meta-multimedia (within the meta-openembedded repository) and sent to
the openembedded-devel mailing list marked with [meta-multimedia] in the
subject.
2) Please use ${BP} in SRC_URI rather than ${P} so that multilib builds can
work
3) It would be nice to have SUMMARY and HOMEPAGE set in the recipe (and
possibly also DESCRIPTION if you have a longer description).
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
next prev parent reply other threads:[~2013-09-17 13:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 11:22 [PATCH] Integration of former (deprecated?) libao recipe from https://github.com/tworaz/oe-tworaz/blob/master/meta-jlime/recipes-support/libao/libao_1.1.0.bb JC
2013-09-17 13:07 ` Paul Barker
2013-09-17 13:18 ` Paul Eggleton [this message]
2013-09-17 14:52 ` JC
2013-09-17 17:39 ` Paul Eggleton
2013-09-17 17:45 ` JC
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2046387.NLfZYpzpll@helios \
--to=paul.eggleton@linux.intel.com \
--cc=jc.verdie@innotis.org \
--cc=jc@vtkloud.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox