From: JC <jc@vtkloud.com>
To: Paul Eggleton <paul.eggleton@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] Integration of former (deprecated?) libao recipe from https://github.com/tworaz/oe-tworaz/blob/master/meta-jlime/recipes-support/libao/libao_1.1.0.bb
Date: Tue, 17 Sep 2013 13:45:30 -0400 [thread overview]
Message-ID: <5238953A.1010309@vtkloud.com> (raw)
In-Reply-To: <1676874.raqzZUa4qa@helios>
On 17/09/2013 13:39, Paul Eggleton wrote:
> On Tuesday 17 September 2013 10:52:22 JC wrote:
>> On 17/09/2013 09:18, Paul Eggleton wrote:
>>> Right. A few other things:
>>>
>>> 1) Since nothing in OE-Core needs this at the moment, this should really
>>> be added to meta-multimedia (within the meta-openembedded repository) and
>>> sent to the openembedded-devel mailing list marked with [meta-multimedia]
>>> in the subject.
>>>
>>> 2) Please use ${BP} in SRC_URI rather than ${P} so that multilib builds
>>> can work
>>>
>>> 3) It would be nice to have SUMMARY and HOMEPAGE set in the recipe (and
>>> possibly also DESCRIPTION if you have a longer description).
>> I sent a new one trying to comply with your reco. But I could not work
>> on head anymore, since it's broken (at least for me). I'm afraid the
>> patch appears to belong to "dylan" but I'm not a git guru enough to
>> check how to commit it at the right place (I mean, I could simply use my
>> non working git clone of HEAD and commit it untested but I'm not sure
>> that's the way to go).
>>
>> I'm not sure how to add the [meta-multimedia] tag to the git send-mail,
>> also. Sorry for being dumb :(
> It's not being dumb, we all had to go through this at some point :)
>
> You just need to re-send your latest version using git-send-email with the
> --subject-prefix="meta-multimedia][PATCH" option to the openembedded-
> devel@lists.openembedded.org mailing list rather than this one.
>
> FWIW I did a quick build-test on top of master and it built successfully at
> least.
Thanks a lot Paul, I just did as instructed...
Jay
> Cheers,
> Paul
>
prev parent reply other threads:[~2013-09-17 17:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-17 11:22 [PATCH] Integration of former (deprecated?) libao recipe from https://github.com/tworaz/oe-tworaz/blob/master/meta-jlime/recipes-support/libao/libao_1.1.0.bb JC
2013-09-17 13:07 ` Paul Barker
2013-09-17 13:18 ` Paul Eggleton
2013-09-17 14:52 ` JC
2013-09-17 17:39 ` Paul Eggleton
2013-09-17 17:45 ` JC [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5238953A.1010309@vtkloud.com \
--to=jc@vtkloud.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=paul.eggleton@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox