gcc-4.7.inc wrong FILESPATH setting?

gcc-4.7.inc wrong FILESPATH setting?

[Giuseppe Condorelli]

[-- Attachment #1: Type: text/plain, Size: 563 bytes --]

Hi All,

I've seen that, in the given .inc file, the FILESPATH is statically set to

FILESPATH = "${FILE_DIRNAME}/gcc-4.7"

This seems to avoid any FILESEXTRAPATHS_prepend usage on append file.
I need to add further patches for gcc-4.7.2 in my own meta layer but if I
set the FILESEXTRAPATHS_prepend as usual
nothing happens, sources are taken only from the directory set by FILESPATH.
Also I saw this setting was different in the past
FILESPATH = "${@base_set_filespath([ '${FILE_DIRNAME}/gcc-4.7' ], d)}"

Comments are welcome.
Cheers,
Giuseppe

[-- Attachment #2: Type: text/html, Size: 786 bytes --]

Re: gcc-4.7.inc wrong FILESPATH setting?

[Marko Katić]

On Fri, 2012-12-14 at 17:41 +0100, Giuseppe Condorelli wrote:
> Hi All,
>  
> I've seen that, in the given .inc file, the FILESPATH is statically
> set to
>  
> FILESPATH = "${FILE_DIRNAME}/gcc-4.7"
>  
> This seems to avoid any FILESEXTRAPATHS_prepend usage on append file.
> I need to add further patches for gcc-4.7.2 in my own meta layer but
> if I set the FILESEXTRAPATHS_prepend as usual
> nothing happens, sources are taken only from the directory set by
> FILESPATH.
> Also I saw this setting was different in the past
> 
> FILESPATH = "${@base_set_filespath([ '${FILE_DIRNAME}/gcc-4.7' ], d)}"
>  
> Comments are welcome.
> Cheers,
> Giuseppe
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

I can confirm this. I also have patches for gcc-4.7.2 in my personal layer and i
also used FILESEXTRAPATHS_prepend in my bbappend files to add them. This used
to work before but now it seems as though FILESEXTRAPATHS_prepend is being
ignored.

Re: gcc-4.7.inc wrong FILESPATH setting?

[Robert P. J. Day]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 1736 bytes --]

On Fri, 14 Dec 2012, Marko Katić wrote:

> On Fri, 2012-12-14 at 17:41 +0100, Giuseppe Condorelli wrote:
> > Hi All,
> >
> > I've seen that, in the given .inc file, the FILESPATH is statically
> > set to
> >
> > FILESPATH = "${FILE_DIRNAME}/gcc-4.7"
> >
> > This seems to avoid any FILESEXTRAPATHS_prepend usage on append file.
> > I need to add further patches for gcc-4.7.2 in my own meta layer but
> > if I set the FILESEXTRAPATHS_prepend as usual
> > nothing happens, sources are taken only from the directory set by
> > FILESPATH.
> > Also I saw this setting was different in the past
> >
> > FILESPATH = "${@base_set_filespath([ '${FILE_DIRNAME}/gcc-4.7' ], d)}"

  i'm fairly sure i posted on this recently.  base.bbclass
*explicitly* sets FILESPATH to a set of variations thusly:

FILESPATH = "${@base_set_filespath(["${FILE_DIRNAME}/${BP}", "${FILE_DIRNAME}/${BPN}", "${FILE_DIRNAME}/files"], d)}"

which works fine with the recipes in the underlying oe-core layer.

  however, when you use FILESEXTRAPATHS_prepend, you get additional
directories based on *only* the name you specify.  so if you do:

FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"

are you thinking you should also get all variations of "gcc-4.7"?
because that's not what's going to happen.

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: gcc-4.7.inc wrong FILESPATH setting?

[Giuseppe Condorelli]

[-- Attachment #1: Type: text/plain, Size: 2342 bytes --]

2012/12/14 Robert P. J. Day <rpjday@crashcourse.ca>

> On Fri, 14 Dec 2012, Marko Katić wrote:
>
> > On Fri, 2012-12-14 at 17:41 +0100, Giuseppe Condorelli wrote:
> > > Hi All,
> > >
> > > I've seen that, in the given .inc file, the FILESPATH is statically
> > > set to
> > >
> > > FILESPATH = "${FILE_DIRNAME}/gcc-4.7"
> > >
> > > This seems to avoid any FILESEXTRAPATHS_prepend usage on append file.
> > > I need to add further patches for gcc-4.7.2 in my own meta layer but
> > > if I set the FILESEXTRAPATHS_prepend as usual
> > > nothing happens, sources are taken only from the directory set by
> > > FILESPATH.
> > > Also I saw this setting was different in the past
> > >
> > > FILESPATH = "${@base_set_filespath([ '${FILE_DIRNAME}/gcc-4.7' ], d)}"
>
>   i'm fairly sure i posted on this recently.  base.bbclass
> *explicitly* sets FILESPATH to a set of variations thusly:
>
> FILESPATH = "${@base_set_filespath(["${FILE_DIRNAME}/${BP}",
> "${FILE_DIRNAME}/${BPN}", "${FILE_DIRNAME}/files"], d)}"
>
> which works fine with the recipes in the underlying oe-core layer.
>
>   however, when you use FILESEXTRAPATHS_prepend, you get additional
> directories based on *only* the name you specify.  so if you do:
>
> FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>
> are you thinking you should also get all variations of "gcc-4.7"?
> because that's not what's going to happen.
>
> I'm sorry, I've not catched your last sentence. I set (as in the past) the
FILESEXTRAPATHS_prepend := "${THISDIR}/files:"
also updating the SRC_URI inside the .bbappend file to use the sources
available in the gcc directory available in my own layer.


> rday
>
> --
>
> ========================================================================
> Robert P. J. Day                                 Ottawa, Ontario, CANADA
>                         http://crashcourse.ca
>
> Twitter:                                       http://twitter.com/rpjday
> LinkedIn:                               http://ca.linkedin.com/in/rpjday
> ========================================================================
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>

[-- Attachment #2: Type: text/html, Size: 3650 bytes --]

Re: gcc-4.7.inc wrong FILESPATH setting?

[Robert P. J. Day]

[-- Attachment #1: Type: TEXT/PLAIN, Size: 2331 bytes --]

On Fri, 14 Dec 2012, Giuseppe Condorelli wrote:

>
>
> 2012/12/14 Robert P. J. Day <rpjday@crashcourse.ca>
>       On Fri, 14 Dec 2012, Marko Katić wrote:
>
>       > On Fri, 2012-12-14 at 17:41 +0100, Giuseppe Condorelli wrote:
>       > > Hi All,
>       > >
>       > > I've seen that, in the given .inc file, the FILESPATH is statically
>       > > set to
>       > >
>       > > FILESPATH = "${FILE_DIRNAME}/gcc-4.7"
>       > >
>       > > This seems to avoid any FILESEXTRAPATHS_prepend usage on append file.
>       > > I need to add further patches for gcc-4.7.2 in my own meta layer but
>       > > if I set the FILESEXTRAPATHS_prepend as usual
>       > > nothing happens, sources are taken only from the directory set by
>       > > FILESPATH.
>       > > Also I saw this setting was different in the past
>       > >
>       > > FILESPATH = "${@base_set_filespath([ '${FILE_DIRNAME}/gcc-4.7' ], d)}"
>
>   i'm fairly sure i posted on this recently.  base.bbclass
> *explicitly* sets FILESPATH to a set of variations thusly:
>
> FILESPATH = "${@base_set_filespath(["${FILE_DIRNAME}/${BP}", "${FILE_DIRNAME}/${BPN}", "${FILE_DIRNAME}/files"], d)}"
>
> which works fine with the recipes in the underlying oe-core layer.
>
>   however, when you use FILESEXTRAPATHS_prepend, you get additional
> directories based on *only* the name you specify.  so if you do:
>
> FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
>
> are you thinking you should also get all variations of "gcc-4.7"?
> because that's not what's going to happen.
>
> I'm sorry, I've not catched your last sentence. I set (as in the
> past) the FILESEXTRAPATHS_prepend := "${THISDIR}/files:"
> also updating the SRC_URI inside the .bbappend file to use the
> sources available in the gcc directory available in my own layer.  

  did you also set THISDIR just above that?

rday

-- 

========================================================================
Robert P. J. Day                                 Ottawa, Ontario, CANADA
                        http://crashcourse.ca

Twitter:                                       http://twitter.com/rpjday
LinkedIn:                               http://ca.linkedin.com/in/rpjday
========================================================================

Re: gcc-4.7.inc wrong FILESPATH setting?

[Giuseppe Condorelli]

[-- Attachment #1: Type: text/plain, Size: 2555 bytes --]

2012/12/14 Robert P. J. Day <rpjday@crashcourse.ca>

> On Fri, 14 Dec 2012, Giuseppe Condorelli wrote:
>
> >
> >
> > 2012/12/14 Robert P. J. Day <rpjday@crashcourse.ca>
> >       On Fri, 14 Dec 2012, Marko Katić wrote:
> >
> >       > On Fri, 2012-12-14 at 17:41 +0100, Giuseppe Condorelli wrote:
> >       > > Hi All,
> >       > >
> >       > > I've seen that, in the given .inc file, the FILESPATH is
> statically
> >       > > set to
> >       > >
> >       > > FILESPATH = "${FILE_DIRNAME}/gcc-4.7"
> >       > >
> >       > > This seems to avoid any FILESEXTRAPATHS_prepend usage on
> append file.
> >       > > I need to add further patches for gcc-4.7.2 in my own meta
> layer but
> >       > > if I set the FILESEXTRAPATHS_prepend as usual
> >       > > nothing happens, sources are taken only from the directory set
> by
> >       > > FILESPATH.
> >       > > Also I saw this setting was different in the past
> >       > >
> >       > > FILESPATH = "${@base_set_filespath([ '${FILE_DIRNAME}/gcc-4.7'
> ], d)}"
> >
> >   i'm fairly sure i posted on this recently.  base.bbclass
> > *explicitly* sets FILESPATH to a set of variations thusly:
> >
> > FILESPATH = "${@base_set_filespath(["${FILE_DIRNAME}/${BP}",
> "${FILE_DIRNAME}/${BPN}", "${FILE_DIRNAME}/files"], d)}"
> >
> > which works fine with the recipes in the underlying oe-core layer.
> >
> >   however, when you use FILESEXTRAPATHS_prepend, you get additional
> > directories based on *only* the name you specify.  so if you do:
> >
> > FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> >
> > are you thinking you should also get all variations of "gcc-4.7"?
> > because that's not what's going to happen.
> >
> > I'm sorry, I've not catched your last sentence. I set (as in the
> > past) the FILESEXTRAPATHS_prepend := "${THISDIR}/files:"
> > also updating the SRC_URI inside the .bbappend file to use the
> > sources available in the gcc directory available in my own layer.
>
>   did you also set THISDIR just above that?
>
No, I don't set it. Is it necessary now?


>
> rday
>
> --
>
> ========================================================================
> Robert P. J. Day                                 Ottawa, Ontario, CANADA
>                         http://crashcourse.ca
>
> Twitter:                                       http://twitter.com/rpjday
> LinkedIn:                               http://ca.linkedin.com/in/rpjday
> ========================================================================
>

[-- Attachment #2: Type: text/html, Size: 3934 bytes --]

Re: gcc-4.7.inc wrong FILESPATH setting?

[Paul Eggleton]

On Monday 17 December 2012 14:51:59 Giuseppe Condorelli wrote:
> 2012/12/14 Robert P. J. Day <rpjday@crashcourse.ca>
> 
> > On Fri, 14 Dec 2012, Giuseppe Condorelli wrote:
> > > 2012/12/14 Robert P. J. Day <rpjday@crashcourse.ca>
> > > 
> > >       On Fri, 14 Dec 2012, Marko Katić wrote:
> > >       > On Fri, 2012-12-14 at 17:41 +0100, Giuseppe Condorelli wrote:
> > >       > > Hi All,
> > >       > > 
> > >       > > I've seen that, in the given .inc file, the FILESPATH is
> > 
> > statically
> > 
> > >       > > set to
> > >       > > 
> > >       > > FILESPATH = "${FILE_DIRNAME}/gcc-4.7"
> > >       > > 
> > >       > > This seems to avoid any FILESEXTRAPATHS_prepend usage on
> > 
> > append file.
> > 
> > >       > > I need to add further patches for gcc-4.7.2 in my own meta
> > 
> > layer but
> > 
> > >       > > if I set the FILESEXTRAPATHS_prepend as usual
> > >       > > nothing happens, sources are taken only from the directory set
> > 
> > by
> > 
> > >       > > FILESPATH.
> > >       > > Also I saw this setting was different in the past
> > >       > > 
> > >       > > FILESPATH = "${@base_set_filespath([ '${FILE_DIRNAME}/gcc-4.7'
> > 
> > ], d)}"
> > 
> > >   i'm fairly sure i posted on this recently.  base.bbclass
> > > 
> > > *explicitly* sets FILESPATH to a set of variations thusly:
> > > 
> > > FILESPATH = "${@base_set_filespath(["${FILE_DIRNAME}/${BP}",
> > 
> > "${FILE_DIRNAME}/${BPN}", "${FILE_DIRNAME}/files"], d)}"
> > 
> > > which works fine with the recipes in the underlying oe-core layer.
> > > 
> > >   however, when you use FILESEXTRAPATHS_prepend, you get additional
> > > 
> > > directories based on *only* the name you specify.  so if you do:
> > > 
> > > FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> > > 
> > > are you thinking you should also get all variations of "gcc-4.7"?
> > > because that's not what's going to happen.
> > > 
> > > I'm sorry, I've not catched your last sentence. I set (as in the
> > > past) the FILESEXTRAPATHS_prepend := "${THISDIR}/files:"
> > > also updating the SRC_URI inside the .bbappend file to use the
> > > sources available in the gcc directory available in my own layer.
> > > 
> >   did you also set THISDIR just above that?
> 
> No, I don't set it. Is it necessary now?

No, THISDIR is set automatically, you should not set it yourself.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: gcc-4.7.inc wrong FILESPATH setting?

[Giuseppe Condorelli]

[-- Attachment #1: Type: text/plain, Size: 3013 bytes --]

Hi Paul and all,

coming back to this discussion....
It seems that setting FILESPATH in the gcc .inc file doesn't allow system
to recognize the FILESEXTRAPATHS_prepend setting in the append file.
I'm wondering if you can test this scenario, maybe creating a gcc append
recipe to add a dummy file in the SRC_URI list.

Cheers,
Giuseppe
2012/12/19 Paul Eggleton <paul.eggleton@linux.intel.com>

> On Monday 17 December 2012 14:51:59 Giuseppe Condorelli wrote:
> > 2012/12/14 Robert P. J. Day <rpjday@crashcourse.ca>
> >
> > > On Fri, 14 Dec 2012, Giuseppe Condorelli wrote:
> > > > 2012/12/14 Robert P. J. Day <rpjday@crashcourse.ca>
> > > >
> > > >       On Fri, 14 Dec 2012, Marko Katić wrote:
> > > >       > On Fri, 2012-12-14 at 17:41 +0100, Giuseppe Condorelli wrote:
> > > >       > > Hi All,
> > > >       > >
> > > >       > > I've seen that, in the given .inc file, the FILESPATH is
> > >
> > > statically
> > >
> > > >       > > set to
> > > >       > >
> > > >       > > FILESPATH = "${FILE_DIRNAME}/gcc-4.7"
> > > >       > >
> > > >       > > This seems to avoid any FILESEXTRAPATHS_prepend usage on
> > >
> > > append file.
> > >
> > > >       > > I need to add further patches for gcc-4.7.2 in my own meta
> > >
> > > layer but
> > >
> > > >       > > if I set the FILESEXTRAPATHS_prepend as usual
> > > >       > > nothing happens, sources are taken only from the directory
> set
> > >
> > > by
> > >
> > > >       > > FILESPATH.
> > > >       > > Also I saw this setting was different in the past
> > > >       > >
> > > >       > > FILESPATH = "${@base_set_filespath([
> '${FILE_DIRNAME}/gcc-4.7'
> > >
> > > ], d)}"
> > >
> > > >   i'm fairly sure i posted on this recently.  base.bbclass
> > > >
> > > > *explicitly* sets FILESPATH to a set of variations thusly:
> > > >
> > > > FILESPATH = "${@base_set_filespath(["${FILE_DIRNAME}/${BP}",
> > >
> > > "${FILE_DIRNAME}/${BPN}", "${FILE_DIRNAME}/files"], d)}"
> > >
> > > > which works fine with the recipes in the underlying oe-core layer.
> > > >
> > > >   however, when you use FILESEXTRAPATHS_prepend, you get additional
> > > >
> > > > directories based on *only* the name you specify.  so if you do:
> > > >
> > > > FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> > > >
> > > > are you thinking you should also get all variations of "gcc-4.7"?
> > > > because that's not what's going to happen.
> > > >
> > > > I'm sorry, I've not catched your last sentence. I set (as in the
> > > > past) the FILESEXTRAPATHS_prepend := "${THISDIR}/files:"
> > > > also updating the SRC_URI inside the .bbappend file to use the
> > > > sources available in the gcc directory available in my own layer.
> > > >
> > >   did you also set THISDIR just above that?
> >
> > No, I don't set it. Is it necessary now?
>
> No, THISDIR is set automatically, you should not set it yourself.
>
> Cheers,
> Paul
>
> --
>
> Paul Eggleton
> Intel Open Source Technology Centre
>

[-- Attachment #2: Type: text/html, Size: 4529 bytes --]