Re: [OE-core] [master][PATCH] kernel-devsrc: fix missing RDEPENDS gawk and make

[claus.stovgaard@gmail.com]

On Thu, 2024-02-01 at 08:41 -0500, Bruce Ashfield wrote:
> On Thu, Feb 1, 2024 at 8:31 AM <claus.stovgaard@gmail.com> wrote:
> > 
> > 
> > Thanks for your quick reply Bruce
> > 
> > On Thu, 2024-02-01 at 07:45 -0500, Bruce Ashfield wrote:
> > > On Thu, Feb 1, 2024 at 6:54 AM Claus Stovgaard
> > > <claus.stovgaard@gmail.com> wrote:
> > > > 
> > > > gawk is also needed for x86-64. See scripts/check-sysctl-docs
> > > > Since version 6.6 the package rules has been split up into a
> > > > rules
> > > > file
> > > > resulting in the need for make. See
> > > > scripts/package/debian/rules
> > > 
> > > When I looked, the rules aren't actually used when we are
> > > building an
> > > out
> > > of tree module (and via make scripts prepare) indirectly.
> > > 
> > > In a situation like this the approach I've taken to exclude the
> > > source from
> > > devsrc to keep it minimal.
> > 
> > Okay. I will patch the do_install instead and remove the debian
> > rules
> > file. I don't see the usage either so it is fine with me.
> 
> Just remove it in kernel-devsrc's copy of things. We can let the
> kernel continue to install them, we just don't need them in kernel-
> devsrc
> itself.
> 

I have sent a new patch to rm the rules file - removing the need for
make, as you suggested.

> > 
> > > 
> > > If you are seeing gawk required as part of building a module or
> > > make
> > > scripts prepare, then we definitely do need to add the
> > > dependency.
> > > 
> > 
> > I can see we are including the scripts/check-sysctl-docs and
> > objdump-
> > func needing gawk - no matter the architecture.
> > 
> > Alternative we should properly remove those also.
> 
> We definitely can, if they are bringing in something we don't need to
> prepare the source tree for building modules.
> 
> The ones I've added over time have all been related to that.
> 
> Bruce
> 

I looked a bit more into it, and I could remove the check-sysctl-docs
script, but it will still end up needing an awk.
(Also check-sysctl-docs has been there since 5.10)

A quick look revealed the folloing files.

usr/src/kernel/arch/x86/tools/gen-insn-attr-x86.awk:#!/usr/bin/awk -f
usr/src/kernel/scripts/ver_linux:#!/usr/bin/awk -f
usr/src/kernel/tools/arch/x86/tools/gen-insn-attr-86.awk:#!/usr/bin/awk
-f

My guess is that for all normal SDK's a awk/gawk has always been
present, hiding the issue. So I would suggest that we just change the
RDEPEND to cover all architectures, and not depend on some other
package include gawk.

(I only noticed the gawk issue, because I had a SDK with had the "make"
issue, and created the most basic setup to reproduce it with poky only.
For all normal SDK's I would expect it to include gawk)

What do you think Bruce?

/Claus



> > 
> > Will split it up in two commits, and start with the "make" fix
> > 
> > /Claus
> > 
> > 
> > >