Re: [OE-core] [master][PATCH] kernel-devsrc: fix missing RDEPENDS gawk and make

[claus.stovgaard@gmail.com]

Thanks for your quick reply Bruce

On Thu, 2024-02-01 at 07:45 -0500, Bruce Ashfield wrote:
> On Thu, Feb 1, 2024 at 6:54 AM Claus Stovgaard
> <claus.stovgaard@gmail.com> wrote:
> > 
> > gawk is also needed for x86-64. See scripts/check-sysctl-docs
> > Since version 6.6 the package rules has been split up into a rules
> > file
> > resulting in the need for make. See scripts/package/debian/rules
> 
> When I looked, the rules aren't actually used when we are building an
> out
> of tree module (and via make scripts prepare) indirectly.
> 
> In a situation like this the approach I've taken to exclude the
> source from
> devsrc to keep it minimal.

Okay. I will patch the do_install instead and remove the debian rules
file. I don't see the usage either so it is fine with me.

> 
> If you are seeing gawk required as part of building a module or make
> scripts prepare, then we definitely do need to add the dependency.
> 

I can see we are including the scripts/check-sysctl-docs and objdump-
func needing gawk - no matter the architecture.

Alternative we should properly remove those also.

Will split it up in two commits, and start with the "make" fix

/Claus


> > 
> > For reproducing the issue on a normal qemux86-64 machine, change to
> > the
> > linux-yocto-dev kernel, add the kernel-devsrc to the toolchain
> > target
> > task and disable ptest in distro features. (Notice ptest pulls gawk
> > and
> > make in as RDEPENDS for other packages hiding the issue)
> > 
> > when populating sdk you will see dnf failing.
> > 
> >  Problem: conflicting requests
> >   - nothing provides /usr/bin/gawk needed by kernel-devsrc-1.0-
> > r0.qemux86_64 from oe-repo
> >   - nothing provides /usr/bin/make needed by kernel-devsrc-1.0-
> > r0.qemux86_64 from oe-repo
> > 
> > Signed-off-by: Claus Stovgaard <claus.stovgaard@gmail.com>
> > ---
> >  meta/recipes-kernel/linux/kernel-devsrc.bb | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> > 
> > diff --git a/meta/recipes-kernel/linux/kernel-devsrc.bb
> > b/meta/recipes-kernel/linux/kernel-devsrc.bb
> > index ce5777fbe9..222f6cf8e1 100644
> > --- a/meta/recipes-kernel/linux/kernel-devsrc.bb
> > +++ b/meta/recipes-kernel/linux/kernel-devsrc.bb
> > @@ -395,7 +395,9 @@ RDEPENDS:${PN} += "${@bb.utils.contains('ARCH',
> > 'x86', 'elfutils-dev', '', d)}"
> >  RDEPENDS:${PN} += "${@bb.utils.contains('ARCH', 'powerpc',
> > 'elfutils-dev', '', d)}"
> >  # 5.8+ needs gcc-plugins libmpc-dev
> >  RDEPENDS:${PN} += "gcc-plugins libmpc-dev"
> > -# 5.13+ needs awk for arm64
> > -RDEPENDS:${PN}:append:aarch64 = " gawk"
> > +# 5.13+ needs awk
> > +RDEPENDS:${PN} += "gawk"
> 
> The commit message should really say "all architectures require
> gawk", if this
> is the change we are making to the actual RDEPENDS itself.
> 
> >  # 5.13+ needs grep for powerpc
> >  RDEPENDS:${PN}:append:powerpc = " grep"
> > +# 6.6+ needs make for debian package rules
> > +RDEPENDS:${PN} += "make"
> 
> Similarly, we should just be removing the rules from devsrc if they
> aren't required
> and we can avoid this dependency.
> 
> Bruce
> 
> > --
> > 2.43.0
> > 
> > 
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#194584):
> > https://lists.openembedded.org/g/openembedded-core/message/194584
> > Mute This Topic:
> > https://lists.openembedded.org/mt/104095126/1050810
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe:
> > https://lists.openembedded.org/g/openembedded-core/unsub [
> > bruce.ashfield@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> > 
> 
> 
> --
> - Thou shalt not follow the NULL pointer, for chaos and madness await
> thee at its end
> - "Use the force Harry" - Gandalf, Star Trek II