* [PATCH] ltp: Add patch to correct failing build
@ 2012-06-01 7:52 Cristian Iorga
2012-06-02 16:59 ` Flanagan, Elizabeth
0 siblings, 1 reply; 9+ messages in thread
From: Cristian Iorga @ 2012-06-01 7:52 UTC (permalink / raw)
To: openembedded-core
ltp makefile does not interpret correctly the result of git describe
command and assumes that it is working with a git repo, while in fact
working with a source code archive.
Added a patch to corect makefile system.
Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
---
.../ltp/ltp/fix_building_fom_archive.patch | 23 ++++++++++++++++++++
meta/recipes-extended/ltp/ltp_20120401.bb | 4 ++--
2 files changed, 25 insertions(+), 2 deletions(-)
create mode 100644 meta/recipes-extended/ltp/ltp/fix_building_fom_archive.patch
diff --git a/meta/recipes-extended/ltp/ltp/fix_building_fom_archive.patch b/meta/recipes-extended/ltp/ltp/fix_building_fom_archive.patch
new file mode 100644
index 0000000..c0ecc86
--- /dev/null
+++ b/meta/recipes-extended/ltp/ltp/fix_building_fom_archive.patch
@@ -0,0 +1,23 @@
+ltp package build system is broken if building from archive
+
+ltp makefile does not interpret correctly the result of git describe
+command and assumes that it is working with a git repo, while in fact
+working with a source code archive.
+
+Upstream-Status: Pending
+Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
+
+Index: ltp-20120401/Makefile
+===================================================================
+--- ltp-20120401.orig/Makefile
++++ ltp-20120401/Makefile
+@@ -173,7 +173,8 @@ SRCDIR_INSTALL_TARGETS := $(SRCDIR_INSTA
+ #
+ .PHONY: Version
+ Version:
+- if git describe &> /dev/null; then \
++ git describe &> /dev/null
++ if [ $? -eq 0 ]; then \
+ git describe > "$@"; \
+ else \
+ cp VERSION "$@"; \
diff --git a/meta/recipes-extended/ltp/ltp_20120401.bb b/meta/recipes-extended/ltp/ltp_20120401.bb
index 912d6d9..563bd58 100644
--- a/meta/recipes-extended/ltp/ltp_20120401.bb
+++ b/meta/recipes-extended/ltp/ltp_20120401.bb
@@ -21,10 +21,10 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
DEPENDS = "attr"
-PR = "r3"
+PR = "r4"
SRC_URI = "${SOURCEFORGE_MIRROR}/ltp/ltp-full-${PV}.bz2 \
- "
+ file://fix_building_fom_archive.patch"
SRC_URI[md5sum] = "e1d0acf1a6b6da0cb30dc1b0dcf5f26d"
SRC_URI[sha256sum] = "f0f5845f9666f61332fdf0b7e396fc647f9372db0902a829af2cf9402b807bd1"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] ltp: Add patch to correct failing build
2012-06-01 7:52 [PATCH] ltp: Add patch to correct failing build Cristian Iorga
@ 2012-06-02 16:59 ` Flanagan, Elizabeth
2012-06-04 17:51 ` Andrei Gherzan
2012-06-05 0:19 ` Saul Wold
0 siblings, 2 replies; 9+ messages in thread
From: Flanagan, Elizabeth @ 2012-06-02 16:59 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Fri, Jun 1, 2012 at 12:52 AM, Cristian Iorga
<cristian.iorga@intel.com> wrote:
> ltp makefile does not interpret correctly the result of git describe
> command and assumes that it is working with a git repo, while in fact
> working with a source code archive.
> Added a patch to corect makefile system.
>
> Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
> ---
> .../ltp/ltp/fix_building_fom_archive.patch | 23 ++++++++++++++++++++
> meta/recipes-extended/ltp/ltp_20120401.bb | 4 ++--
> 2 files changed, 25 insertions(+), 2 deletions(-)
> create mode 100644 meta/recipes-extended/ltp/ltp/fix_building_fom_archive.patch
>
> diff --git a/meta/recipes-extended/ltp/ltp/fix_building_fom_archive.patch b/meta/recipes-extended/ltp/ltp/fix_building_fom_archive.patch
> new file mode 100644
> index 0000000..c0ecc86
> --- /dev/null
> +++ b/meta/recipes-extended/ltp/ltp/fix_building_fom_archive.patch
> @@ -0,0 +1,23 @@
> +ltp package build system is broken if building from archive
> +
> +ltp makefile does not interpret correctly the result of git describe
> +command and assumes that it is working with a git repo, while in fact
> +working with a source code archive.
> +
> +Upstream-Status: Pending
> +Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
> +
> +Index: ltp-20120401/Makefile
> +===================================================================
> +--- ltp-20120401.orig/Makefile
> ++++ ltp-20120401/Makefile
> +@@ -173,7 +173,8 @@ SRCDIR_INSTALL_TARGETS := $(SRCDIR_INSTA
> + #
> + .PHONY: Version
> + Version:
> +- if git describe &> /dev/null; then \
> ++ git describe &> /dev/null
> ++ if [ $? -eq 0 ]; then \
> + git describe > "$@"; \
> + else \
> + cp VERSION "$@"; \
> diff --git a/meta/recipes-extended/ltp/ltp_20120401.bb b/meta/recipes-extended/ltp/ltp_20120401.bb
> index 912d6d9..563bd58 100644
> --- a/meta/recipes-extended/ltp/ltp_20120401.bb
> +++ b/meta/recipes-extended/ltp/ltp_20120401.bb
> @@ -21,10 +21,10 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
>
> DEPENDS = "attr"
>
> -PR = "r3"
> +PR = "r4"
>
> SRC_URI = "${SOURCEFORGE_MIRROR}/ltp/ltp-full-${PV}.bz2 \
> - "
> + file://fix_building_fom_archive.patch"
>
> SRC_URI[md5sum] = "e1d0acf1a6b6da0cb30dc1b0dcf5f26d"
> SRC_URI[sha256sum] = "f0f5845f9666f61332fdf0b7e396fc647f9372db0902a829af2cf9402b807bd1"
> --
> 1.7.9.5
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
This patch seems to be causing build failures:
| ERROR: Function failed: do_compile (see
/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/ppc603e-poky-linux/ltp-20120401-r4/temp/log.do_compile.695
for further information)
| NOTE: make -j 16
| make -C "lib" \
| -f "/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/ppc603e-poky-linux/ltp-20120401-r4/ltp-20120401/lib/Makefile"
all
| git describe &> /dev/null
| make: *** [Version] Error 128
| make: *** Waiting for unfinished jobs....
| make[1]: Entering directory
`/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/ppc603e-poky-linux/ltp-20120401-r4/ltp-20120401/lib'
| make[1]: Nothing to be done for `all'.
| make[1]: Leaving directory
`/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/ppc603e-poky-linux/ltp-20120401-r4/ltp-20120401/lib'
| ERROR: oe_runmake failed
-b
--
Elizabeth Flanagan
Yocto Project
Build and Release
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] ltp: Add patch to correct failing build
2012-06-02 16:59 ` Flanagan, Elizabeth
@ 2012-06-04 17:51 ` Andrei Gherzan
2012-06-05 0:19 ` Saul Wold
1 sibling, 0 replies; 9+ messages in thread
From: Andrei Gherzan @ 2012-06-04 17:51 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 4320 bytes --]
Confirmed.
@g
On Sat, Jun 2, 2012 at 7:59 PM, Flanagan, Elizabeth <
elizabeth.flanagan@intel.com> wrote:
> On Fri, Jun 1, 2012 at 12:52 AM, Cristian Iorga
> <cristian.iorga@intel.com> wrote:
> > ltp makefile does not interpret correctly the result of git describe
> > command and assumes that it is working with a git repo, while in fact
> > working with a source code archive.
> > Added a patch to corect makefile system.
> >
> > Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
> > ---
> > .../ltp/ltp/fix_building_fom_archive.patch | 23
> ++++++++++++++++++++
> > meta/recipes-extended/ltp/ltp_20120401.bb | 4 ++--
> > 2 files changed, 25 insertions(+), 2 deletions(-)
> > create mode 100644
> meta/recipes-extended/ltp/ltp/fix_building_fom_archive.patch
> >
> > diff --git
> a/meta/recipes-extended/ltp/ltp/fix_building_fom_archive.patch
> b/meta/recipes-extended/ltp/ltp/fix_building_fom_archive.patch
> > new file mode 100644
> > index 0000000..c0ecc86
> > --- /dev/null
> > +++ b/meta/recipes-extended/ltp/ltp/fix_building_fom_archive.patch
> > @@ -0,0 +1,23 @@
> > +ltp package build system is broken if building from archive
> > +
> > +ltp makefile does not interpret correctly the result of git describe
> > +command and assumes that it is working with a git repo, while in fact
> > +working with a source code archive.
> > +
> > +Upstream-Status: Pending
> > +Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
> > +
> > +Index: ltp-20120401/Makefile
> > +===================================================================
> > +--- ltp-20120401.orig/Makefile
> > ++++ ltp-20120401/Makefile
> > +@@ -173,7 +173,8 @@ SRCDIR_INSTALL_TARGETS := $(SRCDIR_INSTA
> > + #
> > + .PHONY: Version
> > + Version:
> > +- if git describe &> /dev/null; then \
> > ++ git describe &> /dev/null
> > ++ if [ $? -eq 0 ]; then \
> > + git describe > "$@"; \
> > + else \
> > + cp VERSION "$@"; \
> > diff --git a/meta/recipes-extended/ltp/ltp_20120401.bbb/meta/recipes-extended/ltp/
> ltp_20120401.bb
> > index 912d6d9..563bd58 100644
> > --- a/meta/recipes-extended/ltp/ltp_20120401.bb
> > +++ b/meta/recipes-extended/ltp/ltp_20120401.bb
> > @@ -21,10 +21,10 @@ LIC_FILES_CHKSUM =
> "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
> >
> > DEPENDS = "attr"
> >
> > -PR = "r3"
> > +PR = "r4"
> >
> > SRC_URI = "${SOURCEFORGE_MIRROR}/ltp/ltp-full-${PV}.bz2 \
> > - "
> > + file://fix_building_fom_archive.patch"
> >
> > SRC_URI[md5sum] = "e1d0acf1a6b6da0cb30dc1b0dcf5f26d"
> > SRC_URI[sha256sum] =
> "f0f5845f9666f61332fdf0b7e396fc647f9372db0902a829af2cf9402b807bd1"
> > --
> > 1.7.9.5
> >
> >
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
> This patch seems to be causing build failures:
>
> | ERROR: Function failed: do_compile (see
>
> /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/ppc603e-poky-linux/ltp-20120401-r4/temp/log.do_compile.695
> for further information)
> | NOTE: make -j 16
> | make -C "lib" \
> | -f
> "/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/ppc603e-poky-linux/ltp-20120401-r4/ltp-20120401/lib/Makefile"
> all
> | git describe &> /dev/null
> | make: *** [Version] Error 128
> | make: *** Waiting for unfinished jobs....
> | make[1]: Entering directory
>
> `/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/ppc603e-poky-linux/ltp-20120401-r4/ltp-20120401/lib'
> | make[1]: Nothing to be done for `all'.
> | make[1]: Leaving directory
>
> `/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/ppc603e-poky-linux/ltp-20120401-r4/ltp-20120401/lib'
> | ERROR: oe_runmake failed
>
>
>
> -b
>
> --
> Elizabeth Flanagan
> Yocto Project
> Build and Release
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
[-- Attachment #2: Type: text/html, Size: 6125 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] ltp: Add patch to correct failing build
2012-06-02 16:59 ` Flanagan, Elizabeth
2012-06-04 17:51 ` Andrei Gherzan
@ 2012-06-05 0:19 ` Saul Wold
2012-06-05 7:30 ` Iorga, Cristian
1 sibling, 1 reply; 9+ messages in thread
From: Saul Wold @ 2012-06-05 0:19 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On 06/02/2012 09:59 AM, Flanagan, Elizabeth wrote:
> On Fri, Jun 1, 2012 at 12:52 AM, Cristian Iorga
> <cristian.iorga@intel.com> wrote:
>> ltp makefile does not interpret correctly the result of git describe
>> command and assumes that it is working with a git repo, while in fact
>> working with a source code archive.
>> Added a patch to corect makefile system.
>>
>> Signed-off-by: Cristian Iorga<cristian.iorga@intel.com>
>> ---
>> .../ltp/ltp/fix_building_fom_archive.patch | 23 ++++++++++++++++++++
>> meta/recipes-extended/ltp/ltp_20120401.bb | 4 ++--
>> 2 files changed, 25 insertions(+), 2 deletions(-)
>> create mode 100644 meta/recipes-extended/ltp/ltp/fix_building_fom_archive.patch
>>
>> diff --git a/meta/recipes-extended/ltp/ltp/fix_building_fom_archive.patch b/meta/recipes-extended/ltp/ltp/fix_building_fom_archive.patch
>> new file mode 100644
>> index 0000000..c0ecc86
>> --- /dev/null
>> +++ b/meta/recipes-extended/ltp/ltp/fix_building_fom_archive.patch
>> @@ -0,0 +1,23 @@
>> +ltp package build system is broken if building from archive
>> +
>> +ltp makefile does not interpret correctly the result of git describe
>> +command and assumes that it is working with a git repo, while in fact
>> +working with a source code archive.
>> +
>> +Upstream-Status: Pending
>> +Signed-off-by: Cristian Iorga<cristian.iorga@intel.com>
>> +
>> +Index: ltp-20120401/Makefile
>> +===================================================================
>> +--- ltp-20120401.orig/Makefile
>> ++++ ltp-20120401/Makefile
>> +@@ -173,7 +173,8 @@ SRCDIR_INSTALL_TARGETS := $(SRCDIR_INSTA
>> + #
>> + .PHONY: Version
>> + Version:
>> +- if git describe&> /dev/null; then \
>> ++ git describe&> /dev/null
>> ++ if [ $? -eq 0 ]; then \
>> + git describe> "$@"; \
>> + else \
>> + cp VERSION "$@"; \
>> diff --git a/meta/recipes-extended/ltp/ltp_20120401.bb b/meta/recipes-extended/ltp/ltp_20120401.bb
>> index 912d6d9..563bd58 100644
>> --- a/meta/recipes-extended/ltp/ltp_20120401.bb
>> +++ b/meta/recipes-extended/ltp/ltp_20120401.bb
>> @@ -21,10 +21,10 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
>>
>> DEPENDS = "attr"
>>
>> -PR = "r3"
>> +PR = "r4"
>>
>> SRC_URI = "${SOURCEFORGE_MIRROR}/ltp/ltp-full-${PV}.bz2 \
>> - "
>> + file://fix_building_fom_archive.patch"
>>
>> SRC_URI[md5sum] = "e1d0acf1a6b6da0cb30dc1b0dcf5f26d"
>> SRC_URI[sha256sum] = "f0f5845f9666f61332fdf0b7e396fc647f9372db0902a829af2cf9402b807bd1"
>> --
>> 1.7.9.5
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
> This patch seems to be causing build failures:
>
> | ERROR: Function failed: do_compile (see
> /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/ppc603e-poky-linux/ltp-20120401-r4/temp/log.do_compile.695
> for further information)
> | NOTE: make -j 16
> | make -C "lib" \
> | -f "/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/ppc603e-poky-linux/ltp-20120401-r4/ltp-20120401/lib/Makefile"
> all
> | git describe&> /dev/null
> | make: *** [Version] Error 128
> | make: *** Waiting for unfinished jobs....
> | make[1]: Entering directory
> `/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/ppc603e-poky-linux/ltp-20120401-r4/ltp-20120401/lib'
> | make[1]: Nothing to be done for `all'.
> | make[1]: Leaving directory
> `/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/ppc603e-poky-linux/ltp-20120401-r4/ltp-20120401/lib'
> | ERROR: oe_runmake failed
>
>
You might want to use "-git describe&> /dev/null", as this will ignore
errors, I thought you tested the final patch?
From the make manual pages:
To ignore errors in a recipe line, write a ‘-’ at the beginning of the
line's text (after the initial tab). The ‘-’ is discarded before the
line is passed to the shell for execution.
For example,
clean:
-rm -f *.o
This causes make to continue even if rm is unable to remove a file.
>
> -b
>
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] ltp: Add patch to correct failing build
2012-06-05 0:19 ` Saul Wold
@ 2012-06-05 7:30 ` Iorga, Cristian
2012-06-05 13:29 ` Iorga, Cristian
0 siblings, 1 reply; 9+ messages in thread
From: Iorga, Cristian @ 2012-06-05 7:30 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
Hello all,
@Saul: Of course I have tested the final patch, I will re-test and get back to you.
It worked for me.
Thanks,
Cristian
-----Original Message-----
From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of Saul Wold
Sent: Tuesday, June 05, 2012 3:20 AM
To: Patches and discussions about the oe-core layer
Subject: Re: [OE-core] [PATCH] ltp: Add patch to correct failing build
On 06/02/2012 09:59 AM, Flanagan, Elizabeth wrote:
> On Fri, Jun 1, 2012 at 12:52 AM, Cristian Iorga
> <cristian.iorga@intel.com> wrote:
>> ltp makefile does not interpret correctly the result of git describe
>> command and assumes that it is working with a git repo, while in fact
>> working with a source code archive.
>> Added a patch to corect makefile system.
>>
>> Signed-off-by: Cristian Iorga<cristian.iorga@intel.com>
>> ---
>> .../ltp/ltp/fix_building_fom_archive.patch | 23 ++++++++++++++++++++
>> meta/recipes-extended/ltp/ltp_20120401.bb | 4 ++--
>> 2 files changed, 25 insertions(+), 2 deletions(-)
>> create mode 100644
>> meta/recipes-extended/ltp/ltp/fix_building_fom_archive.patch
>>
>> diff --git
>> a/meta/recipes-extended/ltp/ltp/fix_building_fom_archive.patch
>> b/meta/recipes-extended/ltp/ltp/fix_building_fom_archive.patch
>> new file mode 100644
>> index 0000000..c0ecc86
>> --- /dev/null
>> +++ b/meta/recipes-extended/ltp/ltp/fix_building_fom_archive.patch
>> @@ -0,0 +1,23 @@
>> +ltp package build system is broken if building from archive
>> +
>> +ltp makefile does not interpret correctly the result of git describe
>> +command and assumes that it is working with a git repo, while in
>> +fact working with a source code archive.
>> +
>> +Upstream-Status: Pending
>> +Signed-off-by: Cristian Iorga<cristian.iorga@intel.com>
>> +
>> +Index: ltp-20120401/Makefile
>> +===================================================================
>> +--- ltp-20120401.orig/Makefile
>> ++++ ltp-20120401/Makefile
>> +@@ -173,7 +173,8 @@ SRCDIR_INSTALL_TARGETS := $(SRCDIR_INSTA
>> + #
>> + .PHONY: Version
>> + Version:
>> +- if git describe&> /dev/null; then \
>> ++ git describe&> /dev/null
>> ++ if [ $? -eq 0 ]; then \
>> + git describe> "$@"; \
>> + else \
>> + cp VERSION "$@"; \
>> diff --git a/meta/recipes-extended/ltp/ltp_20120401.bb
>> b/meta/recipes-extended/ltp/ltp_20120401.bb
>> index 912d6d9..563bd58 100644
>> --- a/meta/recipes-extended/ltp/ltp_20120401.bb
>> +++ b/meta/recipes-extended/ltp/ltp_20120401.bb
>> @@ -21,10 +21,10 @@ LIC_FILES_CHKSUM =
>> "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
>>
>> DEPENDS = "attr"
>>
>> -PR = "r3"
>> +PR = "r4"
>>
>> SRC_URI = "${SOURCEFORGE_MIRROR}/ltp/ltp-full-${PV}.bz2 \
>> - "
>> + file://fix_building_fom_archive.patch"
>>
>> SRC_URI[md5sum] = "e1d0acf1a6b6da0cb30dc1b0dcf5f26d"
>> SRC_URI[sha256sum] = "f0f5845f9666f61332fdf0b7e396fc647f9372db0902a829af2cf9402b807bd1"
>> --
>> 1.7.9.5
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
> This patch seems to be causing build failures:
>
> | ERROR: Function failed: do_compile (see
> /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/bu
> ild/tmp/work/ppc603e-poky-linux/ltp-20120401-r4/temp/log.do_compile.69
> 5
> for further information)
> | NOTE: make -j 16
> | make -C "lib" \
> | -f "/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/ppc603e-poky-linux/ltp-20120401-r4/ltp-20120401/lib/Makefile"
> all
> | git describe&> /dev/null
> | make: *** [Version] Error 128
> | make: *** Waiting for unfinished jobs....
> | make[1]: Entering directory
> `/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/ppc603e-poky-linux/ltp-20120401-r4/ltp-20120401/lib'
> | make[1]: Nothing to be done for `all'.
> | make[1]: Leaving directory
> `/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/ppc603e-poky-linux/ltp-20120401-r4/ltp-20120401/lib'
> | ERROR: oe_runmake failed
>
>
You might want to use "-git describe&> /dev/null", as this will ignore errors, I thought you tested the final patch?
From the make manual pages:
To ignore errors in a recipe line, write a '-' at the beginning of the line's text (after the initial tab). The '-' is discarded before the line is passed to the shell for execution.
For example,
clean:
-rm -f *.o
This causes make to continue even if rm is unable to remove a file.
>
> -b
>
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] ltp: Add patch to correct failing build
2012-06-05 7:30 ` Iorga, Cristian
@ 2012-06-05 13:29 ` Iorga, Cristian
2012-06-10 21:57 ` Paul Eggleton
0 siblings, 1 reply; 9+ messages in thread
From: Iorga, Cristian @ 2012-06-05 13:29 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
Hello,
&> does not work correctly in dash, working to correct the issue.
I have tested it by making the target (bitbake ltp), but it is safe to assume that make Version is not issued during normal build.
Will propose a new patch.
Thanks,
Cristian
-----Original Message-----
From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of Iorga, Cristian
Sent: Tuesday, June 05, 2012 10:31 AM
To: Patches and discussions about the oe-core layer
Subject: Re: [OE-core] [PATCH] ltp: Add patch to correct failing build
Hello all,
@Saul: Of course I have tested the final patch, I will re-test and get back to you.
It worked for me.
Thanks,
Cristian
-----Original Message-----
From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of Saul Wold
Sent: Tuesday, June 05, 2012 3:20 AM
To: Patches and discussions about the oe-core layer
Subject: Re: [OE-core] [PATCH] ltp: Add patch to correct failing build
On 06/02/2012 09:59 AM, Flanagan, Elizabeth wrote:
> On Fri, Jun 1, 2012 at 12:52 AM, Cristian Iorga
> <cristian.iorga@intel.com> wrote:
>> ltp makefile does not interpret correctly the result of git describe
>> command and assumes that it is working with a git repo, while in fact
>> working with a source code archive.
>> Added a patch to corect makefile system.
>>
>> Signed-off-by: Cristian Iorga<cristian.iorga@intel.com>
>> ---
>> .../ltp/ltp/fix_building_fom_archive.patch | 23 ++++++++++++++++++++
>> meta/recipes-extended/ltp/ltp_20120401.bb | 4 ++--
>> 2 files changed, 25 insertions(+), 2 deletions(-)
>> create mode 100644
>> meta/recipes-extended/ltp/ltp/fix_building_fom_archive.patch
>>
>> diff --git
>> a/meta/recipes-extended/ltp/ltp/fix_building_fom_archive.patch
>> b/meta/recipes-extended/ltp/ltp/fix_building_fom_archive.patch
>> new file mode 100644
>> index 0000000..c0ecc86
>> --- /dev/null
>> +++ b/meta/recipes-extended/ltp/ltp/fix_building_fom_archive.patch
>> @@ -0,0 +1,23 @@
>> +ltp package build system is broken if building from archive
>> +
>> +ltp makefile does not interpret correctly the result of git describe
>> +command and assumes that it is working with a git repo, while in
>> +fact working with a source code archive.
>> +
>> +Upstream-Status: Pending
>> +Signed-off-by: Cristian Iorga<cristian.iorga@intel.com>
>> +
>> +Index: ltp-20120401/Makefile
>> +===================================================================
>> +--- ltp-20120401.orig/Makefile
>> ++++ ltp-20120401/Makefile
>> +@@ -173,7 +173,8 @@ SRCDIR_INSTALL_TARGETS := $(SRCDIR_INSTA
>> + #
>> + .PHONY: Version
>> + Version:
>> +- if git describe&> /dev/null; then \
>> ++ git describe&> /dev/null
>> ++ if [ $? -eq 0 ]; then \
>> + git describe> "$@"; \
>> + else \
>> + cp VERSION "$@"; \
>> diff --git a/meta/recipes-extended/ltp/ltp_20120401.bb
>> b/meta/recipes-extended/ltp/ltp_20120401.bb
>> index 912d6d9..563bd58 100644
>> --- a/meta/recipes-extended/ltp/ltp_20120401.bb
>> +++ b/meta/recipes-extended/ltp/ltp_20120401.bb
>> @@ -21,10 +21,10 @@ LIC_FILES_CHKSUM =
>> "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
>>
>> DEPENDS = "attr"
>>
>> -PR = "r3"
>> +PR = "r4"
>>
>> SRC_URI = "${SOURCEFORGE_MIRROR}/ltp/ltp-full-${PV}.bz2 \
>> - "
>> + file://fix_building_fom_archive.patch"
>>
>> SRC_URI[md5sum] = "e1d0acf1a6b6da0cb30dc1b0dcf5f26d"
>> SRC_URI[sha256sum] = "f0f5845f9666f61332fdf0b7e396fc647f9372db0902a829af2cf9402b807bd1"
>> --
>> 1.7.9.5
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
> This patch seems to be causing build failures:
>
> | ERROR: Function failed: do_compile (see
> /srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/bu
> ild/tmp/work/ppc603e-poky-linux/ltp-20120401-r4/temp/log.do_compile.69
> 5
> for further information)
> | NOTE: make -j 16
> | make -C "lib" \
> | -f "/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/ppc603e-poky-linux/ltp-20120401-r4/ltp-20120401/lib/Makefile"
> all
> | git describe&> /dev/null
> | make: *** [Version] Error 128
> | make: *** Waiting for unfinished jobs....
> | make[1]: Entering directory
> `/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/ppc603e-poky-linux/ltp-20120401-r4/ltp-20120401/lib'
> | make[1]: Nothing to be done for `all'.
> | make[1]: Leaving directory
> `/srv/home/pokybuild/yocto-autobuilder/yocto-slave/nightly-ppc/build/build/tmp/work/ppc603e-poky-linux/ltp-20120401-r4/ltp-20120401/lib'
> | ERROR: oe_runmake failed
>
>
You might want to use "-git describe&> /dev/null", as this will ignore errors, I thought you tested the final patch?
From the make manual pages:
To ignore errors in a recipe line, write a '-' at the beginning of the line's text (after the initial tab). The '-' is discarded before the line is passed to the shell for execution.
For example,
clean:
-rm -f *.o
This causes make to continue even if rm is unable to remove a file.
>
> -b
>
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] ltp: Add patch to correct failing build
2012-06-05 13:29 ` Iorga, Cristian
@ 2012-06-10 21:57 ` Paul Eggleton
0 siblings, 0 replies; 9+ messages in thread
From: Paul Eggleton @ 2012-06-10 21:57 UTC (permalink / raw)
To: openembedded-core
On Tuesday 05 June 2012 13:29:20 Iorga, Cristian wrote:
> &> does not work correctly in dash, working to correct the issue.
> I have tested it by making the target (bitbake ltp), but it is safe to
> assume that make Version is not issued during normal build. Will propose a
> new patch.
Indeed, > filename 2>&1 is the recommended alternative. Sadly a git grep '&>'
shows that we are currently using this in a number of places, I guess we
should fix those.
FYI for anyone who hasn't already seen this page, it's a good reference for
this kind of thing:
http://mywiki.wooledge.org/Bashism
Cheers,
Paul
--
Paul Eggleton
Intel Open Source Technology Centre
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] ltp: Add patch to correct failing build
@ 2012-06-05 18:51 Cristian Iorga
2012-06-05 22:01 ` Richard Purdie
0 siblings, 1 reply; 9+ messages in thread
From: Cristian Iorga @ 2012-06-05 18:51 UTC (permalink / raw)
To: openembedded-core
ltp makefile does not interpret correctly the result of git describe
command and assumes that it is working with a git repo, while in fact
working with a source code archive.
Added a patch to corect makefile system.
Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
---
.../ltp/ltp/fix_building_fom_archive.patch | 13 +++++++++++++
meta/recipes-extended/ltp/ltp_20120401.bb | 4 ++--
2 files changed, 15 insertions(+), 2 deletions(-)
create mode 100644 meta/recipes-extended/ltp/ltp/fix_building_fom_archive.patch
diff --git a/meta/recipes-extended/ltp/ltp/fix_building_fom_archive.patch b/meta/recipes-extended/ltp/ltp/fix_building_fom_archive.patch
new file mode 100644
index 0000000..a8064cf
--- /dev/null
+++ b/meta/recipes-extended/ltp/ltp/fix_building_fom_archive.patch
@@ -0,0 +1,13 @@
+Index: ltp-20120401/Makefile
+===================================================================
+--- ltp-20120401.orig/Makefile
++++ ltp-20120401/Makefile
+@@ -173,7 +173,7 @@ SRCDIR_INSTALL_TARGETS := $(SRCDIR_INSTA
+ #
+ .PHONY: Version
+ Version:
+- if git describe &> /dev/null; then \
++ if git describe > /dev/null 2>&1; then \
+ git describe > "$@"; \
+ else \
+ cp VERSION "$@"; \
diff --git a/meta/recipes-extended/ltp/ltp_20120401.bb b/meta/recipes-extended/ltp/ltp_20120401.bb
index 912d6d9..563bd58 100644
--- a/meta/recipes-extended/ltp/ltp_20120401.bb
+++ b/meta/recipes-extended/ltp/ltp_20120401.bb
@@ -21,10 +21,10 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=0636e73ff0215e8d672dc4c32c317bb3 \
DEPENDS = "attr"
-PR = "r3"
+PR = "r4"
SRC_URI = "${SOURCEFORGE_MIRROR}/ltp/ltp-full-${PV}.bz2 \
- "
+ file://fix_building_fom_archive.patch"
SRC_URI[md5sum] = "e1d0acf1a6b6da0cb30dc1b0dcf5f26d"
SRC_URI[sha256sum] = "f0f5845f9666f61332fdf0b7e396fc647f9372db0902a829af2cf9402b807bd1"
--
1.7.9.5
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] ltp: Add patch to correct failing build
2012-06-05 18:51 Cristian Iorga
@ 2012-06-05 22:01 ` Richard Purdie
0 siblings, 0 replies; 9+ messages in thread
From: Richard Purdie @ 2012-06-05 22:01 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Tue, 2012-06-05 at 21:51 +0300, Cristian Iorga wrote:
> ltp makefile does not interpret correctly the result of git describe
> command and assumes that it is working with a git repo, while in fact
> working with a source code archive.
> Added a patch to corect makefile system.
>
> Signed-off-by: Cristian Iorga <cristian.iorga@intel.com>
> ---
> .../ltp/ltp/fix_building_fom_archive.patch | 13 +++++++++++++
> meta/recipes-extended/ltp/ltp_20120401.bb | 4 ++--
> 2 files changed, 15 insertions(+), 2 deletions(-)
> create mode 100644 meta/recipes-extended/ltp/ltp/fix_building_fom_archive.patch
Merged to master, thanks.
Richard
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2012-06-10 22:07 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-01 7:52 [PATCH] ltp: Add patch to correct failing build Cristian Iorga
2012-06-02 16:59 ` Flanagan, Elizabeth
2012-06-04 17:51 ` Andrei Gherzan
2012-06-05 0:19 ` Saul Wold
2012-06-05 7:30 ` Iorga, Cristian
2012-06-05 13:29 ` Iorga, Cristian
2012-06-10 21:57 ` Paul Eggleton
-- strict thread matches above, loose matches on Subject: below --
2012-06-05 18:51 Cristian Iorga
2012-06-05 22:01 ` Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox