Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Paul Eggleton <paul.eggleton@linux.intel.com>
To: Saul Wold <sgw@linux.intel.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [RFC PATCH] license: Ensure we find multilib packages also
Date: Thu, 13 Sep 2012 23:31:45 +0100	[thread overview]
Message-ID: <22844638.2V3OiWsK3u@helios> (raw)
In-Reply-To: <1347564379-14252-1-git-send-email-sgw@linux.intel.com>

On Thursday 13 September 2012 12:26:19 Saul Wold wrote:
> Make sure to find -package, this was causing a failure
> in the multi-lib build license generation during rootfs.
> 
> Signed-off-by: Saul Wold <sgw@linux.intel.com>
> ---
>  meta/classes/license.bbclass |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/meta/classes/license.bbclass b/meta/classes/license.bbclass
> index 29fe938..b29067c 100644
> --- a/meta/classes/license.bbclass
> +++ b/meta/classes/license.bbclass
> @@ -88,7 +88,7 @@ license_create_manifest() {
>  	# list of installed packages is broken for deb
>  	for pkg in ${INSTALLED_PKGS}; do
>  		# not the best way to do this but licenses are not arch dependant iirc
> -		filename=`ls ${TMPDIR}/pkgdata/*/runtime-reverse/${pkg}| head -1`
> +		filename=`ls ${TMPDIR}/pkgdata/*/runtime-reverse/*${pkg}| head -1`
>  		pkged_pn="$(sed -n 's/^PN: //p' ${filename})"
> 
>  		# exclude locale recipes

Surely this could end up matching a the wrong file when one package name is a 
substring of another?

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre



  reply	other threads:[~2012-09-13 22:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-13 19:26 [RFC PATCH] license: Ensure we find multilib packages also Saul Wold
2012-09-13 22:31 ` Paul Eggleton [this message]
2012-09-13 22:43   ` Saul Wold
2012-09-14 16:01     ` Richard Purdie
2012-09-14 16:48       ` Mark Hatle
2012-09-14 20:50         ` Flanagan, Elizabeth
2012-09-14 22:09           ` Richard Purdie
2012-09-14 22:11           ` Paul Eggleton
2012-09-14 22:26             ` Flanagan, Elizabeth
2012-09-14 22:31               ` Mark Hatle
2012-09-14 23:09               ` Paul Eggleton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22844638.2V3OiWsK3u@helios \
    --to=paul.eggleton@linux.intel.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=sgw@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox