From: "Livius" <egyszeregy@freemail.hu>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] archiver.bbclass: Fix work-shared checking for kernel recipes
Date: Tue, 11 Jun 2024 16:30:44 -0700 [thread overview]
Message-ID: <23837.1718148644454631767@lists.openembedded.org> (raw)
In-Reply-To: <642EEA27-10FD-40C7-8B06-24741CEA1548@arm.com>
S = "${WORKDIR}/git" does not contain "${TOPDIR}/work-shared" path, therefore "def is_work_shared(d):" will be returned with False and archiver is failed for linux kernel recipe (somewhy unpack is broken and kernel source is missing in work-shared folder in this situation).
https://github.com/openembedded/bitbake/blob/master/conf/bitbake.conf#L45
In default S = "${STAGING_KERNEL_DIR}" is the source path for a kernel. Archiver works only in this case when it is not changed to "${WORKDIR}/git" symbolic link folder. We can see "bb.data.inherits_class('kernel', d)" was in the of old code for checking it because of this situation when somebody like to use this kind of symbolic link git source solution. This should not have been dropped in last commit.
https://github.com/openembedded/openembedded-core/blob/master/meta/classes-recipe/kernel.bbclass#L26
WARNING: multiple messages have this Message-ID (diff)
From: "Livius" <egyszeregy@freemail.hu>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] archiver.bbclass: Fix work-shared checking for kernel recipes
Date: Tue, 11 Jun 2024 16:31:58 -0700 [thread overview]
Message-ID: <23837.1718148644454631767@lists.openembedded.org> (raw)
Message-ID: <20240611233158.IXqTFWduM7g2USabDjWwi-6PoEjWV12G6QuJUT7y340@z> (raw)
In-Reply-To: <642EEA27-10FD-40C7-8B06-24741CEA1548@arm.com>
S = "${WORKDIR}/git" does not contain "${TOPDIR}/work-shared" path, therefore "def is_work_shared(d):" will be returned with False and archiver is failed for linux kernel recipe (somewhy unpack is broken and kernel source is missing in work-shared folder in this situation).
https://github.com/openembedded/bitbake/blob/master/conf/bitbake.conf#L45
In default S = "${STAGING_KERNEL_DIR}" is the source path for a kernel. Archiver works only in this case when it is not changed to "${WORKDIR}/git" symbolic link folder. We can see "bb.data.inherits_class('kernel', d)" was in the of old code for checking it because of this situation when somebody like to use this kind of symbolic link git source solution. This should not have been dropped in last commit.
https://github.com/openembedded/openembedded-core/commit/5fbb4ca8da4f4f1ea426275c45634802dcb5a575#diff-7a2ccc0d645ec49c87c4956f90ab24ace5292140dff665459bbc94e4e72a8e07L473
https://github.com/openembedded/openembedded-core/blob/master/meta/classes-recipe/kernel.bbclass#L26
WARNING: multiple messages have this Message-ID (diff)
From: "Livius" <egyszeregy@freemail.hu>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] archiver.bbclass: Fix work-shared checking for kernel recipes
Date: Tue, 11 Jun 2024 16:33:42 -0700 [thread overview]
Message-ID: <23837.1718148644454631767@lists.openembedded.org> (raw)
Message-ID: <20240611233342.SYXS5XfgOoXuY7Hf9b_xIexACmCoMVMc5Zcj3PhSLFk@z> (raw)
In-Reply-To: <642EEA27-10FD-40C7-8B06-24741CEA1548@arm.com>
S = "${WORKDIR}/git" does not contain "${TMPDIR}/work-shared" path, therefore "def is_work_shared(d):" will be returned with False and archiver is failed for linux kernel recipe (somewhy unpack is broken and kernel source is missing in work-shared folder in this situation).
https://github.com/openembedded/bitbake/blob/master/conf/bitbake.conf#L45
In default S = "${STAGING_KERNEL_DIR}" is the source path for a kernel. Archiver works only in this case when it is not changed to "${WORKDIR}/git" symbolic link folder. We can see "bb.data.inherits_class('kernel', d)" was in the of old code for checking it because of this situation when somebody like to use this kind of symbolic link git source solution. This should not have been dropped in last commit.
https://github.com/openembedded/openembedded-core/commit/5fbb4ca8da4f4f1ea426275c45634802dcb5a575#diff-7a2ccc0d645ec49c87c4956f90ab24ace5292140dff665459bbc94e4e72a8e07L473
https://github.com/openembedded/openembedded-core/blob/master/meta/classes-recipe/kernel.bbclass#L26
WARNING: multiple messages have this Message-ID (diff)
From: "Livius" <egyszeregy@freemail.hu>
To: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH] archiver.bbclass: Fix work-shared checking for kernel recipes
Date: Tue, 11 Jun 2024 16:35:23 -0700 [thread overview]
Message-ID: <23837.1718148644454631767@lists.openembedded.org> (raw)
Message-ID: <20240611233523.sbphp3kCbnn59ghojoXtT9bf5N5NURnUnE_4YrwDOb8@z> (raw)
In-Reply-To: <642EEA27-10FD-40C7-8B06-24741CEA1548@arm.com>
S = "${WORKDIR}/git" does not contain "${TMPDIR}/work-shared" path, therefore "def is_work_shared(d):" will be returned with False and archiver is failed for linux kernel recipe (somewhy unpack is broken and kernel source is missing in work-shared folder in this situation).
https://github.com/openembedded/bitbake/blob/master/conf/bitbake.conf#L45
In default S = "${STAGING_KERNEL_DIR}" is the source path for a kernel. Now, archiver works only in this case when it is not changed to "${WORKDIR}/git" symbolic link folder. We can see "bb.data.inherits_class('kernel', d)" was in the old code for checking it because of this situation, when somebody like to use this kind of symbolic link git source solution. This should not have been dropped in last commit.
https://github.com/openembedded/openembedded-core/commit/5fbb4ca8da4f4f1ea426275c45634802dcb5a575#diff-7a2ccc0d645ec49c87c4956f90ab24ace5292140dff665459bbc94e4e72a8e07L473
https://github.com/openembedded/openembedded-core/blob/master/meta/classes-recipe/kernel.bbclass#L26
next prev parent reply other threads:[~2024-06-11 23:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 20:48 [PATCH] archiver.bbclass: Fix work-shared checking for kernel recipes egyszeregy
2024-06-06 21:04 ` Patchtest results for " patchtest
2024-06-06 21:38 ` Livius
2024-06-06 21:41 ` Livius
[not found] ` <Groupsio.1.8404.1717709883800685810@lists.openembedded.org>
2024-06-07 1:32 ` [OE-core] " Trevor Gamblin
2024-06-07 8:26 ` Livius
2024-06-11 10:48 ` [OE-core] " Ross Burton
2024-06-11 23:30 ` Livius [this message]
2024-06-11 23:31 ` Livius
2024-06-11 23:33 ` Livius
2024-06-11 23:35 ` Livius
[not found] ` <Groupsio.3.23837.1718148644454631767@lists.openembedded.org>
2024-06-12 9:31 ` [OE-core] " Jose Quaresma
2024-06-13 13:54 ` Livius
[not found] ` <17D837E52ADBFC1B.19992@lists.openembedded.org>
2024-06-13 12:21 ` [OE-core] " Jose Quaresma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23837.1718148644454631767@lists.openembedded.org \
--to=egyszeregy@freemail.hu \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox