[PATCH v4 1/4] glslang: upgrade 8.13.3743 -> 11.1.0

[PATCH v4 1/4] glslang: upgrade 8.13.3743 -> 11.1.0

[Jose Quaresma]

License-Update: Add additional licenses

- [1] BSD-2-Clause & MIT & Apache-2.0
- [2] GPL-3-with-bison-exception

[1] https://github.com/KhronosGroup/glslang/commit/2962be40baff69848fd786c609289666b60741b8
[2] https://github.com/KhronosGroup/glslang/commit/14a2cfbc72f2bb2e060fdfe3fbe6a4d54e3817a8

Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
---
 .../glslang/{glslang_8.13.3743.bb => glslang_11.1.0.bb}   | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)
 rename meta/recipes-graphics/glslang/{glslang_8.13.3743.bb => glslang_11.1.0.bb} (74%)

diff --git a/meta/recipes-graphics/glslang/glslang_8.13.3743.bb b/meta/recipes-graphics/glslang/glslang_11.1.0.bb
similarity index 74%
rename from meta/recipes-graphics/glslang/glslang_8.13.3743.bb
rename to meta/recipes-graphics/glslang/glslang_11.1.0.bb
index 2c4f4be5a2..f1cc966b2a 100644
--- a/meta/recipes-graphics/glslang/glslang_8.13.3743.bb
+++ b/meta/recipes-graphics/glslang/glslang_11.1.0.bb
@@ -5,16 +5,14 @@ of the specifications for these languages. It is open and free for anyone to use
 either from a command line or programmatically."
 SECTION = "graphics"
 HOMEPAGE = "https://www.khronos.org/opengles/sdk/tools/Reference-Compiler"
-LICENSE = "BSD-3-Clause"
-LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=918e668376010a04448a312fb37ae69b"
+LICENSE = "BSD-3-Clause & BSD-2-Clause & MIT & Apache-2.0 & GPL-3-with-bison-exception"
+LIC_FILES_CHKSUM = "file://LICENSE.txt;md5=c5ce49c0456e9b413b98a4368c378229"
 
-SRCREV = "e05cc20ec20a154d94256c744a3837c23719c0f9"
+SRCREV = "c594de23cdd790d64ad5f9c8b059baae0ee2941d"
 SRC_URI = "git://github.com/KhronosGroup/glslang.git;protocol=https"
 UPSTREAM_CHECK_GITTAGREGEX = "^(?P<pver>\d+(\.\d+)+)$"
 S = "${WORKDIR}/git"
 
-PV = "8.13.3743+git${SRCPV}"
-
 inherit cmake python3native
 
 BBCLASSEXTEND = "native nativesdk"
-- 
2.30.0

[PATCH v4 2/4] glslang: enable shared libs

[Jose Quaresma]

Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
---
 meta/recipes-graphics/glslang/glslang_11.1.0.bb | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/meta/recipes-graphics/glslang/glslang_11.1.0.bb b/meta/recipes-graphics/glslang/glslang_11.1.0.bb
index f1cc966b2a..5e53f02b1c 100644
--- a/meta/recipes-graphics/glslang/glslang_11.1.0.bb
+++ b/meta/recipes-graphics/glslang/glslang_11.1.0.bb
@@ -15,4 +15,14 @@ S = "${WORKDIR}/git"
 
 inherit cmake python3native
 
+EXTRA_OECMAKE = " \
+    -DCMAKE_BUILD_TYPE=Release \
+    -DBUILD_SHARED_LIBS=ON \
+    -DENABLE_CTEST=OFF \
+    -DBUILD_EXTERNAL=OFF \
+"
+
+SOLIBSDEV = "glslang.so"
+FILES_${PN} += "${libdir}/*.so"
+
 BBCLASSEXTEND = "native nativesdk"
-- 
2.30.0

[PATCH v4 3/4] shaderc: avoid reproducible issues

[Jose Quaresma]

Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
---
 meta/recipes-graphics/shaderc/shaderc_2020.4.bb | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/meta/recipes-graphics/shaderc/shaderc_2020.4.bb b/meta/recipes-graphics/shaderc/shaderc_2020.4.bb
index ee9b118371..e886e81d0e 100644
--- a/meta/recipes-graphics/shaderc/shaderc_2020.4.bb
+++ b/meta/recipes-graphics/shaderc/shaderc_2020.4.bb
@@ -19,15 +19,17 @@ DEPENDS = "spirv-tools glslang"
 
 EXTRA_OECMAKE = "-DCMAKE_BUILD_TYPE=Release -DSHADERC_SKIP_TESTS=ON"
 
+BBCLASSEXTEND = "native nativesdk"
+
+# TODO: probably there is better solution for this.
+# I don't know any method for get the version of a receipe in DEPENDS,
+# so do this ugly hack
+inherit pkgconfig
+DEPENDS += "glslang-native"
 do_configure_prepend() {
-    # TODO: probably there is better solution for this.
-    # I dont know any method for get the version of a receipe in DEPENDS
-    # so do this ugly hack
     cat <<- EOF > ${S}/glslc/src/build-version.inc
 "${PV}\\n"
 "$(pkg-config --modversion SPIRV-Tools)\\n"
 "$(glslangValidator --version | head -1 | cut -d' ' -f3)\\n"
 EOF
 }
-
-BBCLASSEXTEND = "native nativesdk"
-- 
2.30.0

[PATCH v4 4/4] shaderc: fix the build with glslang 11.1.0

[Jose Quaresma]

Drop patches:
    * 0001-Fix-the-link-order-of-libglslang-and-libHLSL.patch
      is rejected upstream and is not need when glslang as shared libs.

Update pacthes:
    * 0001-cmake-de-vendor-libs-and-disable-git-versioning.patch
      renamed and refreshed from 0003-cmake-de-vendor-libs-and-disable-git-versioning.patch.

Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
---
 ...link-order-of-libglslang-and-libHLSL.patch | 49 -------------------
 ...dor-libs-and-disable-git-versioning.patch} |  4 +-
 .../shaderc/shaderc_2020.4.bb                 | 10 ++--
 3 files changed, 9 insertions(+), 54 deletions(-)
 delete mode 100644 meta/recipes-graphics/shaderc/files/0001-Fix-the-link-order-of-libglslang-and-libHLSL.patch
 rename meta/recipes-graphics/shaderc/files/{0003-cmake-de-vendor-libs-and-disable-git-versioning.patch => 0001-cmake-de-vendor-libs-and-disable-git-versioning.patch} (94%)

diff --git a/meta/recipes-graphics/shaderc/files/0001-Fix-the-link-order-of-libglslang-and-libHLSL.patch b/meta/recipes-graphics/shaderc/files/0001-Fix-the-link-order-of-libglslang-and-libHLSL.patch
deleted file mode 100644
index 7102e25bcf..0000000000
--- a/meta/recipes-graphics/shaderc/files/0001-Fix-the-link-order-of-libglslang-and-libHLSL.patch
+++ /dev/null
@@ -1,49 +0,0 @@
-From 0b9468d4face34879214f500b15e810cdd1a81a1 Mon Sep 17 00:00:00 2001
-From: Niklas Haas <git@haasn.xyz>
-Date: Tue, 29 May 2018 07:34:00 +0200
-Subject: [PATCH] Fix the link order of libglslang and libHLSL
-
-libglslang depends on libHLSL, so the latter needs to be specified last.
-This fixes an issue when trying to build shaderc against system-wide
-versions of libglslang/libHLSL, rather than the in-tree versions from
-third_party.
-
-Additionally, libshaderc_util also depends on SPIRV-Tools
-
-Upstream-Status: Backport [21c8be385b3fab5edcb934a6d99f69fd389c4e67]
-
-Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
-
----
- glslc/CMakeLists.txt           | 2 +-
- libshaderc_util/CMakeLists.txt | 4 ++--
- 2 files changed, 3 insertions(+), 3 deletions(-)
-
-diff --git a/glslc/CMakeLists.txt b/glslc/CMakeLists.txt
-index 31664d1..35b3f19 100644
---- a/glslc/CMakeLists.txt
-+++ b/glslc/CMakeLists.txt
-@@ -43,7 +43,7 @@ if (SHADERC_ENABLE_WGSL_OUTPUT)
- endif(SHADERC_ENABLE_WGSL_OUTPUT)
- 
- target_link_libraries(glslc PRIVATE
--  glslang OSDependent OGLCompiler HLSL glslang SPIRV    # Glslang libraries
-+  glslang OSDependent OGLCompiler glslang SPIRV HLSL    # Glslang libraries
-   $<$<BOOL:${SHADERC_ENABLE_WGSL_OUTPUT}>:libtint>      # Tint libraries, optional
-   shaderc_util shaderc                                  # internal Shaderc libraries
-   ${CMAKE_THREAD_LIBS_INIT})
-diff --git a/libshaderc_util/CMakeLists.txt b/libshaderc_util/CMakeLists.txt
-index 48f9991..984cc06 100644
---- a/libshaderc_util/CMakeLists.txt
-+++ b/libshaderc_util/CMakeLists.txt
-@@ -46,8 +46,8 @@ add_definitions(-DENABLE_HLSL)
- 
- find_package(Threads)
- target_link_libraries(shaderc_util PRIVATE
--  glslang OSDependent OGLCompiler HLSL glslang SPIRV
--  SPIRV-Tools-opt ${CMAKE_THREAD_LIBS_INIT})
-+  glslang OSDependent OGLCompiler glslang HLSL SPIRV
-+  SPIRV-Tools-opt SPIRV-Tools ${CMAKE_THREAD_LIBS_INIT})
- 
- shaderc_add_tests(
-   TEST_PREFIX shaderc_util
diff --git a/meta/recipes-graphics/shaderc/files/0003-cmake-de-vendor-libs-and-disable-git-versioning.patch b/meta/recipes-graphics/shaderc/files/0001-cmake-de-vendor-libs-and-disable-git-versioning.patch
similarity index 94%
rename from meta/recipes-graphics/shaderc/files/0003-cmake-de-vendor-libs-and-disable-git-versioning.patch
rename to meta/recipes-graphics/shaderc/files/0001-cmake-de-vendor-libs-and-disable-git-versioning.patch
index e4e3f0be1e..40cc84df26 100644
--- a/meta/recipes-graphics/shaderc/files/0003-cmake-de-vendor-libs-and-disable-git-versioning.patch
+++ b/meta/recipes-graphics/shaderc/files/0001-cmake-de-vendor-libs-and-disable-git-versioning.patch
@@ -1,4 +1,4 @@
-From 180250f098e0ab899eff0db3708d9693f3486ff4 Mon Sep 17 00:00:00 2001
+From a07ac322a5a5fd4f0339913eb4456321ad1a69fd Mon Sep 17 00:00:00 2001
 From: Jose Quaresma <quaresma.jose@gmail.com>
 Date: Sat, 17 Oct 2020 12:51:50 +0100
 Subject: [PATCH] cmake: de-vendor libs and disable git versioning
@@ -32,7 +32,7 @@ index 5c74cd8..9451fbc 100644
  add_custom_target(build-version
    ${PYTHON_EXECUTABLE}
 diff --git a/glslc/CMakeLists.txt b/glslc/CMakeLists.txt
-index 35b3f19..52006b8 100644
+index 31664d1..358d91b 100644
 --- a/glslc/CMakeLists.txt
 +++ b/glslc/CMakeLists.txt
 @@ -53,7 +53,6 @@ shaderc_default_compile_options(glslc_exe)
diff --git a/meta/recipes-graphics/shaderc/shaderc_2020.4.bb b/meta/recipes-graphics/shaderc/shaderc_2020.4.bb
index e886e81d0e..18a08ee6c5 100644
--- a/meta/recipes-graphics/shaderc/shaderc_2020.4.bb
+++ b/meta/recipes-graphics/shaderc/shaderc_2020.4.bb
@@ -8,16 +8,20 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=86d3f3a95c324c9479bd8986968f4327"
 
 SRCREV = "0dbd899941a43ffd55df527d65128b3b66e75c9c"
 SRC_URI = "git://github.com/google/shaderc.git;protocol=https;branch=main \
-           file://0001-Fix-the-link-order-of-libglslang-and-libHLSL.patch \
-           file://0003-cmake-de-vendor-libs-and-disable-git-versioning.patch \
+           file://0001-cmake-de-vendor-libs-and-disable-git-versioning.patch \
            "
+UPSTREAM_CHECK_GITTAGREGEX = "^(?P<pver>\d+(\.\d+)+)$"
 S = "${WORKDIR}/git"
 
 inherit cmake python3native
 
 DEPENDS = "spirv-tools glslang"
 
-EXTRA_OECMAKE = "-DCMAKE_BUILD_TYPE=Release -DSHADERC_SKIP_TESTS=ON"
+EXTRA_OECMAKE = " \
+    -DCMAKE_BUILD_TYPE=Release \
+    -DSHADERC_SKIP_TESTS=ON \
+    -Dglslang_SOURCE_DIR=${STAGING_INCDIR}/glslang \
+"
 
 BBCLASSEXTEND = "native nativesdk"
 
-- 
2.30.0

Re: [PATCH v4 4/4] shaderc: fix the build with glslang 11.1.0

[Alexandre Belloni]

Hello Jose,

On 24/01/2021 18:07:58+0000, Jose Quaresma wrote:
> Drop patches:
>     * 0001-Fix-the-link-order-of-libglslang-and-libHLSL.patch
>       is rejected upstream and is not need when glslang as shared libs.
> 
> Update pacthes:
>     * 0001-cmake-de-vendor-libs-and-disable-git-versioning.patch
>       renamed and refreshed from 0003-cmake-de-vendor-libs-and-disable-git-versioning.patch.
> 

It seems there is still a linking issue when building shaderc-native.
The full log is available here:

https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/2978/steps/11/logs/stdio


> Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
> ---
>  ...link-order-of-libglslang-and-libHLSL.patch | 49 -------------------
>  ...dor-libs-and-disable-git-versioning.patch} |  4 +-
>  .../shaderc/shaderc_2020.4.bb                 | 10 ++--
>  3 files changed, 9 insertions(+), 54 deletions(-)
>  delete mode 100644 meta/recipes-graphics/shaderc/files/0001-Fix-the-link-order-of-libglslang-and-libHLSL.patch
>  rename meta/recipes-graphics/shaderc/files/{0003-cmake-de-vendor-libs-and-disable-git-versioning.patch => 0001-cmake-de-vendor-libs-and-disable-git-versioning.patch} (94%)
> 
> diff --git a/meta/recipes-graphics/shaderc/files/0001-Fix-the-link-order-of-libglslang-and-libHLSL.patch b/meta/recipes-graphics/shaderc/files/0001-Fix-the-link-order-of-libglslang-and-libHLSL.patch
> deleted file mode 100644
> index 7102e25bcf..0000000000
> --- a/meta/recipes-graphics/shaderc/files/0001-Fix-the-link-order-of-libglslang-and-libHLSL.patch
> +++ /dev/null
> @@ -1,49 +0,0 @@
> -From 0b9468d4face34879214f500b15e810cdd1a81a1 Mon Sep 17 00:00:00 2001
> -From: Niklas Haas <git@haasn.xyz>
> -Date: Tue, 29 May 2018 07:34:00 +0200
> -Subject: [PATCH] Fix the link order of libglslang and libHLSL
> -
> -libglslang depends on libHLSL, so the latter needs to be specified last.
> -This fixes an issue when trying to build shaderc against system-wide
> -versions of libglslang/libHLSL, rather than the in-tree versions from
> -third_party.
> -
> -Additionally, libshaderc_util also depends on SPIRV-Tools
> -
> -Upstream-Status: Backport [21c8be385b3fab5edcb934a6d99f69fd389c4e67]
> -
> -Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
> -
> ----
> - glslc/CMakeLists.txt           | 2 +-
> - libshaderc_util/CMakeLists.txt | 4 ++--
> - 2 files changed, 3 insertions(+), 3 deletions(-)
> -
> -diff --git a/glslc/CMakeLists.txt b/glslc/CMakeLists.txt
> -index 31664d1..35b3f19 100644
> ---- a/glslc/CMakeLists.txt
> -+++ b/glslc/CMakeLists.txt
> -@@ -43,7 +43,7 @@ if (SHADERC_ENABLE_WGSL_OUTPUT)
> - endif(SHADERC_ENABLE_WGSL_OUTPUT)
> - 
> - target_link_libraries(glslc PRIVATE
> --  glslang OSDependent OGLCompiler HLSL glslang SPIRV    # Glslang libraries
> -+  glslang OSDependent OGLCompiler glslang SPIRV HLSL    # Glslang libraries
> -   $<$<BOOL:${SHADERC_ENABLE_WGSL_OUTPUT}>:libtint>      # Tint libraries, optional
> -   shaderc_util shaderc                                  # internal Shaderc libraries
> -   ${CMAKE_THREAD_LIBS_INIT})
> -diff --git a/libshaderc_util/CMakeLists.txt b/libshaderc_util/CMakeLists.txt
> -index 48f9991..984cc06 100644
> ---- a/libshaderc_util/CMakeLists.txt
> -+++ b/libshaderc_util/CMakeLists.txt
> -@@ -46,8 +46,8 @@ add_definitions(-DENABLE_HLSL)
> - 
> - find_package(Threads)
> - target_link_libraries(shaderc_util PRIVATE
> --  glslang OSDependent OGLCompiler HLSL glslang SPIRV
> --  SPIRV-Tools-opt ${CMAKE_THREAD_LIBS_INIT})
> -+  glslang OSDependent OGLCompiler glslang HLSL SPIRV
> -+  SPIRV-Tools-opt SPIRV-Tools ${CMAKE_THREAD_LIBS_INIT})
> - 
> - shaderc_add_tests(
> -   TEST_PREFIX shaderc_util
> diff --git a/meta/recipes-graphics/shaderc/files/0003-cmake-de-vendor-libs-and-disable-git-versioning.patch b/meta/recipes-graphics/shaderc/files/0001-cmake-de-vendor-libs-and-disable-git-versioning.patch
> similarity index 94%
> rename from meta/recipes-graphics/shaderc/files/0003-cmake-de-vendor-libs-and-disable-git-versioning.patch
> rename to meta/recipes-graphics/shaderc/files/0001-cmake-de-vendor-libs-and-disable-git-versioning.patch
> index e4e3f0be1e..40cc84df26 100644
> --- a/meta/recipes-graphics/shaderc/files/0003-cmake-de-vendor-libs-and-disable-git-versioning.patch
> +++ b/meta/recipes-graphics/shaderc/files/0001-cmake-de-vendor-libs-and-disable-git-versioning.patch
> @@ -1,4 +1,4 @@
> -From 180250f098e0ab899eff0db3708d9693f3486ff4 Mon Sep 17 00:00:00 2001
> +From a07ac322a5a5fd4f0339913eb4456321ad1a69fd Mon Sep 17 00:00:00 2001
>  From: Jose Quaresma <quaresma.jose@gmail.com>
>  Date: Sat, 17 Oct 2020 12:51:50 +0100
>  Subject: [PATCH] cmake: de-vendor libs and disable git versioning
> @@ -32,7 +32,7 @@ index 5c74cd8..9451fbc 100644
>   add_custom_target(build-version
>     ${PYTHON_EXECUTABLE}
>  diff --git a/glslc/CMakeLists.txt b/glslc/CMakeLists.txt
> -index 35b3f19..52006b8 100644
> +index 31664d1..358d91b 100644
>  --- a/glslc/CMakeLists.txt
>  +++ b/glslc/CMakeLists.txt
>  @@ -53,7 +53,6 @@ shaderc_default_compile_options(glslc_exe)
> diff --git a/meta/recipes-graphics/shaderc/shaderc_2020.4.bb b/meta/recipes-graphics/shaderc/shaderc_2020.4.bb
> index e886e81d0e..18a08ee6c5 100644
> --- a/meta/recipes-graphics/shaderc/shaderc_2020.4.bb
> +++ b/meta/recipes-graphics/shaderc/shaderc_2020.4.bb
> @@ -8,16 +8,20 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=86d3f3a95c324c9479bd8986968f4327"
>  
>  SRCREV = "0dbd899941a43ffd55df527d65128b3b66e75c9c"
>  SRC_URI = "git://github.com/google/shaderc.git;protocol=https;branch=main \
> -           file://0001-Fix-the-link-order-of-libglslang-and-libHLSL.patch \
> -           file://0003-cmake-de-vendor-libs-and-disable-git-versioning.patch \
> +           file://0001-cmake-de-vendor-libs-and-disable-git-versioning.patch \
>             "
> +UPSTREAM_CHECK_GITTAGREGEX = "^(?P<pver>\d+(\.\d+)+)$"
>  S = "${WORKDIR}/git"
>  
>  inherit cmake python3native
>  
>  DEPENDS = "spirv-tools glslang"
>  
> -EXTRA_OECMAKE = "-DCMAKE_BUILD_TYPE=Release -DSHADERC_SKIP_TESTS=ON"
> +EXTRA_OECMAKE = " \
> +    -DCMAKE_BUILD_TYPE=Release \
> +    -DSHADERC_SKIP_TESTS=ON \
> +    -Dglslang_SOURCE_DIR=${STAGING_INCDIR}/glslang \
> +"
>  
>  BBCLASSEXTEND = "native nativesdk"
>  
> -- 
> 2.30.0
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [OE-core] [PATCH v4 4/4] shaderc: fix the build with glslang 11.1.0

[Richard Purdie]

On Thu, 2021-01-28 at 23:38 +0100, Alexandre Belloni wrote:
> Hello Jose,
> 
> On 24/01/2021 18:07:58+0000, Jose Quaresma wrote:
> > Drop patches:
> >     * 0001-Fix-the-link-order-of-libglslang-and-libHLSL.patch
> >       is rejected upstream and is not need when glslang as shared libs.
> > 
> > Update pacthes:
> >     * 0001-cmake-de-vendor-libs-and-disable-git-versioning.patch
> >       renamed and refreshed from 0003-cmake-de-vendor-libs-and-disable-git-versioning.patch.
> > 
> 
> It seems there is still a linking issue when building shaderc-native.
> The full log is available here:
> 
> https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/2978/steps/11/logs/stdio

I have a suspicion this happens on Ubuntu 18.04 systems since I've seen
issues like this locally with 18.04's binutils version and OE generated
vulkan-samples binaries, I think Joshua Watt reported the same issue
too with 18.04.

Not sure what we can do about it, can we disable the debug symbol types
causing problems in that -native recipe?

Cheers,

Richard

Re: [OE-core] [PATCH v4 4/4] shaderc: fix the build with glslang 11.1.0

[Richard Purdie]

On Thu, 2021-01-28 at 22:44 +0000, Richard Purdie via
lists.openembedded.org wrote:
> On Thu, 2021-01-28 at 23:38 +0100, Alexandre Belloni wrote:
> > Hello Jose,
> > 
> > On 24/01/2021 18:07:58+0000, Jose Quaresma wrote:
> > > Drop patches:
> > >     * 0001-Fix-the-link-order-of-libglslang-and-libHLSL.patch
> > >       is rejected upstream and is not need when glslang as shared libs.
> > > 
> > > Update pacthes:
> > >     * 0001-cmake-de-vendor-libs-and-disable-git-versioning.patch
> > >       renamed and refreshed from 0003-cmake-de-vendor-libs-and-disable-git-versioning.patch.
> > > 
> > 
> > It seems there is still a linking issue when building shaderc-native.
> > The full log is available here:
> > 
> > https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/2978/steps/11/logs/stdio
> 
> I have a suspicion this happens on Ubuntu 18.04 systems since I've seen
> issues like this locally with 18.04's binutils version and OE generated
> vulkan-samples binaries, I think Joshua Watt reported the same issue
> too with 18.04.
> 
> Not sure what we can do about it, can we disable the debug symbol types
> causing problems in that -native recipe?

I tried to reproduce this and couldn't so far. I suspect what happens
is that one of the dependencies builds on a newer system, shaderc-
native then builds on 1804 and it can't read the binary generated by
the newer binutils.

This is obviously a pain to setup and reproduce. The "easiest" way may
be to build buildtools-tarball to build everything up to shaderc-
native, then remove buildtools-tarball and build shaderc-native. I'll
see if I can find some time to try that.

I've been holding the patches in master-next but I think we probably
should merge them as this could well be a generic ubuntu1804 issue that
already probably exists.

Cheers,

Richard

Re: [OE-core] [PATCH v4 4/4] shaderc: fix the build with glslang 11.1.0

[Richard Purdie]

On Fri, 2021-01-29 at 11:42 +0000, Richard Purdie via
lists.openembedded.org wrote:
> On Thu, 2021-01-28 at 22:44 +0000, Richard Purdie via
> lists.openembedded.org wrote:
> > On Thu, 2021-01-28 at 23:38 +0100, Alexandre Belloni wrote:
> > > Hello Jose,
> > > 
> > > On 24/01/2021 18:07:58+0000, Jose Quaresma wrote:
> > > > Drop patches:
> > > >     * 0001-Fix-the-link-order-of-libglslang-and-libHLSL.patch
> > > >       is rejected upstream and is not need when glslang as shared libs.
> > > > 
> > > > Update pacthes:
> > > >     * 0001-cmake-de-vendor-libs-and-disable-git-versioning.patch
> > > >       renamed and refreshed from 0003-cmake-de-vendor-libs-and-disable-git-versioning.patch.
> > > > 
> > > 
> > > It seems there is still a linking issue when building shaderc-native.
> > > The full log is available here:
> > > 
> > > https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/2978/steps/11/logs/stdio
> > 
> > I have a suspicion this happens on Ubuntu 18.04 systems since I've seen
> > issues like this locally with 18.04's binutils version and OE generated
> > vulkan-samples binaries, I think Joshua Watt reported the same issue
> > too with 18.04.
> > 
> > Not sure what we can do about it, can we disable the debug symbol types
> > causing problems in that -native recipe?
> 
> I tried to reproduce this and couldn't so far. I suspect what happens
> is that one of the dependencies builds on a newer system, shaderc-
> native then builds on 1804 and it can't read the binary generated by
> the newer binutils.
> 
> This is obviously a pain to setup and reproduce. The "easiest" way may
> be to build buildtools-tarball to build everything up to shaderc-
> native, then remove buildtools-tarball and build shaderc-native. I'll
> see if I can find some time to try that.
> 
> I've been holding the patches in master-next but I think we probably
> should merge them as this could well be a generic ubuntu1804 issue that
> already probably exists.

I tried this and I couldn't reproduce with master's buildtools tarball
so I guess we wait and see if it comes up again.

Cheers,

Richard

Re: [OE-core] [PATCH v4 4/4] shaderc: fix the build with glslang 11.1.0

[Jose Quaresma]

[-- Attachment #1: Type: text/plain, Size: 3351 bytes --]

Hi Richard,

Thanks for the help in catch and try to solve this issue.

The recipe shaderc-native is the only recipe that is build in OE-Core
as it is needed by gstreamer plugins bad vulkan element.
The target shaderc is not used by anyone in OE-core at the moment
and because of that it don't have any build issues.

In my setup I don't see any erros and can build without any issues
the target shaderc on qemu as well as the shaderc-native.

I think that this problems can came from the spirv-tools that only generate
static libraries
and some this libraries have reproducible issues related with the glibc
librt.so.
The static libraries that come from spirv-tools are linked with the
librt.so from the host.

https://lists.openembedded.org/g/openembedded-core/message/147221

I will look at this when I have some time.
My next few weeks I’ll be very busy so I don’t promise anything.

Many thanks,

Jose


Richard Purdie <richard.purdie@linuxfoundation.org> escreveu no dia sexta,
29/01/2021 à(s) 14:24:

> On Fri, 2021-01-29 at 11:42 +0000, Richard Purdie via
> lists.openembedded.org wrote:
> > On Thu, 2021-01-28 at 22:44 +0000, Richard Purdie via
> > lists.openembedded.org wrote:
> > > On Thu, 2021-01-28 at 23:38 +0100, Alexandre Belloni wrote:
> > > > Hello Jose,
> > > >
> > > > On 24/01/2021 18:07:58+0000, Jose Quaresma wrote:
> > > > > Drop patches:
> > > > >     * 0001-Fix-the-link-order-of-libglslang-and-libHLSL.patch
> > > > >       is rejected upstream and is not need when glslang as shared
> libs.
> > > > >
> > > > > Update pacthes:
> > > > >     * 0001-cmake-de-vendor-libs-and-disable-git-versioning.patch
> > > > >       renamed and refreshed from
> 0003-cmake-de-vendor-libs-and-disable-git-versioning.patch.
> > > > >
> > > >
> > > > It seems there is still a linking issue when building shaderc-native.
> > > > The full log is available here:
> > > >
> > > >
> https://autobuilder.yoctoproject.org/typhoon/#/builders/40/builds/2978/steps/11/logs/stdio
> > >
> > > I have a suspicion this happens on Ubuntu 18.04 systems since I've seen
> > > issues like this locally with 18.04's binutils version and OE generated
> > > vulkan-samples binaries, I think Joshua Watt reported the same issue
> > > too with 18.04.
> > >
> > > Not sure what we can do about it, can we disable the debug symbol types
> > > causing problems in that -native recipe?
> >
> > I tried to reproduce this and couldn't so far. I suspect what happens
> > is that one of the dependencies builds on a newer system, shaderc-
> > native then builds on 1804 and it can't read the binary generated by
> > the newer binutils.
> >
> > This is obviously a pain to setup and reproduce. The "easiest" way may
> > be to build buildtools-tarball to build everything up to shaderc-
> > native, then remove buildtools-tarball and build shaderc-native. I'll
> > see if I can find some time to try that.
> >
> > I've been holding the patches in master-next but I think we probably
> > should merge them as this could well be a generic ubuntu1804 issue that
> > already probably exists.
>
> I tried this and I couldn't reproduce with master's buildtools tarball
> so I guess we wait and see if it comes up again.
>
> Cheers,
>
> Richard
>
>

-- 
best regards,
José Quaresma

[-- Attachment #2: Type: text/html, Size: 4823 bytes --]