[PATCH] Fixes [YOCTO 15731]

[PATCH] Fixes [YOCTO 15731]

[Sven Kalmbach]

From aa2176cbd1438b72f22129421edd8f7979330a56 Mon Sep 17 00:00:00 2001
From: Sven Kalmbach <Sven.Kalmbach@loewensteinmedical.com>
Date: Wed, 5 Feb 2025 16:11:33 +0100
Subject: [PATCH] Fixes [YOCTO 15731]

Remove incorrectly escaped exit value, which causes error
handling logic not to run.

Signed-off-by: Sven Kalmbach <Sven.Kalmbach@loewensteinmedical.com>
---
 meta/classes-recipe/cml1.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes-recipe/cml1.bbclass b/meta/classes-recipe/cml1.bbclass
index 0bf171a668..d18b008aec 100644
--- a/meta/classes-recipe/cml1.bbclass
+++ b/meta/classes-recipe/cml1.bbclass
@@ -58,7 +58,7 @@ python do_menuconfig() {
     # ensure that environment variables are overwritten with this tasks 'd' values
     d.appendVar("OE_TERMINAL_EXPORTS", " PKG_CONFIG_DIR PKG_CONFIG_PATH PKG_CONFIG_LIBDIR PKG_CONFIG_SYSROOT_DIR")

-    oe_terminal("sh -c 'make %s; if [ \\$? -ne 0 ]; then echo \"Command failed.\"; printf \"Press any key to continue... \"; read r; fi'" % d.getVar('KCONFIG_CONFIG_COMMAND'),
+    oe_terminal("sh -c 'make %s; if [ $? -ne 0 ]; then echo \"Command failed.\"; printf \"Press any key to continue... \"; read r; fi'" % d.getVar('KCONFIG_CONFIG_COMMAND'),
                 d.getVar('PN') + ' Configuration', d)

     try:

[PATCH] Fixes [YOCTO 15731]

[Sven Kalmbach]

Remove incorrectly escaped exit value, which causes error
handling logic not to run.

Signed-off-by: Sven Kalmbach <Sven.Kalmbach@loewensteinmedical.com>
---
 meta/classes-recipe/cml1.bbclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/classes-recipe/cml1.bbclass b/meta/classes-recipe/cml1.bbclass
index 0bf171a668..d18b008aec 100644
--- a/meta/classes-recipe/cml1.bbclass
+++ b/meta/classes-recipe/cml1.bbclass
@@ -58,7 +58,7 @@ python do_menuconfig() {
     # ensure that environment variables are overwritten with this tasks 'd' values
     d.appendVar("OE_TERMINAL_EXPORTS", " PKG_CONFIG_DIR PKG_CONFIG_PATH PKG_CONFIG_LIBDIR PKG_CONFIG_SYSROOT_DIR")

-    oe_terminal("sh -c 'make %s; if [ \\$? -ne 0 ]; then echo \"Command failed.\"; printf \"Press any key to continue... \"; read r; fi'" % d.getVar('KCONFIG_CONFIG_COMMAND'),
+    oe_terminal("sh -c 'make %s; if [ $? -ne 0 ]; then echo \"Command failed.\"; printf \"Press any key to continue... \"; read r; fi'" % d.getVar('KCONFIG_CONFIG_COMMAND'),
                 d.getVar('PN') + ' Configuration', d)

     try:

Re: [PATCH] Fixes [YOCTO 15731]

[Sven Kalmbach]

[-- Attachment #1: Type: text/plain, Size: 60 bytes --]

Does that work? I found a workaround to use git send-email

[-- Attachment #2: Type: text/html, Size: 71 bytes --]

Patchtest results for [PATCH] Fixes [YOCTO 15731]

[patchtest]

[-- Attachment #1: Type: text/plain, Size: 3175 bytes --]

Thank you for your submission. Patchtest identified one
or more issues with the patch. Please see the log below for
more information:

---
Testing patch /home/patchtest/share/mboxes/Fixes-YOCTO-15731.patch

FAIL: test shortlog format: Commit shortlog (first line of commit message) should follow the format "<target>: <summary>" (test_mbox.TestMbox.test_shortlog_format)

PASS: test Signed-off-by presence (test_mbox.TestMbox.test_signed_off_by_presence)
PASS: test author valid (test_mbox.TestMbox.test_author_valid)
PASS: test commit message presence (test_mbox.TestMbox.test_commit_message_presence)
PASS: test commit message user tags (test_mbox.TestMbox.test_commit_message_user_tags)
PASS: test max line length (test_metadata.TestMetadata.test_max_line_length)
PASS: test mbox format (test_mbox.TestMbox.test_mbox_format)
PASS: test non-AUH upgrade (test_mbox.TestMbox.test_non_auh_upgrade)
PASS: test shortlog length (test_mbox.TestMbox.test_shortlog_length)
PASS: test target mailing list (test_mbox.TestMbox.test_target_mailing_list)

SKIP: pretest pylint: No python related patches, skipping test (test_python_pylint.PyLint.pretest_pylint)
SKIP: pretest src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.pretest_src_uri_left_files)
SKIP: test CVE check ignore: No modified recipes or older target branch, skipping test (test_metadata.TestMetadata.test_cve_check_ignore)
SKIP: test CVE tag format: No new CVE patches introduced (test_patch.TestPatch.test_cve_tag_format)
SKIP: test Signed-off-by presence: No new CVE patches introduced (test_patch.TestPatch.test_signed_off_by_presence)
SKIP: test Upstream-Status presence: No new CVE patches introduced (test_patch.TestPatch.test_upstream_status_presence_format)
SKIP: test bugzilla entry format: No bug ID found (test_mbox.TestMbox.test_bugzilla_entry_format)
SKIP: test lic files chksum modified not mentioned: No modified recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_modified_not_mentioned)
SKIP: test lic files chksum presence: No added recipes, skipping test (test_metadata.TestMetadata.test_lic_files_chksum_presence)
SKIP: test license presence: No added recipes, skipping test (test_metadata.TestMetadata.test_license_presence)
SKIP: test pylint: No python related patches, skipping test (test_python_pylint.PyLint.test_pylint)
SKIP: test series merge on head: Merge test is disabled for now (test_mbox.TestMbox.test_series_merge_on_head)
SKIP: test src uri left files: No modified recipes, skipping pretest (test_metadata.TestMetadata.test_src_uri_left_files)
SKIP: test summary presence: No added recipes, skipping test (test_metadata.TestMetadata.test_summary_presence)

---

Please address the issues identified and
submit a new revision of the patch, or alternatively, reply to this
email with an explanation of why the patch should be accepted. If you
believe these results are due to an error in patchtest, please submit a
bug at https://bugzilla.yoctoproject.org/ (use the 'Patchtest' category
under 'Yocto Project Subprojects'). For more information on specific
failures, see: https://wiki.yoctoproject.org/wiki/Patchtest. Thank
you!

Re: [OE-core] [PATCH] Fixes [YOCTO 15731]

[Alexander Kanavin]

The subject needs to be changed:

cml1.bbclass: do not escape the exit value

Then the body should also include a reference to the ticket, e.g

[YOCTO #15731]

Alex

On Wed, 12 Feb 2025 at 16:55, Sven Kalmbach via lists.openembedded.org
<sven.kalmbach=loewensteinmedical.com@lists.openembedded.org> wrote:
>
> Does that work? I found a workaround to use git send-email
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#211253): https://lists.openembedded.org/g/openembedded-core/message/211253
> Mute This Topic: https://lists.openembedded.org/mt/111143606/1686489
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [alex.kanavin@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Re: [OE-core] [PATCH] Fixes [YOCTO 15731]

[Yoann Congal]

[-- Attachment #1: Type: text/plain, Size: 924 bytes --]

Le mer. 12 févr. 2025 à 16:55, Sven Kalmbach via lists.openembedded.org
<sven.kalmbach=loewensteinmedical.com@lists.openembedded.org> a écrit :

> Does that work? I found a workaround to use git send-email
>

Yes, your patch does apply cleanly now.

Thanks for seeing it through from bug report to patch sending :-)

As Alex wrote, you still need to change the commit title but you are on the
right tracks.


> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#211253):
> https://lists.openembedded.org/g/openembedded-core/message/211253
> Mute This Topic: https://lists.openembedded.org/mt/111143606/4316185
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [
> yoann.congal@smile.fr]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>

-- 
Yoann Congal
Smile ECS - Tech expert

[-- Attachment #2: Type: text/html, Size: 2211 bytes --]

Re: [PATCH] Fixes [YOCTO 15731]

[Sven Kalmbach]

[-- Attachment #1: Type: text/plain, Size: 53 bytes --]

I've sent a new patch with the correct subject line

[-- Attachment #2: Type: text/html, Size: 64 bytes --]