Openembedded Core Discussions
 help / color / mirror / Atom feed
* [OE-core][kirkstone][PATCH v2] e2fsprogs: removed 'sed -u' option
@ 2024-10-21 11:55 Pawan Badganchi
  2024-11-18  6:00 ` [kirkstone][PATCH " Pawan Badganchi
  0 siblings, 1 reply; 2+ messages in thread
From: Pawan Badganchi @ 2024-10-21 11:55 UTC (permalink / raw)
  To: openembedded-core, badganchipv; +Cc: Aditya Tayade

From: Aditya Tayade <Aditya.Tayade@kpit.com>

In embedded box, sed might be provided another providers like Busybox,
hence use generic options whenever possible.
/bin/sed -> /etc/alternatives/sed
/etc/alternatives/sed -> /bin/busybox.nosuid

Here used 'sed -u' option is not necessary, hence removed it.

Fixes below error:
sed: invalid option -- 'u'

Also added 'set -eux' option which halts execution of the script
on any failures.

Signed-off-by: Aditya Tayade <Aditya.Tayade@kpit.com>
Signed-off-by: Pawan Badganchi <Pawan.Badganchi@kpit.com>
---
 meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest b/meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest
index 279923db8e..1857a17189 100644
--- a/meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest
+++ b/meta/recipes-devtools/e2fsprogs/e2fsprogs/run-ptest
@@ -1,7 +1,8 @@
 #!/bin/sh
 
+set -eux
 cd ./test
-SKIP_SLOW_TESTS=yes ./test_script | sed -u -e '/:[[:space:]]ok/s/^/PASS: /' -e '/:[[:space:]]failed/s/^/FAIL: /' -e '/:[[:space:]]skipped/s/^/SKIP: /'
+SKIP_SLOW_TESTS=yes ./test_script | sed -e '/:[[:space:]]ok/s/^/PASS: /' -e '/:[[:space:]]failed/s/^/FAIL: /' -e '/:[[:space:]]skipped/s/^/SKIP: /'
 rm -rf /var/volatile/tmp/*e2fsprogs*
 rm -f tmp-*
 rm -f *.tmp
-- 
2.25.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [kirkstone][PATCH v2] e2fsprogs: removed 'sed -u' option
  2024-10-21 11:55 [OE-core][kirkstone][PATCH v2] e2fsprogs: removed 'sed -u' option Pawan Badganchi
@ 2024-11-18  6:00 ` Pawan Badganchi
  0 siblings, 0 replies; 2+ messages in thread
From: Pawan Badganchi @ 2024-11-18  6:00 UTC (permalink / raw)
  To: openembedded-core

[-- Attachment #1: Type: text/plain, Size: 41 bytes --]

Hi,

Could you please take this patch

[-- Attachment #2: Type: text/html, Size: 80 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-11-18  6:00 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-21 11:55 [OE-core][kirkstone][PATCH v2] e2fsprogs: removed 'sed -u' option Pawan Badganchi
2024-11-18  6:00 ` [kirkstone][PATCH " Pawan Badganchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox