[OE-Core][master][langdale][kirkstone][dunfell][PATCH] glibc-version.inc: Use https protocol for fetch task

[OE-Core][master][langdale][kirkstone][dunfell][PATCH] glibc-version.inc: Use https protocol for fetch task

[Ranjitsinh Rathod]

From: Ranjitsinh Rathod <ranjitsinh.rathod@kpit.com>

Use https protocol instead of git as sometimes in proxy network git
protocol uses whole timeout and finally gives fatal error and then uses
mirror.

Error:
LANG=C git -c core.fsyncobjectfiles=0 fetch -f --progress "git://sourceware.org/git/glibc.git" refs/*:refs/*' in /home/builder/bs-workspace/yocto-downloads/git2/sourceware.org.git.glibc.git
fatal: unable to look up sourceware.org (port 9418) (Name or service not known)

So to avoid this delay during fetch task, we switch to use https
protocol instead of git

Signed-off-by: Ranjitsinh Rathod <ranjitsinh.rathod@kpit.com>
Signed-off-by: Ranjitsinh Rathod <ranjitsinhrathod1991@gmail.com>
---
 meta/recipes-core/glibc/glibc-version.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/recipes-core/glibc/glibc-version.inc b/meta/recipes-core/glibc/glibc-version.inc
index bd125ec401..40b91bfda0 100644
--- a/meta/recipes-core/glibc/glibc-version.inc
+++ b/meta/recipes-core/glibc/glibc-version.inc
@@ -3,6 +3,6 @@ PV = "2.36"
 SRCREV_glibc ?= "c399271c10bd00714504e8d4dfbec8aebf996dd4"
 SRCREV_localedef ?= "794da69788cbf9bf57b59a852f9f11307663fa87"
 
-GLIBC_GIT_URI ?= "git://sourceware.org/git/glibc.git"
+GLIBC_GIT_URI ?= "git://sourceware.org/git/glibc.git;protocol=https"
 
 UPSTREAM_CHECK_GITTAGREGEX = "(?P<pver>\d+\.\d+(\.(?!90)\d+)*)"
-- 
2.25.1

Re: [OE-Core][master][langdale][kirkstone][dunfell][PATCH] glibc-version.inc: Use https protocol for fetch task

[Richard Purdie]

On Tue, 2023-01-03 at 18:04 +0530, Ranjitsinh Rathod wrote:
> From: Ranjitsinh Rathod <ranjitsinh.rathod@kpit.com>
> 
> Use https protocol instead of git as sometimes in proxy network git
> protocol uses whole timeout and finally gives fatal error and then uses
> mirror.
> 
> Error:
> LANG=C git -c core.fsyncobjectfiles=0 fetch -f --progress "git://sourceware.org/git/glibc.git" refs/*:refs/*' in /home/builder/bs-workspace/yocto-downloads/git2/sourceware.org.git.glibc.git
> fatal: unable to look up sourceware.org (port 9418) (Name or service not known)
> 
> So to avoid this delay during fetch task, we switch to use https
> protocol instead of git
> 
> Signed-off-by: Ranjitsinh Rathod <ranjitsinh.rathod@kpit.com>
> Signed-off-by: Ranjitsinh Rathod <ranjitsinhrathod1991@gmail.com>
> ---
>  meta/recipes-core/glibc/glibc-version.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

That looks like a DNS error so whether it uses git or https, it won't
matter if the name resolution is failing.

I think you'll need to fix your network, or if the issue is with the
sourceware.org name servers, ask them to get that fixed. Changing
protocol won't help.

Cheers,

Richard

Re: [master][langdale][kirkstone][dunfell][PATCH] glibc-version.inc: Use https protocol for fetch task

[Ranjitsinh Rathod]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

Hi Rechard,

Thanks for the input.
But is it okay to change protocol from git to https. I can change the commit message if it is possible

I hope it will not harm anything if we change the protocol, right?

Thanks,
Ranjitsinh

[-- Attachment #2: Type: text/html, Size: 267 bytes --]

Re: [OE-core] [master][langdale][kirkstone][dunfell][PATCH] glibc-version.inc: Use https protocol for fetch task

[Alexander Kanavin]

On Tue, 3 Jan 2023 at 14:49, Ranjitsinh Rathod
<ranjitsinhrathod1991@gmail.com> wrote:
> Thanks for the input.
> But is it okay to change protocol from git to https. I can change the commit message if it is possible
>
> I hope it will not harm anything if we change the protocol, right?

There needs to be a reason for the change that is applicable outside
of your organization's network. "Our IT department isn't able to fix
the network" is not a reason.

Alex

Re: [master][langdale][kirkstone][dunfell][PATCH] glibc-version.inc: Use https protocol for fetch task

[Ranjitsinh Rathod]

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

On Tue, Jan 3, 2023 at 05:53 AM, Alexander Kanavin wrote:

> 
> There needs to be a reason for the change that is applicable outside
> of your organization's network. "Our IT department isn't able to fix
> the network" is not a reason.

Thanks Alex, Got it.
And, Of course our IT team is capable of fixing this issue.

Thanks,
Ranjitsinh

[-- Attachment #2: Type: text/html, Size: 391 bytes --]

Re: [OE-core] [master][langdale][kirkstone][dunfell][PATCH] glibc-version.inc: Use https protocol for fetch task

[Richard Purdie]

On Tue, 2023-01-03 at 05:49 -0800, Ranjitsinh Rathod wrote:
> Hi Rechard,

Whilst that typo doesn't bother me, it does make me wonder about the
effort you're putting into these patches and I will judge them
accordingly.
> 
> Thanks for the input.
> But is it okay to change protocol from git to https. I can change the
> commit message if it is possible

If I took this patch, I'd then get a load more changing all the other
git protocol usage to https and you'd point out I'd take one so lots of
others should be fine too. We've not made any decision to do that and I
doubt we could guarantee that they'd all work with https anyway so I'd
suggest you sort your network out so git works or have a good source
mirror.

> I hope it will not harm anything if we change the protocol, right?

According to your commit message, it wouldn't fix anything either. I
don't actually know what issue you're trying to solve as you've not
said. I can guess but that isn't really the point.

Cheers,

Richard

Re: [OE-core] [master][langdale][kirkstone][dunfell][PATCH] glibc-version.inc: Use https protocol for fetch task

[Khem Raj]

On Tue, Jan 3, 2023 at 6:02 AM Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
>
> On Tue, 2023-01-03 at 05:49 -0800, Ranjitsinh Rathod wrote:
> > Hi Rechard,
>
> Whilst that typo doesn't bother me, it does make me wonder about the
> effort you're putting into these patches and I will judge them
> accordingly.
> >
> > Thanks for the input.
> > But is it okay to change protocol from git to https. I can change the
> > commit message if it is possible
>
> If I took this patch, I'd then get a load more changing all the other
> git protocol usage to https and you'd point out I'd take one so lots of
> others should be fine too. We've not made any decision to do that and I
> doubt we could guarantee that they'd all work with https anyway so I'd
> suggest you sort your network out so git works or have a good source
> mirror.

Some orgs do not allow anonymous git protocol through their firewalls.

>
> > I hope it will not harm anything if we change the protocol, right?
>
> According to your commit message, it wouldn't fix anything either. I
> don't actually know what issue you're trying to solve as you've not
> said. I can guess but that isn't really the point.
>
> Cheers,
>
> Richard
>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#175354): https://lists.openembedded.org/g/openembedded-core/message/175354
> Mute This Topic: https://lists.openembedded.org/mt/96026992/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>