public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: thomas.perrot@bootlin.com, openembedded-core@lists.openembedded.org
Subject: Re: [OE-core][PATCH] qemu.inc: add virtio input in required dependencies
Date: Wed, 26 Oct 2022 12:14:10 +0100	[thread overview]
Message-ID: <2e7e3bf799fede599c134d21bed5fca3921cbc6b.camel@linuxfoundation.org> (raw)
In-Reply-To: <20221018093227.3753321-1-thomas.perrot@bootlin.com>

On Tue, 2022-10-18 at 11:32 +0200, Thomas Perrot via
lists.openembedded.org wrote:
> From: Thomas Perrot <thomas.perrot@bootlin.com>
> 
> Otherwise, it isn't possible to interact with the UI of images
> that provide graphic support.
> 
> This issue only occurs when NO_RECOMMENDATIONS = "1" for Qemu
> targets which are kernel-modules in MACHINE_EXTRA_RRECOMMENDS.
> 
> Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com>
> ---
>  meta/conf/machine/include/qemu.inc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta/conf/machine/include/qemu.inc b/meta/conf/machine/include/qemu.inc
> index 0d71bcbbad0d..dabe7ed8f386 100644
> --- a/meta/conf/machine/include/qemu.inc
> +++ b/meta/conf/machine/include/qemu.inc
> @@ -10,6 +10,8 @@ XSERVER ?= "xserver-xorg \
>              xf86-video-fbdev \
>              "
>  
> +MACHINE_EXTRA_RDEPENDS += "kernel-module-virtio-input"
> +
>  MACHINE_FEATURES = "alsa bluetooth usbgadget screen vfat"
>  
>  MACHINEOVERRIDES =. "qemuall:"

This will fail if the kernel has the module built in - kernel modules
are always recommends for that reason. We'll have to find a different
solution I'm afraid.

Cheers,

Richard



  reply	other threads:[~2022-10-26 11:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-18  9:32 [OE-core][PATCH] qemu.inc: add virtio input in required dependencies thomas.perrot
2022-10-26 11:14 ` Richard Purdie [this message]
2022-10-26 12:01   ` Thomas Perrot
2022-10-26 12:05     ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2e7e3bf799fede599c134d21bed5fca3921cbc6b.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=thomas.perrot@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox