[OE-core][PATCH] qemu.inc: add virtio input in required dependencies

[OE-core][PATCH] qemu.inc: add virtio input in required dependencies

[thomas.perrot]

From: Thomas Perrot <thomas.perrot@bootlin.com>

Otherwise, it isn't possible to interact with the UI of images
that provide graphic support.

This issue only occurs when NO_RECOMMENDATIONS = "1" for Qemu
targets which are kernel-modules in MACHINE_EXTRA_RRECOMMENDS.

Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com>
---
 meta/conf/machine/include/qemu.inc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/conf/machine/include/qemu.inc b/meta/conf/machine/include/qemu.inc
index 0d71bcbbad0d..dabe7ed8f386 100644
--- a/meta/conf/machine/include/qemu.inc
+++ b/meta/conf/machine/include/qemu.inc
@@ -10,6 +10,8 @@ XSERVER ?= "xserver-xorg \
             xf86-video-fbdev \
             "
 
+MACHINE_EXTRA_RDEPENDS += "kernel-module-virtio-input"
+
 MACHINE_FEATURES = "alsa bluetooth usbgadget screen vfat"
 
 MACHINEOVERRIDES =. "qemuall:"
-- 
2.37.3

Re: [OE-core][PATCH] qemu.inc: add virtio input in required dependencies

[Richard Purdie]

On Tue, 2022-10-18 at 11:32 +0200, Thomas Perrot via
lists.openembedded.org wrote:
> From: Thomas Perrot <thomas.perrot@bootlin.com>
> 
> Otherwise, it isn't possible to interact with the UI of images
> that provide graphic support.
> 
> This issue only occurs when NO_RECOMMENDATIONS = "1" for Qemu
> targets which are kernel-modules in MACHINE_EXTRA_RRECOMMENDS.
> 
> Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com>
> ---
>  meta/conf/machine/include/qemu.inc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta/conf/machine/include/qemu.inc b/meta/conf/machine/include/qemu.inc
> index 0d71bcbbad0d..dabe7ed8f386 100644
> --- a/meta/conf/machine/include/qemu.inc
> +++ b/meta/conf/machine/include/qemu.inc
> @@ -10,6 +10,8 @@ XSERVER ?= "xserver-xorg \
>              xf86-video-fbdev \
>              "
>  
> +MACHINE_EXTRA_RDEPENDS += "kernel-module-virtio-input"
> +
>  MACHINE_FEATURES = "alsa bluetooth usbgadget screen vfat"
>  
>  MACHINEOVERRIDES =. "qemuall:"

This will fail if the kernel has the module built in - kernel modules
are always recommends for that reason. We'll have to find a different
solution I'm afraid.

Cheers,

Richard

Re: [OE-core][PATCH] qemu.inc: add virtio input in required dependencies

[Thomas Perrot]

[-- Attachment #1: Type: text/plain, Size: 2134 bytes --]

Hello Richard,

On Wed, 2022-10-26 at 12:14 +0100, Richard Purdie wrote:
> On Tue, 2022-10-18 at 11:32 +0200, Thomas Perrot via
> lists.openembedded.org wrote:
> > From: Thomas Perrot <thomas.perrot@bootlin.com>
> > 
> > Otherwise, it isn't possible to interact with the UI of images
> > that provide graphic support.
> > 
> > This issue only occurs when NO_RECOMMENDATIONS = "1" for Qemu
> > targets which are kernel-modules in MACHINE_EXTRA_RRECOMMENDS.
> > 
> > Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com>
> > ---
> >  meta/conf/machine/include/qemu.inc | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/meta/conf/machine/include/qemu.inc
> > b/meta/conf/machine/include/qemu.inc
> > index 0d71bcbbad0d..dabe7ed8f386 100644
> > --- a/meta/conf/machine/include/qemu.inc
> > +++ b/meta/conf/machine/include/qemu.inc
> > @@ -10,6 +10,8 @@ XSERVER ?= "xserver-xorg \
> >              xf86-video-fbdev \
> >              "
> >  
> > +MACHINE_EXTRA_RDEPENDS += "kernel-module-virtio-input"
> > +
> >  MACHINE_FEATURES = "alsa bluetooth usbgadget screen vfat"
> >  
> >  MACHINEOVERRIDES =. "qemuall:"
> 
> This will fail if the kernel has the module built in - kernel modules
> are always recommends for that reason. We'll have to find a different
> solution I'm afraid.

When this kernel module is built in, so the Qemu boot process stalled:
"please wait: booting..."
For this reason, is the proposed solution acceptable?

Kind regards,
Thomas

> 
> Cheers,
> 
> Richard
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#172150):
> https://lists.openembedded.org/g/openembedded-core/message/172150
> Mute This Topic: https://lists.openembedded.org/mt/94404446/5443093
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe:
> https://lists.openembedded.org/g/openembedded-core/unsub [
> thomas.perrot@bootlin.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 

-- 
Thomas Perrot, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com


[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 659 bytes --]

Re: [OE-core][PATCH] qemu.inc: add virtio input in required dependencies

[Richard Purdie]

On Wed, 2022-10-26 at 14:01 +0200, Thomas Perrot wrote:
> Hello Richard,
> 
> On Wed, 2022-10-26 at 12:14 +0100, Richard Purdie wrote:
> > On Tue, 2022-10-18 at 11:32 +0200, Thomas Perrot via
> > lists.openembedded.org wrote:
> > > From: Thomas Perrot <thomas.perrot@bootlin.com>
> > > 
> > > Otherwise, it isn't possible to interact with the UI of images
> > > that provide graphic support.
> > > 
> > > This issue only occurs when NO_RECOMMENDATIONS = "1" for Qemu
> > > targets which are kernel-modules in MACHINE_EXTRA_RRECOMMENDS.
> > > 
> > > Signed-off-by: Thomas Perrot <thomas.perrot@bootlin.com>
> > > ---
> > >  meta/conf/machine/include/qemu.inc | 2 ++
> > >  1 file changed, 2 insertions(+)
> > > 
> > > diff --git a/meta/conf/machine/include/qemu.inc
> > > b/meta/conf/machine/include/qemu.inc
> > > index 0d71bcbbad0d..dabe7ed8f386 100644
> > > --- a/meta/conf/machine/include/qemu.inc
> > > +++ b/meta/conf/machine/include/qemu.inc
> > > @@ -10,6 +10,8 @@ XSERVER ?= "xserver-xorg \
> > >              xf86-video-fbdev \
> > >              "
> > >  
> > > +MACHINE_EXTRA_RDEPENDS += "kernel-module-virtio-input"
> > > +
> > >  MACHINE_FEATURES = "alsa bluetooth usbgadget screen vfat"
> > >  
> > >  MACHINEOVERRIDES =. "qemuall:"
> > 
> > This will fail if the kernel has the module built in - kernel modules
> > are always recommends for that reason. We'll have to find a different
> > solution I'm afraid.
> 
> When this kernel module is built in, so the Qemu boot process stalled:
> "please wait: booting..."
> For this reason, is the proposed solution acceptable?

Not really. 

Is there some special reason building that module in could cause a
hang? That sounds rather like a kernel bug :(.

It would be near impossible to explain to users why some kernel modules
are reccommends and some are not which is why I don't really want to
start listing modules as RDEPENDS.

Cheers,

Richard