apr: Add EXTRA_OECONF += "apr_cv_mutex_recursive=yes"

apr: Add EXTRA_OECONF += "apr_cv_mutex_recursive=yes"

[Víctor MV]

[-- Attachment #1.1: Type: text/plain, Size: 474 bytes --]

Working with the meta-ros project we detected that the ROS nodes didn't
launch properly the reason was that by default apr_cv_mutex_recursive in
apr is set to no and this leads to the APRENOTIMPL return value of
apr_thread_mutex_create in thread_mutex.c when APR_THREAD_MUTEX_NESTED is
requested via flags. Added EXTRA_OECONF += "apr_cv_mutex_recursive=yes" to
sources/openembedded-core/meta/recipes-support/apr/apr_1.4.6.bb to fix this
issue.

Regards,

Víctor.

[-- Attachment #1.2: Type: text/html, Size: 639 bytes --]

[-- Attachment #2: 0001-Patch-to-apr_1.4.6.bb-to-make-rosnodes-work.patch --]
[-- Type: application/octet-stream, Size: 1266 bytes --]

From 1ccfc10c0afec7c6fd73804e1ac48cc46fd31eb0 Mon Sep 17 00:00:00 2001
From: victor <v.mayoralv@gmail.com>
Date: Mon, 1 Jul 2013 14:46:42 +0200
Subject: [PATCH] Patch to apr_1.4.6.bb to make rosnodes work

By default apr_cv_mutex_recursive in apr is set to no and this leads to the APRENOTIMPL return value of apr_thread_mutex_create in thread_mutex.c when APR_THREAD_MUTEX_NESTED is requested via flags. Added EXTRA_OECONF += "apr_cv_mutex_recursive=yes" to sources/openembedded-core/meta/recipes-support/apr/apr_1.4.6.bb.

Signed-off-by: Víctor Mayoral Vilches <v.mayoralv@gmail.com>
---
 meta/recipes-support/apr/apr_1.4.6.bb |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/recipes-support/apr/apr_1.4.6.bb b/meta/recipes-support/apr/apr_1.4.6.bb
index 896f79f..9200dcc 100644
--- a/meta/recipes-support/apr/apr_1.4.6.bb
+++ b/meta/recipes-support/apr/apr_1.4.6.bb
@@ -23,6 +23,9 @@ inherit autotools lib_package binconfig multilib_header
 
 OE_BINCONFIG_EXTRA_MANGLE = " -e 's:location=source:location=installed:'"
 
+# Added to fix some issues with cmake. Refer to https://github.com/bmwcarit/meta-ros/issues/68#issuecomment-19896928
+EXTRA_OECONF += "apr_cv_mutex_recursive=yes"
+
 do_configure_prepend() {
 	cd ${S}
 	./buildconf
-- 
1.7.9.5

Re: apr: Add EXTRA_OECONF += "apr_cv_mutex_recursive=yes"

[Víctor MV]

[-- Attachment #1.1: Type: text/plain, Size: 588 bytes --]

Updated the commit message and patch.


2013/7/1 Víctor MV <v.mayoralv@gmail.com>

> Working with the meta-ros project we detected that the ROS nodes didn't
> launch properly the reason was that by default apr_cv_mutex_recursive in
> apr is set to no and this leads to the APRENOTIMPL return value of
> apr_thread_mutex_create in thread_mutex.c when APR_THREAD_MUTEX_NESTED is
> requested via flags. Added EXTRA_OECONF += "apr_cv_mutex_recursive=yes" to
> sources/openembedded-core/meta/recipes-support/apr/apr_1.4.6.bb to fix
> this issue.
>
> Regards,
>
> Víctor.
>
>

[-- Attachment #1.2: Type: text/html, Size: 1010 bytes --]

[-- Attachment #2: 0001-Patch-to-apr_1.4.6.bb-to-make-rosnodes-work.patch --]
[-- Type: application/octet-stream, Size: 1326 bytes --]

From 1ccfc10c0afec7c6fd73804e1ac48cc46fd31eb0 Mon Sep 17 00:00:00 2001
From: victor <v.mayoralv@gmail.com>
Date: Mon, 1 Jul 2013 14:46:42 +0200
Subject: [PATCH] apr use a AC_TRY_RUN to check if PTHREAD_MUTEX_RECURSIVE is supported and this don't work on cross compile.

By default apr_cv_mutex_recursive in apr is set to no and this leads to the APRENOTIMPL return value of apr_thread_mutex_create in thread_mutex.c when APR_THREAD_MUTEX_NESTED is requ    ested via flags. Added EXTRA_OECONF += "apr_cv_mutex_recursive=yes" to sources/openembedded-core/meta/recipes-support/apr/apr_1.4.6.bb.

Signed-off-by: Víctor Mayoral Vilches <v.mayoralv@gmail.com>
---
 meta/recipes-support/apr/apr_1.4.6.bb |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/meta/recipes-support/apr/apr_1.4.6.bb b/meta/recipes-support/apr/apr_1.4.6.bb
index 896f79f..9200dcc 100644
--- a/meta/recipes-support/apr/apr_1.4.6.bb
+++ b/meta/recipes-support/apr/apr_1.4.6.bb
@@ -23,6 +23,9 @@ inherit autotools lib_package binconfig multilib_header
 
 OE_BINCONFIG_EXTRA_MANGLE = " -e 's:location=source:location=installed:'"
 
+# Added to fix rosnode issues. Refer to https://github.com/bmwcarit/meta-ros/issues/68#issuecomment-19896928
+EXTRA_OECONF += "apr_cv_mutex_recursive=yes"
+
 do_configure_prepend() {
 	cd ${S}
 	./buildconf
-- 
1.7.9.5

Re: apr: Add EXTRA_OECONF += "apr_cv_mutex_recursive=yes"

[Khem Raj]

[-- Attachment #1: Type: text/plain, Size: 1008 bytes --]


On Jul 1, 2013, at 6:12 AM, Víctor MV <v.mayoralv@gmail.com> wrote:

> Working with the meta-ros project we detected that the ROS nodes didn't launch properly the reason was that by default apr_cv_mutex_recursive in apr is set to no and this leads to the APRENOTIMPL return value of apr_thread_mutex_create in thread_mutex.c when APR_THREAD_MUTEX_NESTED is requested via flags. Added EXTRA_OECONF += "apr_cv_mutex_recursive=yes" to sources/openembedded-core/meta/recipes-support/apr/apr_1.4.6.bb to fix this issue.

thanks follow http://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded
to prepate the patch for review and instead of putting it in EXTRA_OECONF add it to CACHED_CONFIGUREVARS


> 
> Regards,
> 
> Víctor.
> 
> <0001-Patch-to-apr_1.4.6.bb-to-make-rosnodes-work.patch>_______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


[-- Attachment #2: Type: text/html, Size: 1794 bytes --]

Re: apr: Add EXTRA_OECONF += "apr_cv_mutex_recursive=yes"

[Burton, Ross]

On 1 July 2013 15:30, Khem Raj <raj.khem@gmail.com> wrote:
> to prepate the patch for review and instead of putting it in EXTRA_OECONF
> add it to CACHED_CONFIGUREVARS

If it's going to do to CACHED_CONFIGUREVARS then the same series
should also remove the mention of this variable in
meta/site/powerpc32-linux too...

(one day I'll start a big prune of the site values, moving the
non-architecture-specific values to generic files)

Ross

Re: apr: Add EXTRA_OECONF += "apr_cv_mutex_recursive=yes"

[Khem Raj]

On Jul 1, 2013, at 7:46 AM, "Burton, Ross" <ross.burton@intel.com> wrote:

> On 1 July 2013 15:30, Khem Raj <raj.khem@gmail.com> wrote:
>> to prepate the patch for review and instead of putting it in EXTRA_OECONF
>> add it to CACHED_CONFIGUREVARS
> 
> If it's going to do to CACHED_CONFIGUREVARS then the same series
> should also remove the mention of this variable in
> meta/site/powerpc32-linux too...
> 
> (one day I'll start a big prune of the site values, moving the
> non-architecture-specific values to generic files)

that will be a good work. many a times these values in common files step on each other when building different packages
containing those contentious ones in recipes would be good.

> 
> Ross