* [PATCH] buildstats.bbclass: collect host data only when do_testimage fails
@ 2021-08-27 19:32 Sakib Sajal
2021-08-30 20:21 ` [OE-core] " Richard Purdie
0 siblings, 1 reply; 2+ messages in thread
From: Sakib Sajal @ 2021-08-27 19:32 UTC (permalink / raw)
To: openembedded-core
Signed-off-by: Sakib Sajal <sakib.sajal@windriver.com>
---
meta/classes/buildstats.bbclass | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/classes/buildstats.bbclass b/meta/classes/buildstats.bbclass
index 0de605200a..874d30b292 100644
--- a/meta/classes/buildstats.bbclass
+++ b/meta/classes/buildstats.bbclass
@@ -250,7 +250,7 @@ python run_buildstats () {
except subprocess.CalledProcessError as err:
bb.warn("Failed to get rootfs size: %s" % err.output.decode('utf-8'))
- elif isinstance(e, bb.build.TaskFailed):
+ elif isinstance(e, bb.build.TaskFailed) and e.task == "do_testimage":
# Can have a failure before TaskStarted so need to mkdir here too
bb.utils.mkdirhier(taskdir)
write_task_data("failed", os.path.join(taskdir, e.task), e, d)
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [OE-core] [PATCH] buildstats.bbclass: collect host data only when do_testimage fails
2021-08-27 19:32 [PATCH] buildstats.bbclass: collect host data only when do_testimage fails Sakib Sajal
@ 2021-08-30 20:21 ` Richard Purdie
0 siblings, 0 replies; 2+ messages in thread
From: Richard Purdie @ 2021-08-30 20:21 UTC (permalink / raw)
To: Sakib Sajal, openembedded-core
On Fri, 2021-08-27 at 15:32 -0400, Sakib Sajal wrote:
> Signed-off-by: Sakib Sajal <sakib.sajal@windriver.com>
> ---
> meta/classes/buildstats.bbclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/classes/buildstats.bbclass b/meta/classes/buildstats.bbclass
> index 0de605200a..874d30b292 100644
> --- a/meta/classes/buildstats.bbclass
> +++ b/meta/classes/buildstats.bbclass
> @@ -250,7 +250,7 @@ python run_buildstats () {
> except subprocess.CalledProcessError as err:
> bb.warn("Failed to get rootfs size: %s" % err.output.decode('utf-8'))
>
> - elif isinstance(e, bb.build.TaskFailed):
> + elif isinstance(e, bb.build.TaskFailed) and e.task == "do_testimage":
> # Can have a failure before TaskStarted so need to mkdir here too
> bb.utils.mkdirhier(taskdir)
> write_task_data("failed", os.path.join(taskdir, e.task), e, d)
Doesn't this remove all failure handling rather than just host data? That
probably isn't what we want and isn't what the commit message says.
Cheers,
Richard
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-30 20:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-08-27 19:32 [PATCH] buildstats.bbclass: collect host data only when do_testimage fails Sakib Sajal
2021-08-30 20:21 ` [OE-core] " Richard Purdie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox