[scarthgap+][PATCH] watchdog: Set watchdog_module in default config

[scarthgap+][PATCH] watchdog: Set watchdog_module in default config

[Wadim Egorov]

systemd started to warn about used but unset environment variables.
Let us set watchdog_module=none which is used by the watchdog.service to get
rid of the following warning:

  watchdog.service: Referenced but unset environment variable evaluates to an empty string: watchdog_module

Signed-off-by: Wadim Egorov <w.egorov@phytec.de>
---
 meta/recipes-extended/watchdog/watchdog-config/watchdog.default | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-extended/watchdog/watchdog-config/watchdog.default b/meta/recipes-extended/watchdog/watchdog-config/watchdog.default
index 647d5abca5bd..cee5fdc2b6f7 100644
--- a/meta/recipes-extended/watchdog/watchdog-config/watchdog.default
+++ b/meta/recipes-extended/watchdog/watchdog-config/watchdog.default
@@ -1,2 +1,3 @@
 # Start watchdog at boot time? 0 or 1
 run_watchdog=1
+watchdog_module=none
-- 
2.25.1

Re: [OE-core] [scarthgap+][PATCH] watchdog: Set watchdog_module in default config

[Steve Sakoman]

Is this also an issue in master? If so, then this will need to be
submitted first for master and then I can backport.

Steve

On Thu, Jul 18, 2024 at 11:21 PM Wadim Egorov via
lists.openembedded.org <w.egorov=phytec.de@lists.openembedded.org>
wrote:
>
> systemd started to warn about used but unset environment variables.
> Let us set watchdog_module=none which is used by the watchdog.service to get
> rid of the following warning:
>
>   watchdog.service: Referenced but unset environment variable evaluates to an empty string: watchdog_module
>
> Signed-off-by: Wadim Egorov <w.egorov@phytec.de>
> ---
>  meta/recipes-extended/watchdog/watchdog-config/watchdog.default | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-extended/watchdog/watchdog-config/watchdog.default b/meta/recipes-extended/watchdog/watchdog-config/watchdog.default
> index 647d5abca5bd..cee5fdc2b6f7 100644
> --- a/meta/recipes-extended/watchdog/watchdog-config/watchdog.default
> +++ b/meta/recipes-extended/watchdog/watchdog-config/watchdog.default
> @@ -1,2 +1,3 @@
>  # Start watchdog at boot time? 0 or 1
>  run_watchdog=1
> +watchdog_module=none
> --
> 2.25.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#202250): https://lists.openembedded.org/g/openembedded-core/message/202250
> Mute This Topic: https://lists.openembedded.org/mt/107430686/3620601
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [steve@sakoman.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Re: [scarthgap+][PATCH] watchdog: Set watchdog_module in default config

[Wadim Egorov]

[-- Attachment #1: Type: text/plain, Size: 1428 bytes --]

On Fri, Jul 19, 2024 at 06:00 AM, Steve Sakoman wrote:

> 
> Is this also an issue in master? If so, then this will need to be
> submitted first for master and then I can backport.

Yes, do you want me to resend without the scarthgap tag?
This patch also applies to master.

> 
> 
> Steve
> 
> On Thu, Jul 18, 2024 at 11:21 PM Wadim Egorov via
> lists.openembedded.org <w.egorov=phytec.de@lists.openembedded.org>
> wrote:
> 
>> systemd started to warn about used but unset environment variables.
>> Let us set watchdog_module=none which is used by the watchdog.service to
>> get
>> rid of the following warning:
>> 
>> watchdog.service: Referenced but unset environment variable evaluates to
>> an empty string: watchdog_module
>> 
>> Signed-off-by: Wadim Egorov <w.egorov@phytec.de>
>> ---
>> meta/recipes-extended/watchdog/watchdog-config/watchdog.default | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git
>> a/meta/recipes-extended/watchdog/watchdog-config/watchdog.default
>> b/meta/recipes-extended/watchdog/watchdog-config/watchdog.default
>> index 647d5abca5bd..cee5fdc2b6f7 100644
>> --- a/meta/recipes-extended/watchdog/watchdog-config/watchdog.default
>> +++ b/meta/recipes-extended/watchdog/watchdog-config/watchdog.default
>> @@ -1,2 +1,3 @@
>> # Start watchdog at boot time? 0 or 1
>> run_watchdog=1
>> +watchdog_module=none
>> --
>> 2.25.1
>> 
>> 
>> 
> 
>

[-- Attachment #2: Type: text/html, Size: 1579 bytes --]

Re: [OE-core] [scarthgap+][PATCH] watchdog: Set watchdog_module in default config

[Steve Sakoman]

On Sun, Jul 21, 2024 at 11:09 PM Wadim Egorov via
lists.openembedded.org <w.egorov=phytec.de@lists.openembedded.org>
wrote:
>
> On Fri, Jul 19, 2024 at 06:00 AM, Steve Sakoman wrote:
>
> Is this also an issue in master? If so, then this will need to be
> submitted first for master and then I can backport.
>
> Yes, do you want me to resend without the scarthgap tag?
> This patch also applies to master.

I see you sent it for master, thanks!  I'll backport when it hits master.

Steve

> On Thu, Jul 18, 2024 at 11:21 PM Wadim Egorov via
> lists.openembedded.org <w.egorov=phytec.de@lists.openembedded.org>
> wrote:
>
> systemd started to warn about used but unset environment variables.
> Let us set watchdog_module=none which is used by the watchdog.service to get
> rid of the following warning:
>
> watchdog.service: Referenced but unset environment variable evaluates to an empty string: watchdog_module
>
> Signed-off-by: Wadim Egorov <w.egorov@phytec.de>
> ---
> meta/recipes-extended/watchdog/watchdog-config/watchdog.default | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-extended/watchdog/watchdog-config/watchdog.default b/meta/recipes-extended/watchdog/watchdog-config/watchdog.default
> index 647d5abca5bd..cee5fdc2b6f7 100644
> --- a/meta/recipes-extended/watchdog/watchdog-config/watchdog.default
> +++ b/meta/recipes-extended/watchdog/watchdog-config/watchdog.default
> @@ -1,2 +1,3 @@
> # Start watchdog at boot time? 0 or 1
> run_watchdog=1
> +watchdog_module=none
> --
> 2.25.1
>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#202305): https://lists.openembedded.org/g/openembedded-core/message/202305
> Mute This Topic: https://lists.openembedded.org/mt/107430686/3620601
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [steve@sakoman.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Re: [OE-core] [scarthgap+][PATCH] watchdog: Set watchdog_module in default config

[Wadim Egorov]

Am 22.07.24 um 17:25 schrieb Steve Sakoman:
> On Sun, Jul 21, 2024 at 11:09 PM Wadim Egorov via
> lists.openembedded.org <w.egorov=phytec.de@lists.openembedded.org>
> wrote:
>>
>> On Fri, Jul 19, 2024 at 06:00 AM, Steve Sakoman wrote:
>>
>> Is this also an issue in master? If so, then this will need to be
>> submitted first for master and then I can backport.
>>
>> Yes, do you want me to resend without the scarthgap tag?
>> This patch also applies to master.
>
> I see you sent it for master, thanks!  I'll backport when it hits master.

FYI: Just made it into master,

7a824eded561 ("watchdog: Set watchdog_module in default config")

>
> Steve
>
>> On Thu, Jul 18, 2024 at 11:21 PM Wadim Egorov via
>> lists.openembedded.org <w.egorov=phytec.de@lists.openembedded.org>
>> wrote:
>>
>> systemd started to warn about used but unset environment variables.
>> Let us set watchdog_module=none which is used by the watchdog.service to get
>> rid of the following warning:
>>
>> watchdog.service: Referenced but unset environment variable evaluates to an empty string: watchdog_module
>>
>> Signed-off-by: Wadim Egorov <w.egorov@phytec.de>
>> ---
>> meta/recipes-extended/watchdog/watchdog-config/watchdog.default | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/meta/recipes-extended/watchdog/watchdog-config/watchdog.default b/meta/recipes-extended/watchdog/watchdog-config/watchdog.default
>> index 647d5abca5bd..cee5fdc2b6f7 100644
>> --- a/meta/recipes-extended/watchdog/watchdog-config/watchdog.default
>> +++ b/meta/recipes-extended/watchdog/watchdog-config/watchdog.default
>> @@ -1,2 +1,3 @@
>> # Start watchdog at boot time? 0 or 1
>> run_watchdog=1
>> +watchdog_module=none
>> --
>> 2.25.1
>>
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#202305): https://lists.openembedded.org/g/openembedded-core/message/202305
>> Mute This Topic: https://lists.openembedded.org/mt/107430686/3620601
>> Group Owner: openembedded-core+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [steve@sakoman.com]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>

Re: [OE-core] [scarthgap+][PATCH] watchdog: Set watchdog_module in default config

[Steve Sakoman]

On Fri, Aug 2, 2024 at 12:01 AM Wadim Egorov <w.egorov@phytec.de> wrote:
>
>
>
> Am 22.07.24 um 17:25 schrieb Steve Sakoman:
> > On Sun, Jul 21, 2024 at 11:09 PM Wadim Egorov via
> > lists.openembedded.org <w.egorov=phytec.de@lists.openembedded.org>
> > wrote:
> >>
> >> On Fri, Jul 19, 2024 at 06:00 AM, Steve Sakoman wrote:
> >>
> >> Is this also an issue in master? If so, then this will need to be
> >> submitted first for master and then I can backport.
> >>
> >> Yes, do you want me to resend without the scarthgap tag?
> >> This patch also applies to master.
> >
> > I see you sent it for master, thanks!  I'll backport when it hits master.
>
> FYI: Just made it into master,
>
> 7a824eded561 ("watchdog: Set watchdog_module in default config")

I saw that!  I have it in my scarthgap test queue now.

Steve

>
> >
> > Steve
> >
> >> On Thu, Jul 18, 2024 at 11:21 PM Wadim Egorov via
> >> lists.openembedded.org <w.egorov=phytec.de@lists.openembedded.org>
> >> wrote:
> >>
> >> systemd started to warn about used but unset environment variables.
> >> Let us set watchdog_module=none which is used by the watchdog.service to get
> >> rid of the following warning:
> >>
> >> watchdog.service: Referenced but unset environment variable evaluates to an empty string: watchdog_module
> >>
> >> Signed-off-by: Wadim Egorov <w.egorov@phytec.de>
> >> ---
> >> meta/recipes-extended/watchdog/watchdog-config/watchdog.default | 1 +
> >> 1 file changed, 1 insertion(+)
> >>
> >> diff --git a/meta/recipes-extended/watchdog/watchdog-config/watchdog.default b/meta/recipes-extended/watchdog/watchdog-config/watchdog.default
> >> index 647d5abca5bd..cee5fdc2b6f7 100644
> >> --- a/meta/recipes-extended/watchdog/watchdog-config/watchdog.default
> >> +++ b/meta/recipes-extended/watchdog/watchdog-config/watchdog.default
> >> @@ -1,2 +1,3 @@
> >> # Start watchdog at boot time? 0 or 1
> >> run_watchdog=1
> >> +watchdog_module=none
> >> --
> >> 2.25.1
> >>
> >>
> >>
> >> -=-=-=-=-=-=-=-=-=-=-=-
> >> Links: You receive all messages sent to this group.
> >> View/Reply Online (#202305): https://lists.openembedded.org/g/openembedded-core/message/202305
> >> Mute This Topic: https://lists.openembedded.org/mt/107430686/3620601
> >> Group Owner: openembedded-core+owner@lists.openembedded.org
> >> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [steve@sakoman.com]
> >> -=-=-=-=-=-=-=-=-=-=-=-
> >>