[PATCH] nativesdk-gzip: fix reproducibility issues

[PATCH] nativesdk-gzip: fix reproducibility issues

[Oleh Matiusha]

There is absolute path in zgrep binary. It is related
to the changes that fix an issue with zgrep on Solaris
and other platforms with 'grep -e'. I'd like to ask here
if Yocto supports Solaris as host architecture, and
if there's a reliable way to detect the host arch.
If there is, I'll place additional check to be
compatible with it.

Original change:
git.savannah.gnu.org/cgit/gzip.git/commit?id=60b3f4eb672a85de28ecaad47ed426f8c8fe6c32

Signed-off-by: Oleh Matiusha <omatiush@cisco.com>
---
 meta/recipes-extended/gzip/gzip.inc | 1 +
 1 file changed, 1 insertion(+)

diff --git a/meta/recipes-extended/gzip/gzip.inc b/meta/recipes-extended/gzip/gzip.inc
index b32584033b..62b3e2f4f9 100644
--- a/meta/recipes-extended/gzip/gzip.inc
+++ b/meta/recipes-extended/gzip/gzip.inc
@@ -8,6 +8,7 @@ inherit autotools texinfo
 export DEFS="NO_ASM"
 
 EXTRA_OEMAKE:class-target = "GREP=${base_bindir}/grep"
+EXTRA_OEMAKE:append:class-nativesdk = " GREP=grep"
 EXTRA_OECONF:append:libc-musl = " gl_cv_func_fflush_stdin=yes "
 
 do_install:append () {
-- 
2.33.0

Re: [OE-core] [PATCH] nativesdk-gzip: fix reproducibility issues

[Khem Raj]

On Thu, Apr 11, 2024 at 6:32 AM Oleh Matiusha via
lists.openembedded.org <omatiush=cisco.com@lists.openembedded.org>
wrote:
>
> There is absolute path in zgrep binary. It is related
> to the changes that fix an issue with zgrep on Solaris
> and other platforms with 'grep -e'. I'd like to ask here
> if Yocto supports Solaris as host architecture, and
> if there's a reliable way to detect the host arch.
> If there is, I'll place additional check to be
> compatible with it.

We do not have support for solaris build hosts.

>
> Original change:
> git.savannah.gnu.org/cgit/gzip.git/commit?id=60b3f4eb672a85de28ecaad47ed426f8c8fe6c32
>
> Signed-off-by: Oleh Matiusha <omatiush@cisco.com>
> ---
>  meta/recipes-extended/gzip/gzip.inc | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-extended/gzip/gzip.inc b/meta/recipes-extended/gzip/gzip.inc
> index b32584033b..62b3e2f4f9 100644
> --- a/meta/recipes-extended/gzip/gzip.inc
> +++ b/meta/recipes-extended/gzip/gzip.inc
> @@ -8,6 +8,7 @@ inherit autotools texinfo
>  export DEFS="NO_ASM"
>
>  EXTRA_OEMAKE:class-target = "GREP=${base_bindir}/grep"
> +EXTRA_OEMAKE:append:class-nativesdk = " GREP=grep"
>  EXTRA_OECONF:append:libc-musl = " gl_cv_func_fflush_stdin=yes "
>
>  do_install:append () {
> --
> 2.33.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#198130): https://lists.openembedded.org/g/openembedded-core/message/198130
> Mute This Topic: https://lists.openembedded.org/mt/105462485/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Re: [PATCH] nativesdk-gzip: fix reproducibility issues

[Oleh Matiusha]

[-- Attachment #1: Type: text/plain, Size: 38 bytes --]

Can it be accepted in upstream then?

[-- Attachment #2: Type: text/html, Size: 38 bytes --]

Re: [OE-core] [PATCH] nativesdk-gzip: fix reproducibility issues

[Richard Purdie]

On Thu, 2024-04-11 at 13:32 +0000, Oleh Matiusha via
lists.openembedded.org wrote:
> There is absolute path in zgrep binary. It is related
> to the changes that fix an issue with zgrep on Solaris
> and other platforms with 'grep -e'. I'd like to ask here
> if Yocto supports Solaris as host architecture, and
> if there's a reliable way to detect the host arch.
> If there is, I'll place additional check to be
> compatible with it.

How far did you get builds to work on Solaris out of interest?

We don't support it since none of us have access to it and it is
something we've never really been asked about before.

We did used to add BUILD_OS to OVERRIDES so that you could do build
system overrides to variables. It was so rarely used we ended up
dropping it though.

I'm not against the idea of Solaris support but I'd want to understand
how invasive it is and it may be better starting as a separate layer.
That layer could append to OVERRIDES to make the metadata easier for
example.

Also, is this running builds on Solaris, or is this building SDKs to
run on Solaris. I suddenly realised this could be taken both ways.

Cheers,

Richard

Re: [OE-core] [PATCH] nativesdk-gzip: fix reproducibility issues

[Oleh Matiusha -X (omatiush - GLOBALLOGIC INC at Cisco)]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]


​How far did you get builds to work on Solaris out of interest?


Perhaps you have misunderstood me. I have neither the desire nor the hardware to work on providing Solaris support, but I asked if Yocto supports or plans to support Solaris to see if my patch is compatible with the current version.



[-- Attachment #2: Type: text/html, Size: 1484 bytes --]

Re: [OE-core] [PATCH] nativesdk-gzip: fix reproducibility issues

[Richard Purdie]

On Fri, 2024-04-12 at 14:55 +0000, Oleh Matiusha -X (omatiush -
GLOBALLOGIC INC at Cisco) wrote:
> > ​How far did you get builds to work on Solaris out of interest?
> 
> 
> Perhaps you have misunderstood me. I have neither the desire nor the
> hardware to work on providing Solaris support, but I asked if Yocto
> supports or plans to support Solaris to see if my patch is compatible
> with the current version.

Definitely misunderstanding! We have no support or plans for support
for Solaris.

Cheers,

Richard