From: Ross Burton <Ross.Burton@arm.com>
To: Alexander Kanavin <alex.kanavin@gmail.com>
Cc: Changqing Li <changqing.li@eng.windriver.com>,
"openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [master][PATCH 2/2] rootfs-postcommands.bbclass: add post func remove_unused_dnf_log_lock
Date: Tue, 4 Jul 2023 11:11:33 +0000 [thread overview]
Message-ID: <328B87A9-2B41-4B96-ACBE-C84E3575E1FC@arm.com> (raw)
In-Reply-To: <CANNYZj-6GkQ-udC+Nd0zyQbwKtkfrr0hNKZ-AaMEUzgnTCNT1A@mail.gmail.com>
On 30 Jun 2023, at 16:07, Alexander Kanavin via lists.openembedded.org <alex.kanavin=gmail.com@lists.openembedded.org> wrote:
>
> On Fri, 30 Jun 2023 at 11:14, Changqing Li
> <changqing.li@eng.windriver.com> wrote:
>> Remove log_lock.pid which maybe created during do_rootfs. In commit
>> [dnf: only write the log lock to root for native dnf],
>> native dnf changed to write log lock to root, and target dnf still
>> use /var/log, so log_lock.pid need to be removed post do_rootfs.
>
> This is not making clear why the file needs to be removed. What
> problems occur if it is left in place? Is it supposed to be added,
> then removed by dnf during do_rootfs, and if this doesn't happen, is
> that a problem with dnf that needs to be fixed, rather than removing
> the file manually after the fact?
Absolutely. If the dnf image creation is leaving lock files then we fix the dnf image creation. Does dnf leave a daemon hanging around? Does it leave lock files when it shouldn’t? Either way, this should be in dnf or the image creation code itself, not a generic rootfs postcommand.
Ross
next prev parent reply other threads:[~2023-07-04 11:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 9:14 [master][PATCH 1/2] dnf: only write the log lock to root for native dnf changqing.li
2023-06-30 9:14 ` [master][PATCH 2/2] rootfs-postcommands.bbclass: add post func remove_unused_dnf_log_lock changqing.li
2023-06-30 15:07 ` [OE-core] " Alexander Kanavin
2023-07-04 11:11 ` Ross Burton [this message]
2023-07-11 8:34 ` Changqing Li
2023-07-17 20:22 ` Alexander Kanavin
2023-12-05 5:46 ` Changqing Li
2023-12-05 9:55 ` Alexander Kanavin
2023-12-06 2:39 ` Changqing Li
2023-12-06 9:41 ` Alexander Kanavin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=328B87A9-2B41-4B96-ACBE-C84E3575E1FC@arm.com \
--to=ross.burton@arm.com \
--cc=alex.kanavin@gmail.com \
--cc=changqing.li@eng.windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox