From: ChenQi <Qi.Chen@windriver.com>
To: Hongxu Jia <hongxu.jia@windriver.com>,
<openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 1/2] webkitgtk: add opengl to REQUIRED_DISTRO_FEATURES
Date: Tue, 9 Oct 2018 09:49:41 +0800 [thread overview]
Message-ID: <3360571c-255f-bd57-eb2c-e08082402c58@windriver.com> (raw)
In-Reply-To: <1535967326-32322-1-git-send-email-hongxu.jia@windriver.com>
ping
I think webkitgtk does require the 'opengl' distro feature.
Best Regards,
Chen Qi
On 09/03/2018 05:35 PM, Hongxu Jia wrote:
> They can't be built without opengl in DISTRO_FEATURES.
> [snip]
> |webkitgtk-2.20.3/Source/WebCore/platform/graphics/OpenGLShims.h:23:10:
> fatal error: GL/gl.h: No such file or directory
> [snip]
>
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
> meta/recipes-sato/webkit/webkitgtk_2.20.3.bb | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb b/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
> index a528c5d..93d74bb 100644
> --- a/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
> +++ b/meta/recipes-sato/webkit/webkitgtk_2.20.3.bb
> @@ -29,8 +29,7 @@ SRC_URI[sha256sum] = "579b307d78fa16a73f112790178022166d7ad17d4147492ced9b9fba48
>
> inherit cmake pkgconfig gobject-introspection perlnative distro_features_check upstream-version-is-even gtk-doc
>
> -# depends on libxt
> -REQUIRED_DISTRO_FEATURES = "x11"
> +REQUIRED_DISTRO_FEATURES = "x11 opengl"
>
> DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn libgcrypt \
> gtk+3 gstreamer1.0 gstreamer1.0-plugins-base flex-native gperf-native sqlite3 \
next prev parent reply other threads:[~2018-10-09 1:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 9:35 [PATCH 1/2] webkitgtk: add opengl to REQUIRED_DISTRO_FEATURES Hongxu Jia
2018-09-03 9:35 ` [PATCH 2/2] weston: fix build failure with --disable-egl Hongxu Jia
2018-09-03 16:51 ` Khem Raj
2018-09-03 9:54 ` [PATCH 1/2] webkitgtk: add opengl to REQUIRED_DISTRO_FEATURES Alexander Kanavin
2018-09-04 13:29 ` Hongxu Jia
2018-09-04 14:39 ` Alexander Kanavin
2018-09-03 16:51 ` Khem Raj
2018-10-09 1:49 ` ChenQi [this message]
2018-10-09 1:53 ` ChenQi
2018-10-09 1:53 ` Khem Raj
2018-10-10 3:06 ` Hongxu Jia
2018-10-10 3:09 ` [PATCH V2] " Hongxu Jia
2018-10-10 3:21 ` Andre McCurdy
2018-10-10 5:56 ` [PATCH V3] " Hongxu Jia
2018-10-10 7:16 ` [PATCH V4] webkitgtk/epiphany: " Hongxu Jia
2018-10-10 7:14 ` Hongxu Jia
2018-10-10 3:33 ` ✗ patchtest: failure for "webkitgtk: add opengl to REQUI..." and 1 more (rev2) Patchwork
2018-10-10 6:03 ` ✗ patchtest: failure for "webkitgtk: add opengl to REQUI..." and 1 more (rev3) Patchwork
2018-10-10 7:32 ` ✗ patchtest: failure for "webkitgtk: add opengl to REQUI..." and 1 more (rev4) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3360571c-255f-bd57-eb2c-e08082402c58@windriver.com \
--to=qi.chen@windriver.com \
--cc=hongxu.jia@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox