Re: [PATCH V4] webkitgtk/epiphany: add opengl to REQUIRED_DISTRO_FEATURES

[Hongxu Jia <hongxu.jia@windriver.com>]

Hi RP,

I saw you merged V3 to master-next, but I found epiphany depends
on webkitgtk, it also need to add opengl to REQUIRED_DISTRO_FEATURES

Please use V4 to replace

I test it with `bitbake world -n' without `opengl' in DISTRO_FEATURES

Sorry for so many revision, thanks for patchtest, mention
me to correct the error I introduced.

//Hongxu

On 2018年10月10日 15:16, Hongxu Jia wrote:
> They can't be built without opengl in DISTRO_FEATURES.
> [snip]
> |webkitgtk-2.20.3/Source/WebCore/platform/graphics/OpenGLShims.h:23:10:
> fatal error: GL/gl.h: No such file or directory
> [snip]
>
> Some sort of GL is needed yes. We indicate that with opengl loosely in OE
>
> The epiphany depends on webkitgtk, add opengl to REQUIRED_DISTRO_FEATURES also.
>
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
>   meta/recipes-gnome/epiphany/epiphany_3.28.3.1.bb | 2 +-
>   meta/recipes-sato/webkit/webkitgtk_2.20.5.bb     | 3 +--
>   2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/meta/recipes-gnome/epiphany/epiphany_3.28.3.1.bb b/meta/recipes-gnome/epiphany/epiphany_3.28.3.1.bb
> index 8837b9c..b46c9d3 100644
> --- a/meta/recipes-gnome/epiphany/epiphany_3.28.3.1.bb
> +++ b/meta/recipes-gnome/epiphany/epiphany_3.28.3.1.bb
> @@ -8,7 +8,7 @@ DEPENDS = "libsoup-2.4 webkitgtk gtk+3 iso-codes avahi libnotify gcr \
>   
>   GNOMEBASEBUILDCLASS = "meson"
>   inherit gnomebase gsettings distro_features_check upstream-version-is-even gettext
> -REQUIRED_DISTRO_FEATURES = "x11"
> +REQUIRED_DISTRO_FEATURES = "x11 opengl"
>   
>   SRC_URI = "${GNOME_MIRROR}/${GNOMEBN}/${@gnome_verdir("${PV}")}/${GNOMEBN}-${PV}.tar.${GNOME_COMPRESS_TYPE};name=archive \
>              file://0002-help-meson.build-disable-the-use-of-yelp.patch \
> diff --git a/meta/recipes-sato/webkit/webkitgtk_2.20.5.bb b/meta/recipes-sato/webkit/webkitgtk_2.20.5.bb
> index c8d4f94..7f1ffce 100644
> --- a/meta/recipes-sato/webkit/webkitgtk_2.20.5.bb
> +++ b/meta/recipes-sato/webkit/webkitgtk_2.20.5.bb
> @@ -30,8 +30,7 @@ SRC_URI[sha256sum] = "15c0f8d26e9605afe0948d161ba5fd82efee8eda2debd409fd40a440ac
>   
>   inherit cmake pkgconfig gobject-introspection perlnative distro_features_check upstream-version-is-even gtk-doc
>   
> -# depends on libxt
> -REQUIRED_DISTRO_FEATURES = "x11"
> +REQUIRED_DISTRO_FEATURES = "x11 opengl"
>   
>   DEPENDS = "zlib libsoup-2.4 curl libxml2 cairo libxslt libxt libidn libgcrypt \
>              gtk+3 gstreamer1.0 gstreamer1.0-plugins-base flex-native gperf-native sqlite3 \