From: Khem Raj <raj.khem@gmail.com>
To: Kevin Hao <kexin.hao@windriver.com>,
openembedded-core@lists.openembedded.org
Cc: Richard Purdie <richard.purdie@linuxfoundation.org>
Subject: Re: [OE-core] [PATCH] tune-cortexa72: Enable the crc extension by default for cortexa72
Date: Wed, 12 Jan 2022 09:30:00 -0800 [thread overview]
Message-ID: <337f48d3-805c-a061-1aa7-d30e6845490f@gmail.com> (raw)
In-Reply-To: <20220112090708.1597301-1-kexin.hao@windriver.com>
On 1/12/22 1:07 AM, Kevin Hao wrote:
> The crc extension is optional for the ARMv8.0 but is mandatory for the
> cortexa72, so there is no reason not to enable it for the cortexa72
> tune. With this change, the cortexa72-crc seems redundant. But we
> had better to keep it to be compatible with the BSP which already used
> that tune.
this looks good. Is there a way to warn such users to migrate to better
option ?
>
> Signed-off-by: Kevin Hao <kexin.hao@windriver.com>
> ---
> .../machine/include/arm/armv8a/tune-cortexa72.inc | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc b/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc
> index 3651cf6e802b..4c9add32f5f5 100644
> --- a/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc
> +++ b/meta/conf/machine/include/arm/armv8a/tune-cortexa72.inc
> @@ -10,12 +10,12 @@ AVAILTUNES += "cortexa72 cortexa72-crc cortexa72-crc-crypto"
> ARMPKGARCH:tune-cortexa72 = "cortexa72"
> ARMPKGARCH:tune-cortexa72-crc = "cortexa72"
> ARMPKGARCH:tune-cortexa72-crc-crypto = "cortexa72"
> -TUNE_FEATURES:tune-cortexa72 = "${TUNE_FEATURES:tune-armv8a} cortexa72"
> -TUNE_FEATURES:tune-cortexa72-crc = "${TUNE_FEATURES:tune-cortexa72} crc"
> -TUNE_FEATURES:tune-cortexa72-crc-crypto = "${TUNE_FEATURES:tune-cortexa72} crc crypto"
> -PACKAGE_EXTRA_ARCHS:tune-cortexa72 = "${PACKAGE_EXTRA_ARCHS:tune-armv8} cortexa72"
> -PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa72 cortexa72-crc"
> -PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc-crypto = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72 cortexa72-crc cortexa72-crc-crypto"
> +TUNE_FEATURES:tune-cortexa72 = "${TUNE_FEATURES:tune-armv8a-crc} cortexa72"
> +TUNE_FEATURES:tune-cortexa72-crc = "${TUNE_FEATURES:tune-cortexa72}"
> +TUNE_FEATURES:tune-cortexa72-crc-crypto = "${TUNE_FEATURES:tune-cortexa72} crypto"
> +PACKAGE_EXTRA_ARCHS:tune-cortexa72 = "${PACKAGE_EXTRA_ARCHS:tune-armv8-crc} cortexa72"
> +PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa72"
> +PACKAGE_EXTRA_ARCHS:tune-cortexa72-crc-crypto = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa72 cortexa72-crc-crypto"
> BASE_LIB:tune-cortexa72 = "lib64"
> BASE_LIB:tune-cortexa72-crc = "lib64"
> BASE_LIB:tune-cortexa72-crc-crypto = "lib64"
>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#160480): https://lists.openembedded.org/g/openembedded-core/message/160480
> Mute This Topic: https://lists.openembedded.org/mt/88369540/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
next prev parent reply other threads:[~2022-01-12 17:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-12 9:07 [PATCH] tune-cortexa72: Enable the crc extension by default for cortexa72 Kevin Hao
2022-01-12 17:30 ` Khem Raj [this message]
2022-01-12 19:24 ` [OE-core] " Jon Mason
2022-01-12 19:23 ` Jon Mason
2022-01-12 21:58 ` Richard Purdie
2022-01-13 0:14 ` Khem Raj
2022-01-13 13:42 ` Kevin Hao
2022-01-13 22:58 ` Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=337f48d3-805c-a061-1aa7-d30e6845490f@gmail.com \
--to=raj.khem@gmail.com \
--cc=kexin.hao@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox