Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Jon Mason <jdmason@kudzu.us>, Kevin Hao <kexin.hao@windriver.com>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] tune-cortexa72: Enable the crc extension by default for cortexa72
Date: Wed, 12 Jan 2022 21:58:08 +0000	[thread overview]
Message-ID: <bc571d45ac0dc66bb9a3409b1215815ca369283f.camel@linuxfoundation.org> (raw)
In-Reply-To: <CAPoiz9wdB1z_mC5Td6RpN63ED_7Mm+7vBmDQtf=XoRmYLwCrVA@mail.gmail.com>

On Wed, 2022-01-12 at 14:23 -0500, Jon Mason wrote:
> On Wed, Jan 12, 2022 at 4:11 AM Kevin Hao <kexin.hao@windriver.com> wrote:
> > 
> > The crc extension is optional for the ARMv8.0 but is mandatory for the
> > cortexa72, so there is no reason not to enable it for the cortexa72
> > tune. With this change, the cortexa72-crc seems redundant. But we
> > had better to keep it to be compatible with the BSP which already used
> > that tune.
> > 
> > Signed-off-by: Kevin Hao <kexin.hao@windriver.com>
> 
> Acked-by: Jon Mason <jdmason@kudzu.us>
> 
> From the GCC sources, it's hard coded for A34, A35, A53, A57, A72,
> A73, and almost all of the others listed.  I can patch the rest.

I did wonder if we should just drop the duplicate tune too. It will cause an
error but it is an error that should be quickly/easily fixed...

Cheers,

Richard



  reply	other threads:[~2022-01-12 21:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-12  9:07 [PATCH] tune-cortexa72: Enable the crc extension by default for cortexa72 Kevin Hao
2022-01-12 17:30 ` [OE-core] " Khem Raj
2022-01-12 19:24   ` Jon Mason
2022-01-12 19:23 ` Jon Mason
2022-01-12 21:58   ` Richard Purdie [this message]
2022-01-13  0:14     ` Khem Raj
2022-01-13 13:42       ` Kevin Hao
2022-01-13 22:58   ` Jon Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc571d45ac0dc66bb9a3409b1215815ca369283f.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=jdmason@kudzu.us \
    --cc=kexin.hao@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox