From: "Saul Wold" <Saul.Wold@windriver.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
openembedded-core@lists.openembedded.org
Cc: Joshua Watt <JPEWhacker@gmail.com>
Subject: Re: [OE-core] [PATCH 2/2] quilt: Only package guard for the target
Date: Tue, 31 Aug 2021 07:35:26 -0700 [thread overview]
Message-ID: <3401b75b-e098-40bd-7c07-b4a928a83c0d@windriver.com> (raw)
In-Reply-To: <ec56dc17f8303ccc907d859014d88c1b808c7e47.camel@linuxfoundation.org>
On 8/30/21 1:19 PM, Richard Purdie wrote:
> On Fri, 2021-08-27 at 14:57 -0700, Saul Wold wrote:
>> The guard binary and documentaiton should only be be packaged for the
>> target class.
>>
>> Signed-off-by: Saul Wold <saul.wold@windriver.com>
>> ---
>> meta/recipes-devtools/quilt/quilt.inc | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-devtools/quilt/quilt.inc b/meta/recipes-devtools/quilt/quilt.inc
>> index f85de384d2..41d30e89aa 100644
>> --- a/meta/recipes-devtools/quilt/quilt.inc
>> +++ b/meta/recipes-devtools/quilt/quilt.inc
>> @@ -73,7 +73,7 @@ do_install_ptest() {
>> cp ${WORKDIR}/test.sh ${D}${PTEST_PATH}
>> }
>>
>> -PACKAGES += "guards guards-doc"
>> +PACKAGES:append:class-target += "guards guards-doc"
>>
>> FILES:${PN} = "${sysconfdir} ${datadir}/quilt \
>> ${bindir}/quilt ${libdir}/quilt"
>
> Again, why?
>
I was doing some testing with the create_spdx code and found a condition
when I had built quilt (in this case) and then cleaned the quilt-native,
when I rebuilt quilt-native I got the following error:
ERROR: quilt-native-0.66-r0 do_create_spdx: Recipe quilt-native is
trying to create package guards which was already written by recipe
quilt. This will cause corruption, please resolve this and only provide
the package from one recipe or the other or only build one of the recipes.
> This should be fine/ignored for native/cross and applicable to nativesdk?
>
Maybe the issue is actually in the create_spdx() code,
Sau!
> Cheers,
>
> Richard
>
--
Sau!
next prev parent reply other threads:[~2021-08-31 14:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-27 21:57 [PATCH 1/2] libtool: Only package libltdl for the target Saul Wold
2021-08-27 21:57 ` [PATCH 2/2] quilt: Only package guard " Saul Wold
2021-08-27 23:13 ` [OE-core] " Khem Raj
2021-08-30 20:19 ` Richard Purdie
2021-08-31 14:35 ` Saul Wold [this message]
2021-08-27 23:12 ` [OE-core] [PATCH 1/2] libtool: Only package libltdl " Khem Raj
2021-08-30 20:18 ` Richard Purdie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3401b75b-e098-40bd-7c07-b4a928a83c0d@windriver.com \
--to=saul.wold@windriver.com \
--cc=JPEWhacker@gmail.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox