public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: "Richard Purdie" <richard.purdie@linuxfoundation.org>
To: Saul Wold <Saul.Wold@windriver.com>,
	 openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH 1/2] libtool: Only package libltdl for the target
Date: Mon, 30 Aug 2021 21:18:41 +0100	[thread overview]
Message-ID: <82b35173ceb0cc5e3a9b82c17c4c2f01730c9998.camel@linuxfoundation.org> (raw)
In-Reply-To: <20210827215743.2027466-1-saul.wold@windriver.com>

On Fri, 2021-08-27 at 14:57 -0700, Saul Wold wrote:
> The libltdl package is not needed for -native or -cross, so make it's
> only packaged for the target class.
> 
> Signed-off-by: Saul Wold <saul.wold@windriver.com>
> ---
>  meta/recipes-devtools/libtool/libtool-2.4.6.inc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/libtool/libtool-2.4.6.inc b/meta/recipes-devtools/libtool/libtool-2.4.6.inc
> index 6748d7468e..38982bf67f 100644
> --- a/meta/recipes-devtools/libtool/libtool-2.4.6.inc
> +++ b/meta/recipes-devtools/libtool/libtool-2.4.6.inc
> @@ -43,7 +43,7 @@ CACHED_CONFIGUREVARS += "ac_cv_path_GREP=grep"
>  
>  DEPENDS = "libtool-native"
>  
> -PACKAGES =+ "libltdl"
> +PACKAGES:prepend:class-target =+ "libltdl"
>  FILES:${PN} += "${datadir}/aclocal"
>  
>  FILES:${PN}-dev:remove = "${datadir}/aclocal"

Since native and cross don't generate packages, why do we need to do this?

Rather that what the commit message says, this would seem to cause nativesdk to
be unpackaged?

Cheers,

Richard


      parent reply	other threads:[~2021-08-30 20:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-27 21:57 [PATCH 1/2] libtool: Only package libltdl for the target Saul Wold
2021-08-27 21:57 ` [PATCH 2/2] quilt: Only package guard " Saul Wold
2021-08-27 23:13   ` [OE-core] " Khem Raj
2021-08-30 20:19   ` Richard Purdie
2021-08-31 14:35     ` Saul Wold
2021-08-27 23:12 ` [OE-core] [PATCH 1/2] libtool: Only package libltdl " Khem Raj
2021-08-30 20:18 ` Richard Purdie [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=82b35173ceb0cc5e3a9b82c17c4c2f01730c9998.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=Saul.Wold@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox