From: Ross Burton <Ross.Burton@arm.com>
To: "changqing.li@windriver.com" <changqing.li@windriver.com>
Cc: "openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH V2] lua: upgrade from 5.4.8 to 5.5.0
Date: Thu, 26 Feb 2026 13:37:11 +0000 [thread overview]
Message-ID: <39D9B021-BF4B-4050-8D22-53C33E84F8C9@arm.com> (raw)
In-Reply-To: <20260224024638.1146564-1-changqing.li@windriver.com>
On 24 Feb 2026, at 02:46, Changqing Li via lists.openembedded.org <changqing.li=windriver.com@lists.openembedded.org> wrote:
> -LIC_FILES_CHKSUM = "file://doc/readme.html;beginline=305;endline=326;md5=0e573c143cb6491b41cf02cfbcb8c267"
> +LIC_FILES_CHKSUM = "file://doc/readme.html;beginline=299;endline=320;md5=0e573c143cb6491b41cf02cfbcb8c267"
You need a License-Update: line in the commit message explaining why this changed.
> -PACKAGECONFIG ??= "readline"
> -PACKAGECONFIG[readline] = ",,readline"
> +DEPENDS = "readline"
Why is this no longer conditional? Readline is GPLv3 so there are people who want to disable this everywhere.
> do_install () {
> @@ -40,13 +39,13 @@ do_install () {
> 'INSTALL_MAN=${D}${mandir}/man1' \
> 'INSTALL_SHARE=${D}${datadir}/lua' \
> 'INSTALL_LIB=${D}${libdir}' \
> - 'INSTALL_CMOD=${D}${libdir}/lua/5.4' \
> + 'INSTALL_CMOD=${D}${libdir}/lua/5.5' \
> install
> install -d ${D}${libdir}/pkgconfig
>
> sed -e s/@VERSION@/${PV}/ -e s#@LIBDIR@#${libdir}# -e s#@INCLUDEDIR@#${includedir}# ${UNPACKDIR}/lua.pc.in > ${S}/lua.pc
> install -m 0644 ${S}/lua.pc ${D}${libdir}/pkgconfig/
> - rmdir ${D}${datadir}/lua/5.4
> + rmdir ${D}${datadir}/lua/5.5
> rmdir ${D}${datadir}/lua
> }
Maybe use 5.* to avoid having to do this on every upgrade?
Ross
next prev parent reply other threads:[~2026-02-26 13:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 2:46 [PATCH V2] lua: upgrade from 5.4.8 to 5.5.0 Changqing Li
2026-02-26 13:37 ` Ross Burton [this message]
2026-02-27 7:07 ` [OE-core] " Changqing Li
2026-02-27 7:08 ` [PATCH V3] " Changqing Li
2026-03-03 15:16 ` [OE-core] " Ross Burton
2026-03-04 7:23 ` Changqing Li
2026-03-04 17:58 ` Ross Burton
2026-03-05 10:54 ` [PATCH V4] " Changqing Li
2026-03-06 10:18 ` [OE-core] " Mathieu Dubois-Briand
2026-03-09 6:07 ` [PATCH V5] " Changqing Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39D9B021-BF4B-4050-8D22-53C33E84F8C9@arm.com \
--to=ross.burton@arm.com \
--cc=changqing.li@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox