From: Changqing Li <changqing.li@windriver.com>
To: Ross Burton <Ross.Burton@arm.com>
Cc: "openembedded-core@lists.openembedded.org"
<openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH V3] lua: upgrade from 5.4.8 to 5.5.0
Date: Wed, 4 Mar 2026 15:23:12 +0800 [thread overview]
Message-ID: <519f845e-41a2-4cc3-8b8c-ff57b743a0ce@windriver.com> (raw)
In-Reply-To: <FEAC2A3F-4384-4D3C-B9CE-FDA23332604B@arm.com>
[-- Attachment #1: Type: text/plain, Size: 2733 bytes --]
On 3/3/26 23:16, Ross Burton wrote:
> CAUTION: This email comes from a non Wind River email account!
> Do not click links or open attachments unless you recognize the sender and know the content is safe.
>
> Hi,
>
>> On 27 Feb 2026, at 07:08, Changqing Li via lists.openembedded.org<changqing.li=windriver.com@lists.openembedded.org> wrote:
>> Refer [1], PLATS linux-readline is moved, and readline is changed to
>> load dynamically, keep readline as PACKAGECONFIG to allow user to remove
>> readline dependency.
> As is traditional with people using dlopen(), this is now broken…
>
> Lua defaults to dlopen() support being enabled (LUA_USE_DLOPEN is defined on linux) and the readline library is set to libreadline.so<http://libreadline.so/>.
>
> So the PACKAGECONFIG is not doing the right thing anymore: having readline in the sysroot doesn’t change the build, and has no impact on the runtime packages.
>
> The obvious answer is to change the PACKAGECONFIG to “,,,readline” so that there’s still an option that has the effect of enabling readline in lua, but that also won’t work as the on-disk file isn’t called libreadline.so<http://libreadline.so/> unless you install the -dev package…. This means we should also set LUA_READLINELIB to "libreadline.so.8”.
>
> Bonus points for adding readline as a build dependency and looking up what the libreadline.so<http://libreadline.so/> symlink resolves to, but I don’t expect the readline soname to change in the near future so this can be considered overkill.
Hi, Ross
Thanks for pointing out this. How about we just install -dev packages?
so that we don't need a local patch to set LUA_READLINELIB to
"libreadline.so.8”. And
in this way, we are align with lua upstream expected (if readline-dev
installed, readline is used, otherwise, not use readline)
Here is the diff based on V3:
PACKAGECONFIG ??= "readline"
-PACKAGECONFIG[readline] = ",,readline"
+PACKAGECONFIG[readline] = ",,,readline-dev"
TARGET_CC_ARCH += " -fPIC ${LDFLAGS}"
EXTRA_OEMAKE = "'CC=${CC} -fPIC' 'MYCFLAGS=${CFLAGS} -fPIC'
MYLDFLAGS='${LDFLAGS}' 'AR=ar rcD' 'RANLIB=ranlib -D'"
@@ -64,3 +64,5 @@ BBCLASSEXTEND = "native nativesdk"
inherit multilib_script
MULTILIB_SCRIPTS = "${PN}-dev:${includedir}/luaconf.h"
+
+INSANE_SKIP:${PN} += "dev-deps"
With V3 patch:
root@qemux86-64:~# lua -i -W
Lua 5.5.0 Copyright (C) 1994-2025 Lua.org, PUC-Rio
Lua warning: library 'libreadline.so' not found
>
With the V4 patch:
root@qemux86-64:/usr/lib# lua -i -W
Lua 5.5.0 Copyright (C) 1994-2025 Lua.org, PUC-Rio
>
if you think this is ok, I will send a V4 like this.
Regards
Changqing
>
> Ross
[-- Attachment #2: Type: text/html, Size: 4308 bytes --]
next prev parent reply other threads:[~2026-03-04 7:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-24 2:46 [PATCH V2] lua: upgrade from 5.4.8 to 5.5.0 Changqing Li
2026-02-26 13:37 ` [OE-core] " Ross Burton
2026-02-27 7:07 ` Changqing Li
2026-02-27 7:08 ` [PATCH V3] " Changqing Li
2026-03-03 15:16 ` [OE-core] " Ross Burton
2026-03-04 7:23 ` Changqing Li [this message]
2026-03-04 17:58 ` Ross Burton
2026-03-05 10:54 ` [PATCH V4] " Changqing Li
2026-03-06 10:18 ` [OE-core] " Mathieu Dubois-Briand
2026-03-09 6:07 ` [PATCH V5] " Changqing Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=519f845e-41a2-4cc3-8b8c-ff57b743a0ce@windriver.com \
--to=changqing.li@windriver.com \
--cc=Ross.Burton@arm.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox