Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Alexander Kanavin <alex.kanavin@gmail.com>,
	 openembedded-core@lists.openembedded.org
Cc: Alexander Kanavin <alex@linutronix.de>
Subject: Re: [OE-core] [PATCH] rpm: depend on curl-native
Date: Fri, 02 Feb 2024 13:10:34 +0000	[thread overview]
Message-ID: <43529c06d19b5001bbd6938599b796d72d50d8dc.camel@linuxfoundation.org> (raw)
In-Reply-To: <20240202122708.2167891-1-alex@linutronix.de>

On Fri, 2024-02-02 at 13:27 +0100, Alexander Kanavin wrote:
> rpm is searching for curl executable at do_configure time
> and result is non-deterministic without this dependency:
> https://autobuilder.yocto.io/pub/repro-fail/oe-reproducible-20240201-8dcic6ea/packages/diff-html/
> 
> Signed-off-by: Alexander Kanavin <alex@linutronix.de>
> ---
>  meta/recipes-devtools/rpm/rpm_4.19.1.bb | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-devtools/rpm/rpm_4.19.1.bb b/meta/recipes-devtools/rpm/rpm_4.19.1.bb
> index af11dec5ef3..f6d21cb6a4a 100644
> --- a/meta/recipes-devtools/rpm/rpm_4.19.1.bb
> +++ b/meta/recipes-devtools/rpm/rpm_4.19.1.bb
> @@ -48,7 +48,7 @@ SRCREV = "98b301ebb44fb5cabb56fc24bc3aaa437c47c038"
>  
>  S = "${WORKDIR}/git"
>  
> -DEPENDS = "lua libgcrypt file popt xz bzip2 elfutils python3 sqlite3 zstd"
> +DEPENDS = "lua libgcrypt file popt xz bzip2 elfutils python3 sqlite3 zstd curl-native"
>  DEPENDS:append:class-native = " file-replacement-native bzip2-replacement-native"
>  
>  EXTRA_OECMAKE:append:libc-musl = " -DENABLE_NLS=OFF -DENABLE_OPENMP=OFF"

Can we not just tell rpm it is "curl" or "/usr/bin/curl" explicitly?
Adding dependencies increases build times and we really don't want to
if we don't need to.

Cheers,

Richard


  reply	other threads:[~2024-02-02 13:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-02 12:27 [PATCH] rpm: depend on curl-native Alexander Kanavin
2024-02-02 13:10 ` Richard Purdie [this message]
2024-02-02 13:24   ` [OE-core] " Alexander Kanavin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43529c06d19b5001bbd6938599b796d72d50d8dc.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=alex.kanavin@gmail.com \
    --cc=alex@linutronix.de \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox