* [PATCH] rpm: depend on curl-native
@ 2024-02-02 12:27 Alexander Kanavin
2024-02-02 13:10 ` [OE-core] " Richard Purdie
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Kanavin @ 2024-02-02 12:27 UTC (permalink / raw)
To: openembedded-core; +Cc: Alexander Kanavin
rpm is searching for curl executable at do_configure time
and result is non-deterministic without this dependency:
https://autobuilder.yocto.io/pub/repro-fail/oe-reproducible-20240201-8dcic6ea/packages/diff-html/
Signed-off-by: Alexander Kanavin <alex@linutronix.de>
---
meta/recipes-devtools/rpm/rpm_4.19.1.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-devtools/rpm/rpm_4.19.1.bb b/meta/recipes-devtools/rpm/rpm_4.19.1.bb
index af11dec5ef3..f6d21cb6a4a 100644
--- a/meta/recipes-devtools/rpm/rpm_4.19.1.bb
+++ b/meta/recipes-devtools/rpm/rpm_4.19.1.bb
@@ -48,7 +48,7 @@ SRCREV = "98b301ebb44fb5cabb56fc24bc3aaa437c47c038"
S = "${WORKDIR}/git"
-DEPENDS = "lua libgcrypt file popt xz bzip2 elfutils python3 sqlite3 zstd"
+DEPENDS = "lua libgcrypt file popt xz bzip2 elfutils python3 sqlite3 zstd curl-native"
DEPENDS:append:class-native = " file-replacement-native bzip2-replacement-native"
EXTRA_OECMAKE:append:libc-musl = " -DENABLE_NLS=OFF -DENABLE_OPENMP=OFF"
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [OE-core] [PATCH] rpm: depend on curl-native
2024-02-02 12:27 [PATCH] rpm: depend on curl-native Alexander Kanavin
@ 2024-02-02 13:10 ` Richard Purdie
2024-02-02 13:24 ` Alexander Kanavin
0 siblings, 1 reply; 3+ messages in thread
From: Richard Purdie @ 2024-02-02 13:10 UTC (permalink / raw)
To: Alexander Kanavin, openembedded-core; +Cc: Alexander Kanavin
On Fri, 2024-02-02 at 13:27 +0100, Alexander Kanavin wrote:
> rpm is searching for curl executable at do_configure time
> and result is non-deterministic without this dependency:
> https://autobuilder.yocto.io/pub/repro-fail/oe-reproducible-20240201-8dcic6ea/packages/diff-html/
>
> Signed-off-by: Alexander Kanavin <alex@linutronix.de>
> ---
> meta/recipes-devtools/rpm/rpm_4.19.1.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-devtools/rpm/rpm_4.19.1.bb b/meta/recipes-devtools/rpm/rpm_4.19.1.bb
> index af11dec5ef3..f6d21cb6a4a 100644
> --- a/meta/recipes-devtools/rpm/rpm_4.19.1.bb
> +++ b/meta/recipes-devtools/rpm/rpm_4.19.1.bb
> @@ -48,7 +48,7 @@ SRCREV = "98b301ebb44fb5cabb56fc24bc3aaa437c47c038"
>
> S = "${WORKDIR}/git"
>
> -DEPENDS = "lua libgcrypt file popt xz bzip2 elfutils python3 sqlite3 zstd"
> +DEPENDS = "lua libgcrypt file popt xz bzip2 elfutils python3 sqlite3 zstd curl-native"
> DEPENDS:append:class-native = " file-replacement-native bzip2-replacement-native"
>
> EXTRA_OECMAKE:append:libc-musl = " -DENABLE_NLS=OFF -DENABLE_OPENMP=OFF"
Can we not just tell rpm it is "curl" or "/usr/bin/curl" explicitly?
Adding dependencies increases build times and we really don't want to
if we don't need to.
Cheers,
Richard
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [OE-core] [PATCH] rpm: depend on curl-native
2024-02-02 13:10 ` [OE-core] " Richard Purdie
@ 2024-02-02 13:24 ` Alexander Kanavin
0 siblings, 0 replies; 3+ messages in thread
From: Alexander Kanavin @ 2024-02-02 13:24 UTC (permalink / raw)
To: Richard Purdie; +Cc: openembedded-core, Alexander Kanavin
On Fri, 2 Feb 2024 at 14:10, Richard Purdie
<richard.purdie@linuxfoundation.org> wrote:
> Can we not just tell rpm it is "curl" or "/usr/bin/curl" explicitly?
> Adding dependencies increases build times and we really don't want to
> if we don't need to.
Yes, I've send a patch for that now.
Alex
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-02 13:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-02 12:27 [PATCH] rpm: depend on curl-native Alexander Kanavin
2024-02-02 13:10 ` [OE-core] " Richard Purdie
2024-02-02 13:24 ` Alexander Kanavin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox