Re: [OE-core] [PATCH] module.bbclass: check whether CONFIG_MODULES set

[Richard Purdie <richard.purdie@linuxfoundation.org>]

On Thu, 2026-02-05 at 17:08 +0800, Kai wrote:
>  On 2/4/26 23:53, Richard Purdie wrote:
>  I agree the warn conditional isn't quite right. I think it should
> > be:
> > 
> > if [ CONFIG_MODULES not set in config ];
> >     bberror Broken config, CONFIG_MODULES not set
> >     exit 1
> > fi
> > 
> > so it is basically a sanity test that the config is valid.
> > 
> > I'm a bit worried about what I'm missing though :/
> >  
>  The original problem is kernel config_modules is disabled, then
> external modules such as lttng-modules can't be built.
>  
> Recipe lttng-tools RRECOMMENDS on lttng-modules. If install lttng-
> tools into image, it fails to build lttng-modules.
>  
> Kernel config CONFIG_MODULES couldn't be checked whether enabled or
> disabled after bitbake parse. Then there is no
> chance to remove lttng-module from the dependencies. That why I check
> the config during the do_compile and do_install
> with bbnote and generate empty rpm package.

That is a bit different to the problem I thought this was addressing (I
was coming from the rust patches angle).

In that case we probably need to have something like "kernel-modules"
in KERNEL_FEATURES and we check in the lttng-tools recipes if kernel-
modules are in KERNEL_FEATURES. The kernel itself can then error if the
feature is selected but not configured and lttng-modules can fail to
parse with an error if it isn't set?

lttng-tools is not useful without the module support.

Cheers,

Richard