public inbox for openembedded-core@lists.openembedded.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: bruce.ashfield@gmail.com, kai.kang@windriver.com
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH] module.bbclass: check whether CONFIG_MODULES set
Date: Wed, 04 Feb 2026 13:58:04 +0000	[thread overview]
Message-ID: <71fa18fd1ae7612c9d3f8161c6aeb2575d22e280.camel@linuxfoundation.org> (raw)
In-Reply-To: <CADkTA4PZ9df8xCge6F+m4M02OTXbiOhYJ7S7hPvze95ah5BWDQ@mail.gmail.com>

On Wed, 2026-02-04 at 08:46 -0500, Bruce Ashfield via lists.openembedded.org wrote:
> 
> 
> On Tue, Feb 3, 2026 at 9:09 PM Kai Kang via lists.openembedded.org <kai.kang=windriver.com@lists.openembedded.org> wrote:
> > From: Kai Kang <kai.kang@windriver.com>
> > 
> > Check whether kernel config CONFIG_MODULES set or not before do_compile
> > and do_install in module.bbclass. If not set, it cannot build and
> > install external modules.
> > 
> 
> 
> This isn't the place to do that check.
> 
> If modules are disabled get modules_do_compile out of the tasks.

Does it make sense to have something including module.bbclass which
doesn't have CONFIG_MODULES set?

Cheers,

Richard


  reply	other threads:[~2026-02-04 13:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-04  2:09 [PATCH] module.bbclass: check whether CONFIG_MODULES set kai.kang
2026-02-04 13:46 ` [OE-core] " Bruce Ashfield
2026-02-04 13:58   ` Richard Purdie [this message]
2026-02-04 14:02     ` Bruce Ashfield
2026-02-04 14:05       ` Richard Purdie
2026-02-04 14:10         ` Bruce Ashfield
2026-02-04 15:53           ` Richard Purdie
2026-02-05  9:08             ` Kai
2026-02-05 12:58               ` Bruce Ashfield
2026-02-05 14:49               ` Richard Purdie
2026-02-12  6:48                 ` Kai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71fa18fd1ae7612c9d3f8161c6aeb2575d22e280.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bruce.ashfield@gmail.com \
    --cc=kai.kang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox