* [PATCH 2/6] gstreamer1.0-plugin-good: Update packageconfigs
2018-07-17 9:35 [PATCH 1/6] gstreamer1.0-plugin-base: Update packageconfigs Carlos Rafael Giani
@ 2018-07-17 9:35 ` Carlos Rafael Giani
2018-07-17 9:50 ` Martin Jansa
2018-07-17 9:35 ` [PATCH 3/6] gstreamer1.0-plugin-bad: " Carlos Rafael Giani
` (5 subsequent siblings)
6 siblings, 1 reply; 17+ messages in thread
From: Carlos Rafael Giani @ 2018-07-17 9:35 UTC (permalink / raw)
To: openembedded-core
* Always enable bz2 and zlib, since these are part of oe-core, and
dependencies that are in oe-core can be always enabled
* There is no twolame recipe in oe-core or in meta-openembedded, so
disable it
* Reorder the packageconfigs alphabetically
Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
---
.../gstreamer1.0-plugins-good_1.14.1.bb | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.14.1.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.14.1.bb
index 36eb3107ae..baeb19ddfe 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.14.1.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.14.1.bb
@@ -18,7 +18,7 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343 \
file://common/coverage/coverage-report.pl;beginline=2;endline=17;md5=a4e1830fce078028c8f0974161272607 \
file://gst/replaygain/rganalysis.c;beginline=1;endline=23;md5=b60ebefd5b2f5a8e0cab6bfee391a5fe"
-DEPENDS += "gstreamer1.0-plugins-base libcap"
+DEPENDS += "gstreamer1.0-plugins-base libcap zlib bzip2"
RPROVIDES_${PN}-pulseaudio += "${PN}-pulse"
RPROVIDES_${PN}-soup += "${PN}-souphttpsrc"
@@ -28,7 +28,7 @@ PACKAGECONFIG ??= " \
${GSTREAMER_ORC} \
${@bb.utils.filter('DISTRO_FEATURES', 'pulseaudio x11', d)} \
${@bb.utils.contains_any('DISTRO_FEATURES', d.getVar('GTK3DISTROFEATURES'), 'gtk', '', d)} \
- cairo flac gdk-pixbuf gudev jpeg libpng soup speex taglib v4l2 bz2 zlib mpg123 lame \
+ cairo flac gdk-pixbuf gudev jpeg lame libpng mpg123 soup speex taglib v4l2 \
"
X11DEPENDS = "virtual/libx11 libsm libxrender libxfixes libxdamage"
@@ -37,11 +37,14 @@ PACKAGECONFIG[cairo] = "--enable-cairo,--disable-cairo,cairo"
PACKAGECONFIG[dv1394] = "--enable-dv1394,--disable-dv1394,libiec61883 libavc1394 libraw1394"
PACKAGECONFIG[flac] = "--enable-flac,--disable-flac,flac"
PACKAGECONFIG[gdk-pixbuf] = "--enable-gdk_pixbuf,--disable-gdk_pixbuf,gdk-pixbuf"
+PACKAGECONFIG[gtk] = "--enable-gtk3,--disable-gtk3,gtk+3"
PACKAGECONFIG[gudev] = "--with-gudev,--without-gudev,libgudev"
PACKAGECONFIG[jack] = "--enable-jack,--disable-jack,jack"
PACKAGECONFIG[jpeg] = "--enable-jpeg,--disable-jpeg,jpeg"
+PACKAGECONFIG[lame] = "--enable-lame,--disable-lame,lame"
PACKAGECONFIG[libpng] = "--enable-libpng,--disable-libpng,libpng"
PACKAGECONFIG[libv4l2] = "--with-libv4l2,--without-libv4l2,v4l-utils"
+PACKAGECONFIG[mpg123] = "--enable-mpg123,--disable-mpg123,mpg123"
PACKAGECONFIG[pulseaudio] = "--enable-pulse,--disable-pulse,pulseaudio"
PACKAGECONFIG[soup] = "--enable-soup,--disable-soup,libsoup-2.4"
PACKAGECONFIG[speex] = "--enable-speex,--disable-speex,speex"
@@ -50,11 +53,6 @@ PACKAGECONFIG[v4l2] = "--enable-gst_v4l2 --enable-v4l2-probe,--disable-gst
PACKAGECONFIG[vpx] = "--enable-vpx,--disable-vpx,libvpx"
PACKAGECONFIG[wavpack] = "--enable-wavpack,--disable-wavpack,wavpack"
PACKAGECONFIG[x11] = "--enable-x,--disable-x,${X11DEPENDS}"
-PACKAGECONFIG[bz2] = "--enable-bz2,--disable-bz2,bzip2"
-PACKAGECONFIG[zlib] = "--enable-zlib,--disable-zlib,zlib"
-PACKAGECONFIG[lame] = "--enable-lame,--disable-lame,lame"
-PACKAGECONFIG[mpg123] = "--enable-mpg123,--disable-mpg123,mpg123"
-PACKAGECONFIG[gtk] = "--enable-gtk3,--disable-gtk3,gtk+3"
# qt5 support is disabled, because it is not present in OE core, and requires more work than
# just adding a packageconfig (it requires access to moc, uic, rcc, and qmake paths).
@@ -62,7 +60,9 @@ PACKAGECONFIG[gtk] = "--enable-gtk3,--disable-gtk3,gtk+3"
# in a gstreamer1.0-plugins-good bbappend).
EXTRA_OECONF += " \
+ --enable-bz2 \
--enable-oss \
+ --enable-zlib \
--disable-aalib \
--disable-aalibtest \
--disable-directsound \
@@ -71,9 +71,10 @@ EXTRA_OECONF += " \
--disable-oss4 \
--disable-osx_audio \
--disable-osx_video \
+ --disable-qt \
--disable-shout2 \
+ --disable-twolame \
--disable-waveform \
- --disable-qt \
"
FILES_${PN}-equalizer += "${datadir}/gstreamer-1.0/presets/*.prs"
--
2.17.1
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH 2/6] gstreamer1.0-plugin-good: Update packageconfigs
2018-07-17 9:35 ` [PATCH 2/6] gstreamer1.0-plugin-good: " Carlos Rafael Giani
@ 2018-07-17 9:50 ` Martin Jansa
2018-07-17 9:53 ` Carlos Rafael Giani
0 siblings, 1 reply; 17+ messages in thread
From: Martin Jansa @ 2018-07-17 9:50 UTC (permalink / raw)
To: Carlos Rafael Giani; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 4965 bytes --]
Why do you remove bz2 and zlib PACKAGECONFIGs instead of just enabling them
by default?
On Tue, Jul 17, 2018 at 11:45 AM Carlos Rafael Giani <dv@pseudoterminal.org>
wrote:
> * Always enable bz2 and zlib, since these are part of oe-core, and
> dependencies that are in oe-core can be always enabled
> * There is no twolame recipe in oe-core or in meta-openembedded, so
> disable it
> * Reorder the packageconfigs alphabetically
>
> Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
> ---
> .../gstreamer1.0-plugins-good_1.14.1.bb | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/meta/recipes-multimedia/gstreamer/
> gstreamer1.0-plugins-good_1.14.1.bb b/meta/recipes-multimedia/gstreamer/
> gstreamer1.0-plugins-good_1.14.1.bb
> index 36eb3107ae..baeb19ddfe 100644
> --- a/meta/recipes-multimedia/gstreamer/
> gstreamer1.0-plugins-good_1.14.1.bb
> +++ b/meta/recipes-multimedia/gstreamer/
> gstreamer1.0-plugins-good_1.14.1.bb
> @@ -18,7 +18,7 @@ LIC_FILES_CHKSUM =
> "file://COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343 \
> file://common/coverage/coverage-report.pl;beginline=2;endline=17;md5=a4e1830fce078028c8f0974161272607
> \
>
> file://gst/replaygain/rganalysis.c;beginline=1;endline=23;md5=b60ebefd5b2f5a8e0cab6bfee391a5fe"
>
> -DEPENDS += "gstreamer1.0-plugins-base libcap"
> +DEPENDS += "gstreamer1.0-plugins-base libcap zlib bzip2"
> RPROVIDES_${PN}-pulseaudio += "${PN}-pulse"
> RPROVIDES_${PN}-soup += "${PN}-souphttpsrc"
>
> @@ -28,7 +28,7 @@ PACKAGECONFIG ??= " \
> ${GSTREAMER_ORC} \
> ${@bb.utils.filter('DISTRO_FEATURES', 'pulseaudio x11', d)} \
> ${@bb.utils.contains_any('DISTRO_FEATURES',
> d.getVar('GTK3DISTROFEATURES'), 'gtk', '', d)} \
> - cairo flac gdk-pixbuf gudev jpeg libpng soup speex taglib v4l2 bz2
> zlib mpg123 lame \
> + cairo flac gdk-pixbuf gudev jpeg lame libpng mpg123 soup speex taglib
> v4l2 \
> "
>
> X11DEPENDS = "virtual/libx11 libsm libxrender libxfixes libxdamage"
> @@ -37,11 +37,14 @@ PACKAGECONFIG[cairo] =
> "--enable-cairo,--disable-cairo,cairo"
> PACKAGECONFIG[dv1394] = "--enable-dv1394,--disable-dv1394,libiec61883
> libavc1394 libraw1394"
> PACKAGECONFIG[flac] = "--enable-flac,--disable-flac,flac"
> PACKAGECONFIG[gdk-pixbuf] =
> "--enable-gdk_pixbuf,--disable-gdk_pixbuf,gdk-pixbuf"
> +PACKAGECONFIG[gtk] = "--enable-gtk3,--disable-gtk3,gtk+3"
> PACKAGECONFIG[gudev] = "--with-gudev,--without-gudev,libgudev"
> PACKAGECONFIG[jack] = "--enable-jack,--disable-jack,jack"
> PACKAGECONFIG[jpeg] = "--enable-jpeg,--disable-jpeg,jpeg"
> +PACKAGECONFIG[lame] = "--enable-lame,--disable-lame,lame"
> PACKAGECONFIG[libpng] = "--enable-libpng,--disable-libpng,libpng"
> PACKAGECONFIG[libv4l2] = "--with-libv4l2,--without-libv4l2,v4l-utils"
> +PACKAGECONFIG[mpg123] = "--enable-mpg123,--disable-mpg123,mpg123"
> PACKAGECONFIG[pulseaudio] = "--enable-pulse,--disable-pulse,pulseaudio"
> PACKAGECONFIG[soup] = "--enable-soup,--disable-soup,libsoup-2.4"
> PACKAGECONFIG[speex] = "--enable-speex,--disable-speex,speex"
> @@ -50,11 +53,6 @@ PACKAGECONFIG[v4l2] = "--enable-gst_v4l2
> --enable-v4l2-probe,--disable-gst
> PACKAGECONFIG[vpx] = "--enable-vpx,--disable-vpx,libvpx"
> PACKAGECONFIG[wavpack] = "--enable-wavpack,--disable-wavpack,wavpack"
> PACKAGECONFIG[x11] = "--enable-x,--disable-x,${X11DEPENDS}"
> -PACKAGECONFIG[bz2] = "--enable-bz2,--disable-bz2,bzip2"
> -PACKAGECONFIG[zlib] = "--enable-zlib,--disable-zlib,zlib"
> -PACKAGECONFIG[lame] = "--enable-lame,--disable-lame,lame"
> -PACKAGECONFIG[mpg123] = "--enable-mpg123,--disable-mpg123,mpg123"
> -PACKAGECONFIG[gtk] = "--enable-gtk3,--disable-gtk3,gtk+3"
>
> # qt5 support is disabled, because it is not present in OE core, and
> requires more work than
> # just adding a packageconfig (it requires access to moc, uic, rcc, and
> qmake paths).
> @@ -62,7 +60,9 @@ PACKAGECONFIG[gtk] =
> "--enable-gtk3,--disable-gtk3,gtk+3"
> # in a gstreamer1.0-plugins-good bbappend).
>
> EXTRA_OECONF += " \
> + --enable-bz2 \
> --enable-oss \
> + --enable-zlib \
> --disable-aalib \
> --disable-aalibtest \
> --disable-directsound \
> @@ -71,9 +71,10 @@ EXTRA_OECONF += " \
> --disable-oss4 \
> --disable-osx_audio \
> --disable-osx_video \
> + --disable-qt \
> --disable-shout2 \
> + --disable-twolame \
> --disable-waveform \
> - --disable-qt \
> "
>
> FILES_${PN}-equalizer += "${datadir}/gstreamer-1.0/presets/*.prs"
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
[-- Attachment #2: Type: text/html, Size: 6707 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH 2/6] gstreamer1.0-plugin-good: Update packageconfigs
2018-07-17 9:50 ` Martin Jansa
@ 2018-07-17 9:53 ` Carlos Rafael Giani
2018-07-17 9:57 ` Martin Jansa
0 siblings, 1 reply; 17+ messages in thread
From: Carlos Rafael Giani @ 2018-07-17 9:53 UTC (permalink / raw)
To: Martin Jansa; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 6256 bytes --]
The zlib and bz2 switches enable zlib and bzip2 support in the qtdemux
and matroska plugins. They do not enable some sort of standalone
bz2/zlib plugins. Is there any reason why these shouldn't be enabled always?
On 2018-07-17 11:50, Martin Jansa wrote:
> Why do you remove bz2 and zlib PACKAGECONFIGs instead of just enabling
> them by default?
>
> On Tue, Jul 17, 2018 at 11:45 AM Carlos Rafael Giani
> <dv@pseudoterminal.org <mailto:dv@pseudoterminal.org>> wrote:
>
> * Always enable bz2 and zlib, since these are part of oe-core, and
> dependencies that are in oe-core can be always enabled
> * There is no twolame recipe in oe-core or in meta-openembedded, so
> disable it
> * Reorder the packageconfigs alphabetically
>
> Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org
> <mailto:dv@pseudoterminal.org>>
> ---
> .../gstreamer1.0-plugins-good_1.14.1.bb
> <http://gstreamer1.0-plugins-good_1.14.1.bb> | 17
> +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
> diff --git
> a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.14.1.bb
> <http://gstreamer1.0-plugins-good_1.14.1.bb>
> b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.14.1.bb
> <http://gstreamer1.0-plugins-good_1.14.1.bb>
> index 36eb3107ae..baeb19ddfe 100644
> ---
> a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.14.1.bb
> <http://gstreamer1.0-plugins-good_1.14.1.bb>
> +++
> b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.14.1.bb
> <http://gstreamer1.0-plugins-good_1.14.1.bb>
> @@ -18,7 +18,7 @@ LIC_FILES_CHKSUM =
> "file://COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343 \
> file://common/coverage/coverage-report.pl
> <http://coverage-report.pl>;beginline=2;endline=17;md5=a4e1830fce078028c8f0974161272607
> \
> file://gst/replaygain/rganalysis.c;beginline=1;endline=23;md5=b60ebefd5b2f5a8e0cab6bfee391a5fe"
>
> -DEPENDS += "gstreamer1.0-plugins-base libcap"
> +DEPENDS += "gstreamer1.0-plugins-base libcap zlib bzip2"
> RPROVIDES_${PN}-pulseaudio += "${PN}-pulse"
> RPROVIDES_${PN}-soup += "${PN}-souphttpsrc"
>
> @@ -28,7 +28,7 @@ PACKAGECONFIG ??= " \
> ${GSTREAMER_ORC} \
> ${@bb.utils.filter('DISTRO_FEATURES', 'pulseaudio x11', d)} \
> ${@bb.utils.contains_any('DISTRO_FEATURES',
> d.getVar('GTK3DISTROFEATURES'), 'gtk', '', d)} \
> - cairo flac gdk-pixbuf gudev jpeg libpng soup speex taglib
> v4l2 bz2 zlib mpg123 lame \
> + cairo flac gdk-pixbuf gudev jpeg lame libpng mpg123 soup
> speex taglib v4l2 \
> "
>
> X11DEPENDS = "virtual/libx11 libsm libxrender libxfixes libxdamage"
> @@ -37,11 +37,14 @@ PACKAGECONFIG[cairo] =
> "--enable-cairo,--disable-cairo,cairo"
> PACKAGECONFIG[dv1394] =
> "--enable-dv1394,--disable-dv1394,libiec61883 libavc1394 libraw1394"
> PACKAGECONFIG[flac] = "--enable-flac,--disable-flac,flac"
> PACKAGECONFIG[gdk-pixbuf] =
> "--enable-gdk_pixbuf,--disable-gdk_pixbuf,gdk-pixbuf"
> +PACKAGECONFIG[gtk] = "--enable-gtk3,--disable-gtk3,gtk+3"
> PACKAGECONFIG[gudev] = "--with-gudev,--without-gudev,libgudev"
> PACKAGECONFIG[jack] = "--enable-jack,--disable-jack,jack"
> PACKAGECONFIG[jpeg] = "--enable-jpeg,--disable-jpeg,jpeg"
> +PACKAGECONFIG[lame] = "--enable-lame,--disable-lame,lame"
> PACKAGECONFIG[libpng] = "--enable-libpng,--disable-libpng,libpng"
> PACKAGECONFIG[libv4l2] =
> "--with-libv4l2,--without-libv4l2,v4l-utils"
> +PACKAGECONFIG[mpg123] = "--enable-mpg123,--disable-mpg123,mpg123"
> PACKAGECONFIG[pulseaudio] =
> "--enable-pulse,--disable-pulse,pulseaudio"
> PACKAGECONFIG[soup] =
> "--enable-soup,--disable-soup,libsoup-2.4"
> PACKAGECONFIG[speex] = "--enable-speex,--disable-speex,speex"
> @@ -50,11 +53,6 @@ PACKAGECONFIG[v4l2] = "--enable-gst_v4l2
> --enable-v4l2-probe,--disable-gst
> PACKAGECONFIG[vpx] = "--enable-vpx,--disable-vpx,libvpx"
> PACKAGECONFIG[wavpack] =
> "--enable-wavpack,--disable-wavpack,wavpack"
> PACKAGECONFIG[x11] = "--enable-x,--disable-x,${X11DEPENDS}"
> -PACKAGECONFIG[bz2] = "--enable-bz2,--disable-bz2,bzip2"
> -PACKAGECONFIG[zlib] = "--enable-zlib,--disable-zlib,zlib"
> -PACKAGECONFIG[lame] = "--enable-lame,--disable-lame,lame"
> -PACKAGECONFIG[mpg123] = "--enable-mpg123,--disable-mpg123,mpg123"
> -PACKAGECONFIG[gtk] = "--enable-gtk3,--disable-gtk3,gtk+3"
>
> # qt5 support is disabled, because it is not present in OE core,
> and requires more work than
> # just adding a packageconfig (it requires access to moc, uic,
> rcc, and qmake paths).
> @@ -62,7 +60,9 @@ PACKAGECONFIG[gtk] =
> "--enable-gtk3,--disable-gtk3,gtk+3"
> # in a gstreamer1.0-plugins-good bbappend).
>
> EXTRA_OECONF += " \
> + --enable-bz2 \
> --enable-oss \
> + --enable-zlib \
> --disable-aalib \
> --disable-aalibtest \
> --disable-directsound \
> @@ -71,9 +71,10 @@ EXTRA_OECONF += " \
> --disable-oss4 \
> --disable-osx_audio \
> --disable-osx_video \
> + --disable-qt \
> --disable-shout2 \
> + --disable-twolame \
> --disable-waveform \
> - --disable-qt \
> "
>
> FILES_${PN}-equalizer += "${datadir}/gstreamer-1.0/presets/*.prs"
> --
> 2.17.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> <mailto:Openembedded-core@lists.openembedded.org>
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
[-- Attachment #2: Type: text/html, Size: 9245 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH 2/6] gstreamer1.0-plugin-good: Update packageconfigs
2018-07-17 9:53 ` Carlos Rafael Giani
@ 2018-07-17 9:57 ` Martin Jansa
2018-07-17 10:00 ` Carlos Rafael Giani
0 siblings, 1 reply; 17+ messages in thread
From: Martin Jansa @ 2018-07-17 9:57 UTC (permalink / raw)
To: Carlos Rafael Giani; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 5590 bytes --]
The PACKAGECONFIG for them is already there, why do you need to remove the
option for someone to disable the support if they want?
On Tue, Jul 17, 2018 at 11:54 AM Carlos Rafael Giani <dv@pseudoterminal.org>
wrote:
> The zlib and bz2 switches enable zlib and bzip2 support in the qtdemux and
> matroska plugins. They do not enable some sort of standalone bz2/zlib
> plugins. Is there any reason why these shouldn't be enabled always?
>
> On 2018-07-17 11:50, Martin Jansa wrote:
>
> Why do you remove bz2 and zlib PACKAGECONFIGs instead of just enabling
> them by default?
>
> On Tue, Jul 17, 2018 at 11:45 AM Carlos Rafael Giani <
> dv@pseudoterminal.org> wrote:
>
>> * Always enable bz2 and zlib, since these are part of oe-core, and
>> dependencies that are in oe-core can be always enabled
>> * There is no twolame recipe in oe-core or in meta-openembedded, so
>> disable it
>> * Reorder the packageconfigs alphabetically
>>
>> Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
>> ---
>> .../gstreamer1.0-plugins-good_1.14.1.bb | 17 +++++++++--------
>> 1 file changed, 9 insertions(+), 8 deletions(-)
>>
>> diff --git a/meta/recipes-multimedia/gstreamer/
>> gstreamer1.0-plugins-good_1.14.1.bb b/meta/recipes-multimedia/gstreamer/
>> gstreamer1.0-plugins-good_1.14.1.bb
>> index 36eb3107ae..baeb19ddfe 100644
>> --- a/meta/recipes-multimedia/gstreamer/
>> gstreamer1.0-plugins-good_1.14.1.bb
>> +++ b/meta/recipes-multimedia/gstreamer/
>> gstreamer1.0-plugins-good_1.14.1.bb
>> @@ -18,7 +18,7 @@ LIC_FILES_CHKSUM = "
>> file://COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343 \
>> file://common/coverage/coverage-report.pl;beginline=2;endline=17;md5=a4e1830fce078028c8f0974161272607
>> \
>>
>> file://gst/replaygain/rganalysis.c;beginline=1;endline=23;md5=b60ebefd5b2f5a8e0cab6bfee391a5fe
>> "
>>
>> -DEPENDS += "gstreamer1.0-plugins-base libcap"
>> +DEPENDS += "gstreamer1.0-plugins-base libcap zlib bzip2"
>> RPROVIDES_${PN}-pulseaudio += "${PN}-pulse"
>> RPROVIDES_${PN}-soup += "${PN}-souphttpsrc"
>>
>> @@ -28,7 +28,7 @@ PACKAGECONFIG ??= " \
>> ${GSTREAMER_ORC} \
>> ${@bb.utils.filter('DISTRO_FEATURES', 'pulseaudio x11', d)} \
>> ${@bb.utils.contains_any('DISTRO_FEATURES',
>> d.getVar('GTK3DISTROFEATURES'), 'gtk', '', d)} \
>> - cairo flac gdk-pixbuf gudev jpeg libpng soup speex taglib v4l2 bz2
>> zlib mpg123 lame \
>> + cairo flac gdk-pixbuf gudev jpeg lame libpng mpg123 soup speex
>> taglib v4l2 \
>> "
>>
>> X11DEPENDS = "virtual/libx11 libsm libxrender libxfixes libxdamage"
>> @@ -37,11 +37,14 @@ PACKAGECONFIG[cairo] =
>> "--enable-cairo,--disable-cairo,cairo"
>> PACKAGECONFIG[dv1394] =
>> "--enable-dv1394,--disable-dv1394,libiec61883 libavc1394 libraw1394"
>> PACKAGECONFIG[flac] = "--enable-flac,--disable-flac,flac"
>> PACKAGECONFIG[gdk-pixbuf] =
>> "--enable-gdk_pixbuf,--disable-gdk_pixbuf,gdk-pixbuf"
>> +PACKAGECONFIG[gtk] = "--enable-gtk3,--disable-gtk3,gtk+3"
>> PACKAGECONFIG[gudev] = "--with-gudev,--without-gudev,libgudev"
>> PACKAGECONFIG[jack] = "--enable-jack,--disable-jack,jack"
>> PACKAGECONFIG[jpeg] = "--enable-jpeg,--disable-jpeg,jpeg"
>> +PACKAGECONFIG[lame] = "--enable-lame,--disable-lame,lame"
>> PACKAGECONFIG[libpng] = "--enable-libpng,--disable-libpng,libpng"
>> PACKAGECONFIG[libv4l2] = "--with-libv4l2,--without-libv4l2,v4l-utils"
>> +PACKAGECONFIG[mpg123] = "--enable-mpg123,--disable-mpg123,mpg123"
>> PACKAGECONFIG[pulseaudio] = "--enable-pulse,--disable-pulse,pulseaudio"
>> PACKAGECONFIG[soup] = "--enable-soup,--disable-soup,libsoup-2.4"
>> PACKAGECONFIG[speex] = "--enable-speex,--disable-speex,speex"
>> @@ -50,11 +53,6 @@ PACKAGECONFIG[v4l2] = "--enable-gst_v4l2
>> --enable-v4l2-probe,--disable-gst
>> PACKAGECONFIG[vpx] = "--enable-vpx,--disable-vpx,libvpx"
>> PACKAGECONFIG[wavpack] = "--enable-wavpack,--disable-wavpack,wavpack"
>> PACKAGECONFIG[x11] = "--enable-x,--disable-x,${X11DEPENDS}"
>> -PACKAGECONFIG[bz2] = "--enable-bz2,--disable-bz2,bzip2"
>> -PACKAGECONFIG[zlib] = "--enable-zlib,--disable-zlib,zlib"
>> -PACKAGECONFIG[lame] = "--enable-lame,--disable-lame,lame"
>> -PACKAGECONFIG[mpg123] = "--enable-mpg123,--disable-mpg123,mpg123"
>> -PACKAGECONFIG[gtk] = "--enable-gtk3,--disable-gtk3,gtk+3"
>>
>> # qt5 support is disabled, because it is not present in OE core, and
>> requires more work than
>> # just adding a packageconfig (it requires access to moc, uic, rcc, and
>> qmake paths).
>> @@ -62,7 +60,9 @@ PACKAGECONFIG[gtk] =
>> "--enable-gtk3,--disable-gtk3,gtk+3"
>> # in a gstreamer1.0-plugins-good bbappend).
>>
>> EXTRA_OECONF += " \
>> + --enable-bz2 \
>> --enable-oss \
>> + --enable-zlib \
>> --disable-aalib \
>> --disable-aalibtest \
>> --disable-directsound \
>> @@ -71,9 +71,10 @@ EXTRA_OECONF += " \
>> --disable-oss4 \
>> --disable-osx_audio \
>> --disable-osx_video \
>> + --disable-qt \
>> --disable-shout2 \
>> + --disable-twolame \
>> --disable-waveform \
>> - --disable-qt \
>> "
>>
>> FILES_${PN}-equalizer += "${datadir}/gstreamer-1.0/presets/*.prs"
>> --
>> 2.17.1
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>
>
[-- Attachment #2: Type: text/html, Size: 9306 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH 2/6] gstreamer1.0-plugin-good: Update packageconfigs
2018-07-17 9:57 ` Martin Jansa
@ 2018-07-17 10:00 ` Carlos Rafael Giani
2018-07-17 11:17 ` Carlos Rafael Giani
0 siblings, 1 reply; 17+ messages in thread
From: Carlos Rafael Giani @ 2018-07-17 10:00 UTC (permalink / raw)
To: Martin Jansa; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 7626 bytes --]
Is it realistic that anybody would want to disable zlib and bzip2
support in the qtdemux and matroska plugins? Especially since zlib and
bzip2 are essential parts of pretty much _all_ rootfs in existence?
That's why I thought to remove these packageconfigs. I also don't add
packageconfigs for things like ncurses or libdl.
On 2018-07-17 11:57, Martin Jansa wrote:
> The PACKAGECONFIG for them is already there, why do you need to remove
> the option for someone to disable the support if they want?
>
> On Tue, Jul 17, 2018 at 11:54 AM Carlos Rafael Giani
> <dv@pseudoterminal.org <mailto:dv@pseudoterminal.org>> wrote:
>
> The zlib and bz2 switches enable zlib and bzip2 support in the
> qtdemux and matroska plugins. They do not enable some sort of
> standalone bz2/zlib plugins. Is there any reason why these
> shouldn't be enabled always?
>
>
> On 2018-07-17 11:50, Martin Jansa wrote:
>> Why do you remove bz2 and zlib PACKAGECONFIGs instead of just
>> enabling them by default?
>>
>> On Tue, Jul 17, 2018 at 11:45 AM Carlos Rafael Giani
>> <dv@pseudoterminal.org <mailto:dv@pseudoterminal.org>> wrote:
>>
>> * Always enable bz2 and zlib, since these are part of
>> oe-core, and
>> dependencies that are in oe-core can be always enabled
>> * There is no twolame recipe in oe-core or in
>> meta-openembedded, so
>> disable it
>> * Reorder the packageconfigs alphabetically
>>
>> Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org
>> <mailto:dv@pseudoterminal.org>>
>> ---
>> .../gstreamer1.0-plugins-good_1.14.1.bb
>> <http://gstreamer1.0-plugins-good_1.14.1.bb> | 17
>> +++++++++--------
>> 1 file changed, 9 insertions(+), 8 deletions(-)
>>
>> diff --git
>> a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.14.1.bb
>> <http://gstreamer1.0-plugins-good_1.14.1.bb>
>> b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.14.1.bb
>> <http://gstreamer1.0-plugins-good_1.14.1.bb>
>> index 36eb3107ae..baeb19ddfe 100644
>> ---
>> a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.14.1.bb
>> <http://gstreamer1.0-plugins-good_1.14.1.bb>
>> +++
>> b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.14.1.bb
>> <http://gstreamer1.0-plugins-good_1.14.1.bb>
>> @@ -18,7 +18,7 @@ LIC_FILES_CHKSUM =
>> "file://COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343 \
>> file://common/coverage/coverage-report.pl
>> <http://coverage-report.pl>;beginline=2;endline=17;md5=a4e1830fce078028c8f0974161272607
>> \
>> file://gst/replaygain/rganalysis.c;beginline=1;endline=23;md5=b60ebefd5b2f5a8e0cab6bfee391a5fe"
>>
>> -DEPENDS += "gstreamer1.0-plugins-base libcap"
>> +DEPENDS += "gstreamer1.0-plugins-base libcap zlib bzip2"
>> RPROVIDES_${PN}-pulseaudio += "${PN}-pulse"
>> RPROVIDES_${PN}-soup += "${PN}-souphttpsrc"
>>
>> @@ -28,7 +28,7 @@ PACKAGECONFIG ??= " \
>> ${GSTREAMER_ORC} \
>> ${@bb.utils.filter('DISTRO_FEATURES', 'pulseaudio x11',
>> d)} \
>> ${@bb.utils.contains_any('DISTRO_FEATURES',
>> d.getVar('GTK3DISTROFEATURES'), 'gtk', '', d)} \
>> - cairo flac gdk-pixbuf gudev jpeg libpng soup speex
>> taglib v4l2 bz2 zlib mpg123 lame \
>> + cairo flac gdk-pixbuf gudev jpeg lame libpng mpg123 soup
>> speex taglib v4l2 \
>> "
>>
>> X11DEPENDS = "virtual/libx11 libsm libxrender libxfixes
>> libxdamage"
>> @@ -37,11 +37,14 @@ PACKAGECONFIG[cairo] =
>> "--enable-cairo,--disable-cairo,cairo"
>> PACKAGECONFIG[dv1394] =
>> "--enable-dv1394,--disable-dv1394,libiec61883 libavc1394
>> libraw1394"
>> PACKAGECONFIG[flac] = "--enable-flac,--disable-flac,flac"
>> PACKAGECONFIG[gdk-pixbuf] =
>> "--enable-gdk_pixbuf,--disable-gdk_pixbuf,gdk-pixbuf"
>> +PACKAGECONFIG[gtk] = "--enable-gtk3,--disable-gtk3,gtk+3"
>> PACKAGECONFIG[gudev] =
>> "--with-gudev,--without-gudev,libgudev"
>> PACKAGECONFIG[jack] = "--enable-jack,--disable-jack,jack"
>> PACKAGECONFIG[jpeg] = "--enable-jpeg,--disable-jpeg,jpeg"
>> +PACKAGECONFIG[lame] = "--enable-lame,--disable-lame,lame"
>> PACKAGECONFIG[libpng] =
>> "--enable-libpng,--disable-libpng,libpng"
>> PACKAGECONFIG[libv4l2] =
>> "--with-libv4l2,--without-libv4l2,v4l-utils"
>> +PACKAGECONFIG[mpg123] =
>> "--enable-mpg123,--disable-mpg123,mpg123"
>> PACKAGECONFIG[pulseaudio] =
>> "--enable-pulse,--disable-pulse,pulseaudio"
>> PACKAGECONFIG[soup] =
>> "--enable-soup,--disable-soup,libsoup-2.4"
>> PACKAGECONFIG[speex] =
>> "--enable-speex,--disable-speex,speex"
>> @@ -50,11 +53,6 @@ PACKAGECONFIG[v4l2] =
>> "--enable-gst_v4l2 --enable-v4l2-probe,--disable-gst
>> PACKAGECONFIG[vpx] = "--enable-vpx,--disable-vpx,libvpx"
>> PACKAGECONFIG[wavpack] =
>> "--enable-wavpack,--disable-wavpack,wavpack"
>> PACKAGECONFIG[x11] =
>> "--enable-x,--disable-x,${X11DEPENDS}"
>> -PACKAGECONFIG[bz2] = "--enable-bz2,--disable-bz2,bzip2"
>> -PACKAGECONFIG[zlib] = "--enable-zlib,--disable-zlib,zlib"
>> -PACKAGECONFIG[lame] = "--enable-lame,--disable-lame,lame"
>> -PACKAGECONFIG[mpg123] =
>> "--enable-mpg123,--disable-mpg123,mpg123"
>> -PACKAGECONFIG[gtk] = "--enable-gtk3,--disable-gtk3,gtk+3"
>>
>> # qt5 support is disabled, because it is not present in OE
>> core, and requires more work than
>> # just adding a packageconfig (it requires access to moc,
>> uic, rcc, and qmake paths).
>> @@ -62,7 +60,9 @@ PACKAGECONFIG[gtk] =
>> "--enable-gtk3,--disable-gtk3,gtk+3"
>> # in a gstreamer1.0-plugins-good bbappend).
>>
>> EXTRA_OECONF += " \
>> + --enable-bz2 \
>> --enable-oss \
>> + --enable-zlib \
>> --disable-aalib \
>> --disable-aalibtest \
>> --disable-directsound \
>> @@ -71,9 +71,10 @@ EXTRA_OECONF += " \
>> --disable-oss4 \
>> --disable-osx_audio \
>> --disable-osx_video \
>> + --disable-qt \
>> --disable-shout2 \
>> + --disable-twolame \
>> --disable-waveform \
>> - --disable-qt \
>> "
>>
>> FILES_${PN}-equalizer +=
>> "${datadir}/gstreamer-1.0/presets/*.prs"
>> --
>> 2.17.1
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> <mailto:Openembedded-core@lists.openembedded.org>
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>
[-- Attachment #2: Type: text/html, Size: 12214 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH 2/6] gstreamer1.0-plugin-good: Update packageconfigs
2018-07-17 10:00 ` Carlos Rafael Giani
@ 2018-07-17 11:17 ` Carlos Rafael Giani
0 siblings, 0 replies; 17+ messages in thread
From: Carlos Rafael Giani @ 2018-07-17 11:17 UTC (permalink / raw)
To: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 8194 bytes --]
To clarify, I generally do agree with you about keeping things
configurable. I just think that zlib and bzip2 are such basic parts of a
rootfs that packageconfigs for them seem dubious to me. These appear to
me like bogus packageconfigs that don't really configure anything
useful. What do you think?
On 2018-07-17 12:00, Carlos Rafael Giani wrote:
>
> Is it realistic that anybody would want to disable zlib and bzip2
> support in the qtdemux and matroska plugins? Especially since zlib and
> bzip2 are essential parts of pretty much _all_ rootfs in existence?
>
> That's why I thought to remove these packageconfigs. I also don't add
> packageconfigs for things like ncurses or libdl.
>
>
> On 2018-07-17 11:57, Martin Jansa wrote:
>> The PACKAGECONFIG for them is already there, why do you need to
>> remove the option for someone to disable the support if they want?
>>
>> On Tue, Jul 17, 2018 at 11:54 AM Carlos Rafael Giani
>> <dv@pseudoterminal.org <mailto:dv@pseudoterminal.org>> wrote:
>>
>> The zlib and bz2 switches enable zlib and bzip2 support in the
>> qtdemux and matroska plugins. They do not enable some sort of
>> standalone bz2/zlib plugins. Is there any reason why these
>> shouldn't be enabled always?
>>
>>
>> On 2018-07-17 11:50, Martin Jansa wrote:
>>> Why do you remove bz2 and zlib PACKAGECONFIGs instead of just
>>> enabling them by default?
>>>
>>> On Tue, Jul 17, 2018 at 11:45 AM Carlos Rafael Giani
>>> <dv@pseudoterminal.org <mailto:dv@pseudoterminal.org>> wrote:
>>>
>>> * Always enable bz2 and zlib, since these are part of
>>> oe-core, and
>>> dependencies that are in oe-core can be always enabled
>>> * There is no twolame recipe in oe-core or in
>>> meta-openembedded, so
>>> disable it
>>> * Reorder the packageconfigs alphabetically
>>>
>>> Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org
>>> <mailto:dv@pseudoterminal.org>>
>>> ---
>>> .../gstreamer1.0-plugins-good_1.14.1.bb
>>> <http://gstreamer1.0-plugins-good_1.14.1.bb> | 17
>>> +++++++++--------
>>> 1 file changed, 9 insertions(+), 8 deletions(-)
>>>
>>> diff --git
>>> a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.14.1.bb
>>> <http://gstreamer1.0-plugins-good_1.14.1.bb>
>>> b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.14.1.bb
>>> <http://gstreamer1.0-plugins-good_1.14.1.bb>
>>> index 36eb3107ae..baeb19ddfe 100644
>>> ---
>>> a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.14.1.bb
>>> <http://gstreamer1.0-plugins-good_1.14.1.bb>
>>> +++
>>> b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-good_1.14.1.bb
>>> <http://gstreamer1.0-plugins-good_1.14.1.bb>
>>> @@ -18,7 +18,7 @@ LIC_FILES_CHKSUM =
>>> "file://COPYING;md5=a6f89e2100d9b6cdffcea4f398e37343 \
>>> file://common/coverage/coverage-report.pl
>>> <http://coverage-report.pl>;beginline=2;endline=17;md5=a4e1830fce078028c8f0974161272607
>>> \
>>> file://gst/replaygain/rganalysis.c;beginline=1;endline=23;md5=b60ebefd5b2f5a8e0cab6bfee391a5fe"
>>>
>>> -DEPENDS += "gstreamer1.0-plugins-base libcap"
>>> +DEPENDS += "gstreamer1.0-plugins-base libcap zlib bzip2"
>>> RPROVIDES_${PN}-pulseaudio += "${PN}-pulse"
>>> RPROVIDES_${PN}-soup += "${PN}-souphttpsrc"
>>>
>>> @@ -28,7 +28,7 @@ PACKAGECONFIG ??= " \
>>> ${GSTREAMER_ORC} \
>>> ${@bb.utils.filter('DISTRO_FEATURES', 'pulseaudio x11',
>>> d)} \
>>> ${@bb.utils.contains_any('DISTRO_FEATURES',
>>> d.getVar('GTK3DISTROFEATURES'), 'gtk', '', d)} \
>>> - cairo flac gdk-pixbuf gudev jpeg libpng soup speex
>>> taglib v4l2 bz2 zlib mpg123 lame \
>>> + cairo flac gdk-pixbuf gudev jpeg lame libpng mpg123
>>> soup speex taglib v4l2 \
>>> "
>>>
>>> X11DEPENDS = "virtual/libx11 libsm libxrender libxfixes
>>> libxdamage"
>>> @@ -37,11 +37,14 @@ PACKAGECONFIG[cairo] =
>>> "--enable-cairo,--disable-cairo,cairo"
>>> PACKAGECONFIG[dv1394] =
>>> "--enable-dv1394,--disable-dv1394,libiec61883 libavc1394
>>> libraw1394"
>>> PACKAGECONFIG[flac] = "--enable-flac,--disable-flac,flac"
>>> PACKAGECONFIG[gdk-pixbuf] =
>>> "--enable-gdk_pixbuf,--disable-gdk_pixbuf,gdk-pixbuf"
>>> +PACKAGECONFIG[gtk] =
>>> "--enable-gtk3,--disable-gtk3,gtk+3"
>>> PACKAGECONFIG[gudev] =
>>> "--with-gudev,--without-gudev,libgudev"
>>> PACKAGECONFIG[jack] = "--enable-jack,--disable-jack,jack"
>>> PACKAGECONFIG[jpeg] = "--enable-jpeg,--disable-jpeg,jpeg"
>>> +PACKAGECONFIG[lame] = "--enable-lame,--disable-lame,lame"
>>> PACKAGECONFIG[libpng] =
>>> "--enable-libpng,--disable-libpng,libpng"
>>> PACKAGECONFIG[libv4l2] =
>>> "--with-libv4l2,--without-libv4l2,v4l-utils"
>>> +PACKAGECONFIG[mpg123] =
>>> "--enable-mpg123,--disable-mpg123,mpg123"
>>> PACKAGECONFIG[pulseaudio] =
>>> "--enable-pulse,--disable-pulse,pulseaudio"
>>> PACKAGECONFIG[soup] =
>>> "--enable-soup,--disable-soup,libsoup-2.4"
>>> PACKAGECONFIG[speex] =
>>> "--enable-speex,--disable-speex,speex"
>>> @@ -50,11 +53,6 @@ PACKAGECONFIG[v4l2] =
>>> "--enable-gst_v4l2 --enable-v4l2-probe,--disable-gst
>>> PACKAGECONFIG[vpx] = "--enable-vpx,--disable-vpx,libvpx"
>>> PACKAGECONFIG[wavpack] =
>>> "--enable-wavpack,--disable-wavpack,wavpack"
>>> PACKAGECONFIG[x11] =
>>> "--enable-x,--disable-x,${X11DEPENDS}"
>>> -PACKAGECONFIG[bz2] = "--enable-bz2,--disable-bz2,bzip2"
>>> -PACKAGECONFIG[zlib] = "--enable-zlib,--disable-zlib,zlib"
>>> -PACKAGECONFIG[lame] = "--enable-lame,--disable-lame,lame"
>>> -PACKAGECONFIG[mpg123] =
>>> "--enable-mpg123,--disable-mpg123,mpg123"
>>> -PACKAGECONFIG[gtk] =
>>> "--enable-gtk3,--disable-gtk3,gtk+3"
>>>
>>> # qt5 support is disabled, because it is not present in OE
>>> core, and requires more work than
>>> # just adding a packageconfig (it requires access to moc,
>>> uic, rcc, and qmake paths).
>>> @@ -62,7 +60,9 @@ PACKAGECONFIG[gtk] =
>>> "--enable-gtk3,--disable-gtk3,gtk+3"
>>> # in a gstreamer1.0-plugins-good bbappend).
>>>
>>> EXTRA_OECONF += " \
>>> + --enable-bz2 \
>>> --enable-oss \
>>> + --enable-zlib \
>>> --disable-aalib \
>>> --disable-aalibtest \
>>> --disable-directsound \
>>> @@ -71,9 +71,10 @@ EXTRA_OECONF += " \
>>> --disable-oss4 \
>>> --disable-osx_audio \
>>> --disable-osx_video \
>>> + --disable-qt \
>>> --disable-shout2 \
>>> + --disable-twolame \
>>> --disable-waveform \
>>> - --disable-qt \
>>> "
>>>
>>> FILES_${PN}-equalizer +=
>>> "${datadir}/gstreamer-1.0/presets/*.prs"
>>> --
>>> 2.17.1
>>>
>>> --
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> <mailto:Openembedded-core@lists.openembedded.org>
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>
>>
>
>
>
[-- Attachment #2: Type: text/html, Size: 13430 bytes --]
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 3/6] gstreamer1.0-plugin-bad: Update packageconfigs
2018-07-17 9:35 [PATCH 1/6] gstreamer1.0-plugin-base: Update packageconfigs Carlos Rafael Giani
2018-07-17 9:35 ` [PATCH 2/6] gstreamer1.0-plugin-good: " Carlos Rafael Giani
@ 2018-07-17 9:35 ` Carlos Rafael Giani
2018-07-17 9:50 ` Carlos Rafael Giani
2018-07-17 9:35 ` [PATCH 4/6] gstreamer1.0-vaapi: Remove unnecessary FILESPATH modification Carlos Rafael Giani
` (4 subsequent siblings)
6 siblings, 1 reply; 17+ messages in thread
From: Carlos Rafael Giani @ 2018-07-17 9:35 UTC (permalink / raw)
To: openembedded-core
* Add packageconfigs for gl, libde265, lcms2, openh264, tinyalsa, ttml,
webrtc, webrtcdsp
* Add note about neon being dead (and --disable-neon config switch)
* Remove unnecessary gstglconfig.h line, since that file is no longer
part of -bad (it is in -base now)
* Update EXTRA_OECONF flags, since new plugins got added to -bad
* Add ttml to the default packageconfigs since its dependencies are
all in oe-core
---
.../gstreamer1.0-plugins-bad_1.14.1.bb | 35 ++++++++++++++-----
1 file changed, 26 insertions(+), 9 deletions(-)
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.14.1.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.14.1.bb
index 0e477e5a9c..721df60b8d 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.14.1.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.14.1.bb
@@ -27,9 +27,14 @@ PACKAGECONFIG ??= " \
${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', d)} \
${@bb.utils.filter('DISTRO_FEATURES', 'directfb vulkan', d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)} \
- bz2 curl dash dtls hls rsvg sbc smoothstreaming sndfile uvch264 webp \
+ ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gl', '', d)} \
+ bz2 curl dash dtls hls rsvg sbc smoothstreaming sndfile ttml uvch264 webp \
"
+# the gl packageconfig enables OpenGL elements that haven't been ported
+# to -base yet. They depend on the gstgl library in -base, so we do
+# not add GL dependencies here, since these are taken care of in -base.
+
PACKAGECONFIG[assrender] = "--enable-assrender,--disable-assrender,libass"
PACKAGECONFIG[bluez] = "--enable-bluez,--disable-bluez,${BLUEZ}"
PACKAGECONFIG[bz2] = "--enable-bz2,--disable-bz2,bzip2"
@@ -43,13 +48,17 @@ PACKAGECONFIG[faad] = "--enable-faad,--disable-faad,faad2"
PACKAGECONFIG[flite] = "--enable-flite,--disable-flite,flite-alsa"
PACKAGECONFIG[fluidsynth] = "--enable-fluidsynth,--disable-fluidsynth,fluidsynth"
PACKAGECONFIG[hls] = "--enable-hls --with-hls-crypto=nettle,--disable-hls,nettle"
+PACKAGECONFIG[gl] = "--enable-gl,--disable-gl,"
PACKAGECONFIG[kms] = "--enable-kms,--disable-kms,libdrm"
+PACKAGECONFIG[libde265] = "--enable-libde265,--disable-libde265,libde265"
PACKAGECONFIG[libmms] = "--enable-libmms,--disable-libmms,libmms"
PACKAGECONFIG[libssh2] = "--enable-libssh2,--disable-libssh2,libssh2"
+PACKAGECONFIG[lcms2] = "--enable-lcms2,--disable-lcms2,lcms"
PACKAGECONFIG[modplug] = "--enable-modplug,--disable-modplug,libmodplug"
PACKAGECONFIG[neon] = "--enable-neon,--disable-neon,neon"
PACKAGECONFIG[openal] = "--enable-openal,--disable-openal,openal-soft"
PACKAGECONFIG[opencv] = "--enable-opencv,--disable-opencv,opencv"
+PACKAGECONFIG[openh264] = "--enable-openh264,--disable-openh264,openh264"
PACKAGECONFIG[openjpeg] = "--enable-openjpeg,--disable-openjpeg,openjpeg"
# the opus encoder/decoder elements are now in the -base package,
# but the opus parser remains in -bad
@@ -61,28 +70,38 @@ PACKAGECONFIG[sbc] = "--enable-sbc,--disable-sbc,sbc"
PACKAGECONFIG[smoothstreaming] = "--enable-smoothstreaming,--disable-smoothstreaming,libxml2"
PACKAGECONFIG[sndfile] = "--enable-sndfile,--disable-sndfile,libsndfile1"
PACKAGECONFIG[srtp] = "--enable-srtp,--disable-srtp,libsrtp"
+PACKAGECONFIG[tinyalsa] = "--enable-tinyalsa,--disable-tinyalsa,tinyalsa"
+PACKAGECONFIG[ttml] = "--enable-ttml,--disable-ttml,libxml2 pango cairo"
PACKAGECONFIG[uvch264] = "--enable-uvch264,--disable-uvch264,libusb1 libgudev"
PACKAGECONFIG[voaacenc] = "--enable-voaacenc,--disable-voaacenc,vo-aacenc"
PACKAGECONFIG[voamrwbenc] = "--enable-voamrwbenc,--disable-voamrwbenc,vo-amrwbenc"
PACKAGECONFIG[vulkan] = "--enable-vulkan,--disable-vulkan,vulkan"
PACKAGECONFIG[wayland] = "--enable-wayland,--disable-wayland,wayland-native wayland wayland-protocols libdrm"
PACKAGECONFIG[webp] = "--enable-webp,--disable-webp,libwebp"
+PACKAGECONFIG[webrtc] = "--enable-webrtc,--disable-webrtc,libnice"
+PACKAGECONFIG[webrtcdsp] = "--enable-webrtcdsp,--disable-webrtcdsp,webrtc-audio-processing"
# these plugins have no corresponding library in OE-core or meta-openembedded:
# openni2 winks direct3d directsound winscreencap acm apple_media iqa
-# android_media avc bs2b chromaprint daala dts fdkaac gme gsm kate ladspa libde265
-# lv2 mpeg2enc mplex msdk musepack nvenc ofa openh264 opensles soundtouch spandsp
-# spc teletextdec tinyalsa vdpau wasapi x265 zbar webrtcdsp
+# android_media avc bs2b chromaprint daala dts fdkaac gme gsm kate ladspa
+# lv2 mpeg2enc mplex msdk musepack nvenc ofa openmpt opensles soundtouch
+# spandsp spc teletextdec vdpau wasapi x265 zbar
+
+# these plugins have been removed from oe-core because their upstream dependencies
+# are no longer maintained or available:
+# neon
EXTRA_OECONF += " \
--enable-decklink \
--enable-dvb \
--enable-fbdev \
+ --enable-ipcpipeline \
--enable-netsim \
--enable-shm \
--enable-vcd \
--disable-acm \
--disable-android_media \
+ --disable-aom \
--disable-apple_media \
--disable-avc \
--disable-bs2b \
@@ -97,26 +116,25 @@ EXTRA_OECONF += " \
--disable-iqa \
--disable-kate \
--disable-ladspa \
- --disable-libde265 \
--disable-lv2 \
--disable-mpeg2enc \
--disable-mplex \
--disable-msdk \
--disable-musepack \
+ --disable-neon \
--disable-nvenc \
--disable-ofa \
--disable-openexr \
- --disable-openh264 \
+ --disable-openmpt \
--disable-openni2 \
--disable-opensles \
--disable-soundtouch \
--disable-spandsp \
--disable-spc \
+ --disable-srt \
--disable-teletextdec \
- --disable-tinyalsa \
--disable-vdpau \
--disable-wasapi \
- --disable-webrtcdsp \
--disable-wildmidi \
--disable-winks \
--disable-winscreencap \
@@ -130,7 +148,6 @@ export OPENCV_PREFIX = "${STAGING_DIR_TARGET}${prefix}"
ARM_INSTRUCTION_SET_armv4 = "arm"
ARM_INSTRUCTION_SET_armv5 = "arm"
-FILES_${PN}-dev += "${libdir}/gstreamer-${LIBV}/include/gst/gl/gstglconfig.h"
FILES_${PN}-freeverb += "${datadir}/gstreamer-${LIBV}/presets/GstFreeverb.prs"
FILES_${PN}-opencv += "${datadir}/gst-plugins-bad/${LIBV}/opencv*"
FILES_${PN}-voamrwbenc += "${datadir}/gstreamer-${LIBV}/presets/GstVoAmrwbEnc.prs"
--
2.17.1
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH 3/6] gstreamer1.0-plugin-bad: Update packageconfigs
2018-07-17 9:35 ` [PATCH 3/6] gstreamer1.0-plugin-bad: " Carlos Rafael Giani
@ 2018-07-17 9:50 ` Carlos Rafael Giani
0 siblings, 0 replies; 17+ messages in thread
From: Carlos Rafael Giani @ 2018-07-17 9:50 UTC (permalink / raw)
To: openembedded-core
Please note that libnice 0.1.14 is a requirement for the webrtc plugins.
I submitted a libnice recipe upgrade to 0.1.14 a few months ago. Please
commit that one first so we can have full WebRTC support (not just
webrtcdsp) in gstreamer1.0-plugins-bad.
On 2018-07-17 11:35, Carlos Rafael Giani wrote:
> * Add packageconfigs for gl, libde265, lcms2, openh264, tinyalsa, ttml,
> webrtc, webrtcdsp
> * Add note about neon being dead (and --disable-neon config switch)
> * Remove unnecessary gstglconfig.h line, since that file is no longer
> part of -bad (it is in -base now)
> * Update EXTRA_OECONF flags, since new plugins got added to -bad
> * Add ttml to the default packageconfigs since its dependencies are
> all in oe-core
> ---
> .../gstreamer1.0-plugins-bad_1.14.1.bb | 35 ++++++++++++++-----
> 1 file changed, 26 insertions(+), 9 deletions(-)
>
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.14.1.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.14.1.bb
> index 0e477e5a9c..721df60b8d 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.14.1.bb
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.14.1.bb
> @@ -27,9 +27,14 @@ PACKAGECONFIG ??= " \
> ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', d)} \
> ${@bb.utils.filter('DISTRO_FEATURES', 'directfb vulkan', d)} \
> ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)} \
> - bz2 curl dash dtls hls rsvg sbc smoothstreaming sndfile uvch264 webp \
> + ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gl', '', d)} \
> + bz2 curl dash dtls hls rsvg sbc smoothstreaming sndfile ttml uvch264 webp \
> "
>
> +# the gl packageconfig enables OpenGL elements that haven't been ported
> +# to -base yet. They depend on the gstgl library in -base, so we do
> +# not add GL dependencies here, since these are taken care of in -base.
> +
> PACKAGECONFIG[assrender] = "--enable-assrender,--disable-assrender,libass"
> PACKAGECONFIG[bluez] = "--enable-bluez,--disable-bluez,${BLUEZ}"
> PACKAGECONFIG[bz2] = "--enable-bz2,--disable-bz2,bzip2"
> @@ -43,13 +48,17 @@ PACKAGECONFIG[faad] = "--enable-faad,--disable-faad,faad2"
> PACKAGECONFIG[flite] = "--enable-flite,--disable-flite,flite-alsa"
> PACKAGECONFIG[fluidsynth] = "--enable-fluidsynth,--disable-fluidsynth,fluidsynth"
> PACKAGECONFIG[hls] = "--enable-hls --with-hls-crypto=nettle,--disable-hls,nettle"
> +PACKAGECONFIG[gl] = "--enable-gl,--disable-gl,"
> PACKAGECONFIG[kms] = "--enable-kms,--disable-kms,libdrm"
> +PACKAGECONFIG[libde265] = "--enable-libde265,--disable-libde265,libde265"
> PACKAGECONFIG[libmms] = "--enable-libmms,--disable-libmms,libmms"
> PACKAGECONFIG[libssh2] = "--enable-libssh2,--disable-libssh2,libssh2"
> +PACKAGECONFIG[lcms2] = "--enable-lcms2,--disable-lcms2,lcms"
> PACKAGECONFIG[modplug] = "--enable-modplug,--disable-modplug,libmodplug"
> PACKAGECONFIG[neon] = "--enable-neon,--disable-neon,neon"
> PACKAGECONFIG[openal] = "--enable-openal,--disable-openal,openal-soft"
> PACKAGECONFIG[opencv] = "--enable-opencv,--disable-opencv,opencv"
> +PACKAGECONFIG[openh264] = "--enable-openh264,--disable-openh264,openh264"
> PACKAGECONFIG[openjpeg] = "--enable-openjpeg,--disable-openjpeg,openjpeg"
> # the opus encoder/decoder elements are now in the -base package,
> # but the opus parser remains in -bad
> @@ -61,28 +70,38 @@ PACKAGECONFIG[sbc] = "--enable-sbc,--disable-sbc,sbc"
> PACKAGECONFIG[smoothstreaming] = "--enable-smoothstreaming,--disable-smoothstreaming,libxml2"
> PACKAGECONFIG[sndfile] = "--enable-sndfile,--disable-sndfile,libsndfile1"
> PACKAGECONFIG[srtp] = "--enable-srtp,--disable-srtp,libsrtp"
> +PACKAGECONFIG[tinyalsa] = "--enable-tinyalsa,--disable-tinyalsa,tinyalsa"
> +PACKAGECONFIG[ttml] = "--enable-ttml,--disable-ttml,libxml2 pango cairo"
> PACKAGECONFIG[uvch264] = "--enable-uvch264,--disable-uvch264,libusb1 libgudev"
> PACKAGECONFIG[voaacenc] = "--enable-voaacenc,--disable-voaacenc,vo-aacenc"
> PACKAGECONFIG[voamrwbenc] = "--enable-voamrwbenc,--disable-voamrwbenc,vo-amrwbenc"
> PACKAGECONFIG[vulkan] = "--enable-vulkan,--disable-vulkan,vulkan"
> PACKAGECONFIG[wayland] = "--enable-wayland,--disable-wayland,wayland-native wayland wayland-protocols libdrm"
> PACKAGECONFIG[webp] = "--enable-webp,--disable-webp,libwebp"
> +PACKAGECONFIG[webrtc] = "--enable-webrtc,--disable-webrtc,libnice"
> +PACKAGECONFIG[webrtcdsp] = "--enable-webrtcdsp,--disable-webrtcdsp,webrtc-audio-processing"
>
> # these plugins have no corresponding library in OE-core or meta-openembedded:
> # openni2 winks direct3d directsound winscreencap acm apple_media iqa
> -# android_media avc bs2b chromaprint daala dts fdkaac gme gsm kate ladspa libde265
> -# lv2 mpeg2enc mplex msdk musepack nvenc ofa openh264 opensles soundtouch spandsp
> -# spc teletextdec tinyalsa vdpau wasapi x265 zbar webrtcdsp
> +# android_media avc bs2b chromaprint daala dts fdkaac gme gsm kate ladspa
> +# lv2 mpeg2enc mplex msdk musepack nvenc ofa openmpt opensles soundtouch
> +# spandsp spc teletextdec vdpau wasapi x265 zbar
> +
> +# these plugins have been removed from oe-core because their upstream dependencies
> +# are no longer maintained or available:
> +# neon
>
> EXTRA_OECONF += " \
> --enable-decklink \
> --enable-dvb \
> --enable-fbdev \
> + --enable-ipcpipeline \
> --enable-netsim \
> --enable-shm \
> --enable-vcd \
> --disable-acm \
> --disable-android_media \
> + --disable-aom \
> --disable-apple_media \
> --disable-avc \
> --disable-bs2b \
> @@ -97,26 +116,25 @@ EXTRA_OECONF += " \
> --disable-iqa \
> --disable-kate \
> --disable-ladspa \
> - --disable-libde265 \
> --disable-lv2 \
> --disable-mpeg2enc \
> --disable-mplex \
> --disable-msdk \
> --disable-musepack \
> + --disable-neon \
> --disable-nvenc \
> --disable-ofa \
> --disable-openexr \
> - --disable-openh264 \
> + --disable-openmpt \
> --disable-openni2 \
> --disable-opensles \
> --disable-soundtouch \
> --disable-spandsp \
> --disable-spc \
> + --disable-srt \
> --disable-teletextdec \
> - --disable-tinyalsa \
> --disable-vdpau \
> --disable-wasapi \
> - --disable-webrtcdsp \
> --disable-wildmidi \
> --disable-winks \
> --disable-winscreencap \
> @@ -130,7 +148,6 @@ export OPENCV_PREFIX = "${STAGING_DIR_TARGET}${prefix}"
> ARM_INSTRUCTION_SET_armv4 = "arm"
> ARM_INSTRUCTION_SET_armv5 = "arm"
>
> -FILES_${PN}-dev += "${libdir}/gstreamer-${LIBV}/include/gst/gl/gstglconfig.h"
> FILES_${PN}-freeverb += "${datadir}/gstreamer-${LIBV}/presets/GstFreeverb.prs"
> FILES_${PN}-opencv += "${datadir}/gst-plugins-bad/${LIBV}/opencv*"
> FILES_${PN}-voamrwbenc += "${datadir}/gstreamer-${LIBV}/presets/GstVoAmrwbEnc.prs"
^ permalink raw reply [flat|nested] 17+ messages in thread
* [PATCH 4/6] gstreamer1.0-vaapi: Remove unnecessary FILESPATH modification
2018-07-17 9:35 [PATCH 1/6] gstreamer1.0-plugin-base: Update packageconfigs Carlos Rafael Giani
2018-07-17 9:35 ` [PATCH 2/6] gstreamer1.0-plugin-good: " Carlos Rafael Giani
2018-07-17 9:35 ` [PATCH 3/6] gstreamer1.0-plugin-bad: " Carlos Rafael Giani
@ 2018-07-17 9:35 ` Carlos Rafael Giani
2018-07-17 9:35 ` [PATCH 5/6] gstreamer1.0-vaapi: Add patch for EGL CFLAGS for proper EGL support Carlos Rafael Giani
` (3 subsequent siblings)
6 siblings, 0 replies; 17+ messages in thread
From: Carlos Rafael Giani @ 2018-07-17 9:35 UTC (permalink / raw)
To: openembedded-core
Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
---
meta/recipes-multimedia/gstreamer/gstreamer1.0-vaapi_1.14.1.bb | 1 -
1 file changed, 1 deletion(-)
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-vaapi_1.14.1.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-vaapi_1.14.1.bb
index 906dc6e6c4..e647458fab 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-vaapi_1.14.1.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-vaapi_1.14.1.bb
@@ -4,7 +4,6 @@ based plugins for GStreamer and helper libraries: `vaapidecode', \
`vaapiconvert', and `vaapisink'."
REALPN = "gstreamer-vaapi"
-FILESPATH = "${@base_set_filespath(["${FILE_DIRNAME}/${REALPN}", "${FILE_DIRNAME}/${REALPN}"], d)}"
LICENSE = "LGPLv2.1+"
LIC_FILES_CHKSUM = "file://COPYING.LIB;md5=4fbd65380cdd255951079008b364516c"
--
2.17.1
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 5/6] gstreamer1.0-vaapi: Add patch for EGL CFLAGS for proper EGL support
2018-07-17 9:35 [PATCH 1/6] gstreamer1.0-plugin-base: Update packageconfigs Carlos Rafael Giani
` (2 preceding siblings ...)
2018-07-17 9:35 ` [PATCH 4/6] gstreamer1.0-vaapi: Remove unnecessary FILESPATH modification Carlos Rafael Giani
@ 2018-07-17 9:35 ` Carlos Rafael Giani
2018-07-17 9:35 ` [PATCH 6/6] gstreamer1.0-libav: Replace German umlaut to avoid parsing problems Carlos Rafael Giani
` (2 subsequent siblings)
6 siblings, 0 replies; 17+ messages in thread
From: Carlos Rafael Giani @ 2018-07-17 9:35 UTC (permalink / raw)
To: openembedded-core
Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
---
...le.am-Add-EGL_CFLAGS-to-libgstvaapi-.patch | 33 +++++++++++++++++++
.../gstreamer/gstreamer1.0-vaapi_1.14.1.bb | 1 +
2 files changed, 34 insertions(+)
create mode 100644 meta/recipes-multimedia/gstreamer/gstreamer1.0-vaapi/0001-gst-vaapi-Makefile.am-Add-EGL_CFLAGS-to-libgstvaapi-.patch
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-vaapi/0001-gst-vaapi-Makefile.am-Add-EGL_CFLAGS-to-libgstvaapi-.patch b/meta/recipes-multimedia/gstreamer/gstreamer1.0-vaapi/0001-gst-vaapi-Makefile.am-Add-EGL_CFLAGS-to-libgstvaapi-.patch
new file mode 100644
index 0000000000..d7b8984953
--- /dev/null
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-vaapi/0001-gst-vaapi-Makefile.am-Add-EGL_CFLAGS-to-libgstvaapi-.patch
@@ -0,0 +1,33 @@
+From 5403a89e6a7ac72a23e0221075c0c19b5f85a021 Mon Sep 17 00:00:00 2001
+From: Fabio Berton <fabio.berton@ossystems.com.br>
+Date: Wed, 13 Jun 2018 09:09:25 -0300
+Subject: [PATCH] gst/vaapi/Makefile.am: Add EGL_CFLAGS to libgstvaapi CFLAGS
+Organization: O.S. Systems Software LTDA.
+
+We need this to pass correctly EGL CFLAGS when building with EGL support.
+
+Upstream-Status: Pending
+
+Signed-off-by: Fabio Berton <fabio.berton@ossystems.com.br>
+---
+ gst/vaapi/Makefile.am | 4 ++++
+ 1 file changed, 4 insertions(+)
+
+diff --git a/gst/vaapi/Makefile.am b/gst/vaapi/Makefile.am
+index b299ac98..d6cab71f 100644
+--- a/gst/vaapi/Makefile.am
++++ b/gst/vaapi/Makefile.am
+@@ -24,6 +24,10 @@ libgstvaapi_LIBS += $(top_builddir)/gst-libs/gst/vaapi/libgstvaapi-glx.la
+ endif
+
+ if USE_EGL
++libgstvaapi_CFLAGS += \
++ $(EGL_CFLAGS) \
++ $(NULL)
++
+ libgstvaapi_LIBS += $(top_builddir)/gst-libs/gst/vaapi/libgstvaapi-egl.la
+ endif
+
+--
+2.17.1
+
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-vaapi_1.14.1.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-vaapi_1.14.1.bb
index e647458fab..63290326a5 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-vaapi_1.14.1.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-vaapi_1.14.1.bb
@@ -9,6 +9,7 @@ LICENSE = "LGPLv2.1+"
LIC_FILES_CHKSUM = "file://COPYING.LIB;md5=4fbd65380cdd255951079008b364516c"
SRC_URI = "https://gstreamer.freedesktop.org/src/${REALPN}/${REALPN}-${PV}.tar.xz \
+ file://0001-gst-vaapi-Makefile.am-Add-EGL_CFLAGS-to-libgstvaapi-.patch \
"
SRC_URI[md5sum] = "38c5b2390797b7a0a269a5ab6c8cbe8f"
--
2.17.1
^ permalink raw reply related [flat|nested] 17+ messages in thread* [PATCH 6/6] gstreamer1.0-libav: Replace German umlaut to avoid parsing problems
2018-07-17 9:35 [PATCH 1/6] gstreamer1.0-plugin-base: Update packageconfigs Carlos Rafael Giani
` (3 preceding siblings ...)
2018-07-17 9:35 ` [PATCH 5/6] gstreamer1.0-vaapi: Add patch for EGL CFLAGS for proper EGL support Carlos Rafael Giani
@ 2018-07-17 9:35 ` Carlos Rafael Giani
2018-07-18 12:16 ` [PATCH 1/6] gstreamer1.0-plugin-base: Update packageconfigs Peter Kjellerstedt
2018-07-19 1:38 ` Anuj Mittal
6 siblings, 0 replies; 17+ messages in thread
From: Carlos Rafael Giani @ 2018-07-17 9:35 UTC (permalink / raw)
To: openembedded-core
The umlaut can cause issues related to encoding; avoid by replacing it
Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
---
.../workaround-to-build-gst-libav-for-i586-with-gcc.patch | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-libav/workaround-to-build-gst-libav-for-i586-with-gcc.patch b/meta/recipes-multimedia/gstreamer/gstreamer1.0-libav/workaround-to-build-gst-libav-for-i586-with-gcc.patch
index 36abf8607e..5355480aa4 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-libav/workaround-to-build-gst-libav-for-i586-with-gcc.patch
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-libav/workaround-to-build-gst-libav-for-i586-with-gcc.patch
@@ -1,5 +1,5 @@
Description: Workaround to build libav for i586 with gcc 4.9.2 by avoiding memset
-Author: Bernhard Übelacker <bernhardu@vr-web.de>
+Author: Bernhard Uebelacker <bernhardu@vr-web.de>
---
Bug-Debian: https://bugs.debian.org/783082
--
2.17.1
^ permalink raw reply related [flat|nested] 17+ messages in thread* Re: [PATCH 1/6] gstreamer1.0-plugin-base: Update packageconfigs
2018-07-17 9:35 [PATCH 1/6] gstreamer1.0-plugin-base: Update packageconfigs Carlos Rafael Giani
` (4 preceding siblings ...)
2018-07-17 9:35 ` [PATCH 6/6] gstreamer1.0-libav: Replace German umlaut to avoid parsing problems Carlos Rafael Giani
@ 2018-07-18 12:16 ` Peter Kjellerstedt
2018-07-18 13:03 ` Carlos Rafael Giani
2018-07-19 1:38 ` Anuj Mittal
6 siblings, 1 reply; 17+ messages in thread
From: Peter Kjellerstedt @ 2018-07-18 12:16 UTC (permalink / raw)
To: Carlos Rafael Giani, openembedded-core@lists.openembedded.org
> -----Original Message-----
> From: openembedded-core-bounces@lists.openembedded.org
> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
> Carlos Rafael Giani
> Sent: den 17 juli 2018 11:35
> To: openembedded-core@lists.openembedded.org
> Subject: [OE-core] [PATCH 1/6] gstreamer1.0-plugin-base: Update
> packageconfigs
>
> * Always enable zlib, since it is part of oe-core, and dependencies that
> are in oe-core can be always enabled
Just because it can be enabled does not mean it should be unconditionally
enabled. If building for an environment where, e.g., flash memory is scarce,
every byte counts. Keeping the packageconfig and leaving it enabled by
default will give the same result, but for someone trying to remove anything
they do not need, it is then more obvious that the jpeg dependency is
optional and can be removed if wanted.
> * The jpeg packageconfig is not needed, since there are no configuration
> switches to enable or disable it, and libjpeg-turbo is part of oe-core
Same here as for zlib.
> * libpng is a dependency, and is part of oe-core, so add it to DEPENDS
This too is optional and should have a packageconfig (which can be
enabled by default since it is pulled in anyway due to other dependencies).
> * There is no libvisual recipe in oe-core or in meta-openembedded, so
> the visual packageconfig needs to go
> * Reorder the packageconfigs alphabetically
You also add dependencies on libgudev and libdrm, without mentioning it here.
Why is this? They too are optional, and they have not been needed before.
If you want to add support for them, then do so by adding packageconfigs
(which I don't think should be enabled by default to maintain the
configuration as it was).
> Signed-off-by: Carlos Rafael Giani <dv@pseudoterminal.org>
> ---
> .../gstreamer1.0-plugins-base_1.14.1.bb | 26 +++++++++++--------
> 1 file changed, 15 insertions(+), 11 deletions(-)
>
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.14.1.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.14.1.bb
> index 8d7d3c6192..52722ff615 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.14.1.bb
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-base_1.14.1.bb
> @@ -24,18 +24,21 @@ SRC_URI[sha256sum] =
> "1026c7c3082d825d9b5d034c1a6dd8a4ebab60eb3738b0a0afde4ad2dc
>
> S = "${WORKDIR}/gst-plugins-base-${PV}"
>
> -DEPENDS += "iso-codes util-linux"
> +DEPENDS += "iso-codes util-linux zlib libgudev libdrm jpeg libpng"
>
> inherit gettext
>
> PACKAGES_DYNAMIC =+ "^libgst.*"
>
> +# opengl packageconfig factored out to make it easy for distros
> +# and BSP layers to pick either (desktop) opengl, gles2, or no GL
> PACKAGECONFIG_GL ?= "${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gles2 egl', '', d)}"
> +
> PACKAGECONFIG ??= " \
> ${GSTREAMER_ORC} \
> - ${@bb.utils.filter('DISTRO_FEATURES', 'alsa x11', d)} \
> - gio-unix-2.0 ogg pango theora vorbis zlib jpeg \
> ${PACKAGECONFIG_GL} \
> + ${@bb.utils.filter('DISTRO_FEATURES', 'alsa x11', d)} \
> + gio-unix-2.0 ogg pango theora vorbis \
> ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland egl', '', d)} \
> "
>
> @@ -45,26 +48,27 @@ X11DISABLEOPTS = "--disable-x --disable-xvideo --
> disable-xshm"
>
> PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"
> PACKAGECONFIG[cdparanoia] = "--enable-cdparanoia,--disable-cdparanoia,cdparanoia"
> +PACKAGECONFIG[egl] = "--enable-egl,--disable-egl,virtual/egl"
> PACKAGECONFIG[gio-unix-2.0] = "--enable-gio_unix_2_0,--disable-gio_unix_2_0,glib-2.0"
> +PACKAGECONFIG[gles2] = "--enable-gles2,--disable-gles2,virtual/libgles2"
> PACKAGECONFIG[ivorbis] = "--enable-ivorbis,--disable-ivorbis,tremor"
> PACKAGECONFIG[ogg] = "--enable-ogg,--disable-ogg,libogg"
> +PACKAGECONFIG[opengl] = "--enable-opengl,--disable-opengl,virtual/libgl libglu"
> PACKAGECONFIG[opus] = "--enable-opus,--disable-opus,libopus"
> PACKAGECONFIG[pango] = "--enable-pango,--disable-pango,pango"
> PACKAGECONFIG[theora] = "--enable-theora,--disable-theora,libtheora"
> -PACKAGECONFIG[visual] = "--enable-libvisual,--disable-libvisual,libvisual"
> PACKAGECONFIG[vorbis] = "--enable-vorbis,--disable-vorbis,libvorbis"
> PACKAGECONFIG[x11] = "${X11ENABLEOPTS},${X11DISABLEOPTS},${X11DEPENDS}"
> -PACKAGECONFIG[zlib] = "--enable-zlib,--disable-zlib,zlib"
> -PACKAGECONFIG[opengl] = "--enable-opengl,--disable-opengl,virtual/libgl libglu"
> -PACKAGECONFIG[gles2] = "--enable-gles2,--disable-gles2,virtual/libgles2"
> -PACKAGECONFIG[egl] = "--enable-egl,--disable-egl,virtual/egl"
> PACKAGECONFIG[wayland] = "--enable-wayland,--disable-wayland,wayland-native wayland wayland-protocols libdrm"
> -PACKAGECONFIG[jpeg] = ",,jpeg"
>
> +EXTRA_OECONF += " \
> + --enable-zlib \
> + --disable-libvisual \
> +"
> +
> +FILES_${PN}-dev += "${libdir}/gstreamer-${LIBV}/include/gst/gl/gstglconfig.h"
> FILES_${MLPREFIX}libgsttag-1.0 += "${datadir}/gst-plugins-base/1.0/license-translations.dict"
>
> do_compile_prepend() {
> export GIR_EXTRA_LIBS_PATH="${B}/gst-libs/gst/tag/.libs:${B}/gst-libs/gst/video/.libs:${B}/gst-libs/gst/audio/.libs:${B}/gst-libs/gst/rtp/.libs:${B}/gst-libs/gst/allocators/.libs"
> }
> -
> -FILES_${PN}-dev += "${libdir}/gstreamer-${LIBV}/include/gst/gl/gstglconfig.h"
> --
> 2.17.1
//Peter
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH 1/6] gstreamer1.0-plugin-base: Update packageconfigs
2018-07-18 12:16 ` [PATCH 1/6] gstreamer1.0-plugin-base: Update packageconfigs Peter Kjellerstedt
@ 2018-07-18 13:03 ` Carlos Rafael Giani
2018-07-19 9:24 ` Carlos Rafael Giani
0 siblings, 1 reply; 17+ messages in thread
From: Carlos Rafael Giani @ 2018-07-18 13:03 UTC (permalink / raw)
To: Peter Kjellerstedt, openembedded-core@lists.openembedded.org
On 2018-07-18 14:16, Peter Kjellerstedt wrote:
>> -----Original Message-----
>> From: openembedded-core-bounces@lists.openembedded.org
>> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
>> Carlos Rafael Giani
>> Sent: den 17 juli 2018 11:35
>> To: openembedded-core@lists.openembedded.org
>> Subject: [OE-core] [PATCH 1/6] gstreamer1.0-plugin-base: Update
>> packageconfigs
>>
>> * Always enable zlib, since it is part of oe-core, and dependencies that
>> are in oe-core can be always enabled
> Just because it can be enabled does not mean it should be unconditionally
> enabled. If building for an environment where, e.g., flash memory is scarce,
> every byte counts. Keeping the packageconfig and leaving it enabled by
> default will give the same result, but for someone trying to remove anything
> they do not need, it is then more obvious that the jpeg dependency is
> optional and can be removed if wanted.
>
>> * The jpeg packageconfig is not needed, since there are no configuration
>> switches to enable or disable it, and libjpeg-turbo is part of oe-core
> Same here as for zlib.
>
>> * libpng is a dependency, and is part of oe-core, so add it to DEPENDS
> This too is optional and should have a packageconfig (which can be
> enabled by default since it is pulled in anyway due to other dependencies).
Well, okay, I can add them back in. However, there are no config
switches for the jpeg support. If someone enables a shared sysroot, and
there's libjpeg, gst-plugins-base will enable its support.
>
>> * There is no libvisual recipe in oe-core or in meta-openembedded, so
>> the visual packageconfig needs to go
>> * Reorder the packageconfigs alphabetically
> You also add dependencies on libgudev and libdrm, without mentioning it here.
> Why is this? They too are optional, and they have not been needed before.
> If you want to add support for them, then do so by adding packageconfigs
> (which I don't think should be enabled by default to maintain the
> configuration as it was).
These are now needed for the Mesa GBM based EGL contexts. However, just
as with jpeg, there are no config switches for them. Now that you
mention it, yeah, it makes more sense to patch this..
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/6] gstreamer1.0-plugin-base: Update packageconfigs
2018-07-18 13:03 ` Carlos Rafael Giani
@ 2018-07-19 9:24 ` Carlos Rafael Giani
0 siblings, 0 replies; 17+ messages in thread
From: Carlos Rafael Giani @ 2018-07-19 9:24 UTC (permalink / raw)
To: openembedded-core
Alright, I am working on a v2 with the packageconfigs added back in. I
also am adding patches for adding configuration switches for libgbm,
libpng, and libjpeg.
On 2018-07-18 15:03, Carlos Rafael Giani wrote:
> On 2018-07-18 14:16, Peter Kjellerstedt wrote:
>>> -----Original Message-----
>>> From: openembedded-core-bounces@lists.openembedded.org
>>> [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of
>>> Carlos Rafael Giani
>>> Sent: den 17 juli 2018 11:35
>>> To: openembedded-core@lists.openembedded.org
>>> Subject: [OE-core] [PATCH 1/6] gstreamer1.0-plugin-base: Update
>>> packageconfigs
>>>
>>> * Always enable zlib, since it is part of oe-core, and dependencies
>>> that
>>> are in oe-core can be always enabled
>> Just because it can be enabled does not mean it should be
>> unconditionally
>> enabled. If building for an environment where, e.g., flash memory is
>> scarce,
>> every byte counts. Keeping the packageconfig and leaving it enabled by
>> default will give the same result, but for someone trying to remove
>> anything
>> they do not need, it is then more obvious that the jpeg dependency is
>> optional and can be removed if wanted.
>>
>>> * The jpeg packageconfig is not needed, since there are no
>>> configuration
>>> switches to enable or disable it, and libjpeg-turbo is part of
>>> oe-core
>> Same here as for zlib.
>>
>>> * libpng is a dependency, and is part of oe-core, so add it to DEPENDS
>> This too is optional and should have a packageconfig (which can be
>> enabled by default since it is pulled in anyway due to other
>> dependencies).
>
> Well, okay, I can add them back in. However, there are no config
> switches for the jpeg support. If someone enables a shared sysroot,
> and there's libjpeg, gst-plugins-base will enable its support.
>
>>
>>> * There is no libvisual recipe in oe-core or in meta-openembedded, so
>>> the visual packageconfig needs to go
>>> * Reorder the packageconfigs alphabetically
>> You also add dependencies on libgudev and libdrm, without mentioning
>> it here.
>> Why is this? They too are optional, and they have not been needed
>> before.
>> If you want to add support for them, then do so by adding packageconfigs
>> (which I don't think should be enabled by default to maintain the
>> configuration as it was).
>
> These are now needed for the Mesa GBM based EGL contexts. However,
> just as with jpeg, there are no config switches for them. Now that you
> mention it, yeah, it makes more sense to patch this..
^ permalink raw reply [flat|nested] 17+ messages in thread
* Re: [PATCH 1/6] gstreamer1.0-plugin-base: Update packageconfigs
2018-07-17 9:35 [PATCH 1/6] gstreamer1.0-plugin-base: Update packageconfigs Carlos Rafael Giani
` (5 preceding siblings ...)
2018-07-18 12:16 ` [PATCH 1/6] gstreamer1.0-plugin-base: Update packageconfigs Peter Kjellerstedt
@ 2018-07-19 1:38 ` Anuj Mittal
2018-07-19 6:48 ` Carlos Rafael Giani
6 siblings, 1 reply; 17+ messages in thread
From: Anuj Mittal @ 2018-07-19 1:38 UTC (permalink / raw)
To: Carlos Rafael Giani, openembedded-core
On 07/17/2018 05:35 PM, Carlos Rafael Giani wrote:
> * There is no libvisual recipe in oe-core or in meta-openembedded, so
> the visual packageconfig needs to go
What is the benefit of removing it as compared to just letting it be
present as a configurable option which isn't enabled by default and is
still valid? It might be needed by layers outside of
oe-core/meta-openembedded ...
It was added specifically in a commit and I see a recipe present when I
search on layers.openembedded.org.
Thanks,
Anuj
^ permalink raw reply [flat|nested] 17+ messages in thread* Re: [PATCH 1/6] gstreamer1.0-plugin-base: Update packageconfigs
2018-07-19 1:38 ` Anuj Mittal
@ 2018-07-19 6:48 ` Carlos Rafael Giani
0 siblings, 0 replies; 17+ messages in thread
From: Carlos Rafael Giani @ 2018-07-19 6:48 UTC (permalink / raw)
To: Anuj Mittal, openembedded-core
Back when I first wrote meta-gstreamer1.0, I made the decision to
include packageconfigs for the two most used and most important set of
layers, oe-core and meta-openembedded. Packageconfigs whose dependencies
are in oe-core are enabled by default, those who aren't in oe-core but
in meta-openembedded are disabled by default.
I did that because including packageconfigs for all sorts of layers made
things complicated very fast. Plus, these two layers are kept up to date
and are reviewed, which is not necessarily true for other layers. And,
other layers may be much more specific to certain distros, BSPs,
frameworks than these two.
Here's an example. libvisual is in meta-debian and meta-qt5-extra. Why
should I have to include these much more specific layers to use a
packageconfig that isn't specific to debian or qt5?
I'd actually prefer a libvisual recipe in meta-openembedded, with
bbappens in these two layers to customize it for their needs.
On 2018-07-19 03:38, Anuj Mittal wrote:
> On 07/17/2018 05:35 PM, Carlos Rafael Giani wrote:
>> * There is no libvisual recipe in oe-core or in meta-openembedded, so
>> the visual packageconfig needs to go
> What is the benefit of removing it as compared to just letting it be
> present as a configurable option which isn't enabled by default and is
> still valid? It might be needed by layers outside of
> oe-core/meta-openembedded ...
>
> It was added specifically in a commit and I see a recipe present when I
> search on layers.openembedded.org.
>
> Thanks,
>
> Anuj
^ permalink raw reply [flat|nested] 17+ messages in thread