Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
To: "niko.mauno@vaisala.com" <niko.mauno@vaisala.com>,
	"openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>
Subject: RE: [OE-core] [RFC PATCH 3/3] pulseaudio: Disable 64 bit time with 32 bit glibc
Date: Tue, 8 Nov 2022 10:17:04 +0000	[thread overview]
Message-ID: <4956a44e486d49899881de23defe9c98@axis.com> (raw)
In-Reply-To: <20221108000828.42824-3-niko.mauno@vaisala.com>

> -----Original Message-----
> From: openembedded-core@lists.openembedded.org <openembedded-core@lists.openembedded.org> On Behalf Of Niko Mauno via
> lists.openembedded.org
> Sent: den 8 november 2022 01:08
> To: openembedded-core@lists.openembedded.org
> Cc: Niko Mauno <niko.mauno@vaisala.com>
> Subject: [OE-core] [RFC PATCH 3/3] pulseaudio: Disable 64 bit time with 32 bit glibc
> 
> For now add exemption in order to avoid following kind of failures
> during do_compile()
> 
>   | ../pulseaudio-16.1/src/modules/bluetooth/bt-codec-cvsd.c:55:22: warning: format '%lu' expects argument of type 'long unsigned int', but argument 6 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
>   |    55 |         pa_log_debug("Got invalid block size: %lu, rounding down", block_size);
>   |       |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~  ~~~~~~~~~~
>   |       |                                                                    |
>   |       |                                                                    size_t {aka unsigned int}
> 
> Signed-off-by: Niko Mauno <niko.mauno@vaisala.com>
> ---
>  meta/recipes-multimedia/pulseaudio/pulseaudio_16.1.bb | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meta/recipes-multimedia/pulseaudio/pulseaudio_16.1.bb b/meta/recipes-multimedia/pulseaudio/pulseaudio_16.1.bb
> index 64002cd1cc..ee4f8c7ed3 100644
> --- a/meta/recipes-multimedia/pulseaudio/pulseaudio_16.1.bb
> +++ b/meta/recipes-multimedia/pulseaudio/pulseaudio_16.1.bb
> @@ -8,3 +8,6 @@ SRC_URI =
> "http://freedesktop.org/software/pulseaudio/releases/${BP}.tar.xz \
>             "
>  SRC_URI[sha256sum] = "8eef32ce91d47979f95fd9a935e738cd7eb7463430dabc72863251751e504ae4"
>  UPSTREAM_CHECK_REGEX = "pulseaudio-(?P<pver>\d+(\.(?!99)\d+)+)\.tar"
> +
> +# Compiling 64 bit time for 32 bit host is broken
> +GLIBC_64BIT_TIME_CPPFLAGS = ""

Rather than hiding the problem, you should patch the code to use %zu instead 
of %lu. And please send the patch upstream.

> --
> 2.36.1

//Peter



  reply	other threads:[~2022-11-08 10:17 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-08  0:08 [RFC PATCH 1/3] Try to ensure 64 bit time on 32 bit glibcful hosts Niko Mauno
2022-11-08  0:08 ` [RFC PATCH 2/3] kbd: Disable 64 bit time with 32 bit glibc Niko Mauno
2022-11-08  9:14   ` [OE-core] " Alexander Kanavin
2022-11-08 11:48     ` Niko Mauno
2022-11-08 11:50       ` Alexander Kanavin
2022-11-08 12:04         ` Niko Mauno
2022-11-08 12:18           ` Alexander Kanavin
     [not found]           ` <17259B3874804FB3.24550@lists.openembedded.org>
2022-11-08 12:57             ` Alexander Kanavin
2022-11-08 14:56               ` Ola x Nilsson
2022-11-08 15:00                 ` Ola x Nilsson
     [not found]                 ` <1725A47F2FC9966F.2170@lists.openembedded.org>
2022-11-08 17:56                   ` Ola x Nilsson
2022-11-08 18:38                     ` Alexander Kanavin
2022-11-09  7:44                       ` Ola x Nilsson
2022-11-09 15:42                       ` Alexandre Belloni
2022-11-08 16:40     ` Khem Raj
2022-11-08 16:45       ` Alexander Kanavin
2022-11-08  0:08 ` [RFC PATCH 3/3] pulseaudio: " Niko Mauno
2022-11-08 10:17   ` Peter Kjellerstedt [this message]
2022-11-08  3:30 ` [OE-core] [RFC PATCH 1/3] Try to ensure 64 bit time on 32 bit glibcful hosts Khem Raj
2022-11-08 10:51 ` Ola x Nilsson
2022-11-08 16:38   ` Khem Raj
2022-11-09  6:33   ` Niko Mauno
2022-11-09 15:47   ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4956a44e486d49899881de23defe9c98@axis.com \
    --to=peter.kjellerstedt@axis.com \
    --cc=niko.mauno@vaisala.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox