Openembedded Core Discussions
 help / color / mirror / Atom feed
From: Tom Rini <tom_rini@mentor.com>
To: Ben Gardiner <bengardiner@nanometrics.ca>
Cc: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>,
	openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 0/3] port oe-dev ,ubifs.img link support
Date: Thu, 31 Mar 2011 08:47:11 -0700	[thread overview]
Message-ID: <4D94A1FF.1010909@mentor.com> (raw)
In-Reply-To: <cover.1301544780.git.bengardiner@nanometrics.ca>

On 03/30/2011 09:36 PM, Ben Gardiner wrote:
> I made some changes in oe-dev to normalize the link names used for the 
> ubifs images created when the type is ubifs vs. when the type is UBI. 
> The changes we two-fold: make symlinks to either .rootfs.<type> or 
> <type>.img and use the <type>.img extension for the ubifs images when 
> they are intermediate for UBI image generation as well as the final 
> target.
> 
> The changes were accepted by Tom Rini for oe-dev and Denys Dmytriyenko 
> for arago.
> 
> I've only just begun following the oe-core list and I noticed your 
> (Richard's) changes to introduce image_type.bbclass to oe-core. When I 
> looked closer at the changes I could see that there had been no sync-up 
> from oe-dev to oe-core since the changes I mentioned above.
> 
> This changeset should align oe-core with those recent changes in oe-dev; 
> the changes I made were dependent on Bernhard's change to replace the 
> symlink target with 'ln -f' instead of 'rm'ing it first; so I ported his 
> commit also.
> 
> I'm sorry to say that there has been no testing of these changes with 
> oe-core. I would be interested in trying a test build... but I must admit
> I don't know what MACHINE+DISTRO+image to try as a simple test build.
> 
> Ben Gardiner (2):
>   image_types.bbclass: add link to .rootfs.<type> or .<type>.img
>   image_types.bbclass: use .ubifs.img extension in IMAGE_CMD_ubi
> 
> Bernhard Reutner-Fischer (1):
>   image_types.bbclass: rm symlink destination via ln
> 
>  meta/classes/image_types.bbclass | 11 +++++++----
>  1 files changed, 7 insertions(+), 4 deletions(-)

Thanks for doing this.  The whole series looks good to me,
Acked-by: Tom Rini <tom_rini@mentor.com>

-- 
Tom Rini
Mentor Graphics Corporation



  parent reply	other threads:[~2011-03-31 15:49 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-24 14:49 [PATCH 0/2] Split IMAGE* variables into a separate class Richard Purdie
2011-03-24 14:49 ` [PATCH 2/2] image_types.bbclass: Drop IMAGE_EXTRA_OPTION in favour of the more standard EXTRA_IMAGECMD Richard Purdie
2011-03-24 14:49 ` [PATCH 1/2] bitbake.conf/image.bbclass: Move image type information into image_types.bbclass Richard Purdie
2011-03-31  4:36   ` [PATCH 0/3] port oe-dev ,ubifs.img link support Ben Gardiner
2011-03-31  4:36     ` [PATCH 1/3] image_types.bbclass: rm symlink destination via ln Ben Gardiner
2011-03-31  4:36     ` [PATCH 2/3] image_types.bbclass: add link to .rootfs.<type> or .<type>.img Ben Gardiner
2011-03-31  4:36     ` [PATCH 3/3] image_types.bbclass: use .ubifs.img extension in IMAGE_CMD_ubi Ben Gardiner
2011-03-31 15:47     ` Tom Rini [this message]
2011-03-31 19:14     ` [PATCH 0/3] port oe-dev ,ubifs.img link support Denys Dmytriyenko
2011-03-24 15:39 ` [PATCH 0/2] Split IMAGE* variables into a separate class Koen Kooi
2011-03-24 22:00   ` Tom Rini
2011-03-25 13:26 ` Richard Purdie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D94A1FF.1010909@mentor.com \
    --to=tom_rini@mentor.com \
    --cc=bengardiner@nanometrics.ca \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=rep.dot.nop@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox