Re: [PATCH 0/3] port oe-dev ,ubifs.img link support

From: Denys Dmytriyenko <denis@denix.org>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Cc: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Subject: Re: [PATCH 0/3] port oe-dev ,ubifs.img link support
Date: Thu, 31 Mar 2011 15:14:04 -0400	[thread overview]
Message-ID: <20110331191404.GE23178@denix.org> (raw)
In-Reply-To: <cover.1301544780.git.bengardiner@nanometrics.ca>

On Thu, Mar 31, 2011 at 12:36:35AM -0400, Ben Gardiner wrote:
> I made some changes in oe-dev to normalize the link names used for the 
> ubifs images created when the type is ubifs vs. when the type is UBI. 
> The changes we two-fold: make symlinks to either .rootfs.<type> or 
> <type>.img and use the <type>.img extension for the ubifs images when 
> they are intermediate for UBI image generation as well as the final 
> target.

Ben,

That seems like a good patchset for oe-core at this point. Especially in the 
light of Richard's proposal for image_types.bbclass...

Acked-by: Denys Dmytriyenko <denys@ti.com>

> The changes were accepted by Tom Rini for oe-dev and Denys Dmytriyenko 
> for arago.
> 
> I've only just begun following the oe-core list and I noticed your 
> (Richard's) changes to introduce image_type.bbclass to oe-core. When I 
> looked closer at the changes I could see that there had been no sync-up 
> from oe-dev to oe-core since the changes I mentioned above.
> 
> This changeset should align oe-core with those recent changes in oe-dev; 
> the changes I made were dependent on Bernhard's change to replace the 
> symlink target with 'ln -f' instead of 'rm'ing it first; so I ported his 
> commit also.
> 
> I'm sorry to say that there has been no testing of these changes with 
> oe-core. I would be interested in trying a test build... but I must admit
> I don't know what MACHINE+DISTRO+image to try as a simple test build.
> 
> Ben Gardiner (2):
>   image_types.bbclass: add link to .rootfs.<type> or .<type>.img
>   image_types.bbclass: use .ubifs.img extension in IMAGE_CMD_ubi
> 
> Bernhard Reutner-Fischer (1):
>   image_types.bbclass: rm symlink destination via ln
> 
>  meta/classes/image_types.bbclass | 11 +++++++----
>  1 files changed, 7 insertions(+), 4 deletions(-)
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core