[PATCH 0/1] remove u-boot flashing instructions for mpc8315e-rdb

[PATCH 0/1] remove u-boot flashing instructions for mpc8315e-rdb

[Paul Eggleton]

From: Paul Eggleton <paul.eggleton@linux.intel.com>

Upgrading u-boot is apparently not necessary with current board revisions,
and these instructions may not work properly anyway (our toolchain seems not
to be able to compile u-boot in the way described), and given that they are
potentially risky they should be removed.

Pull URL: git://git.openembedded.org/openembedded-core-contrib
  Branch: paule/readme-hardware-fix3
  Browse: http://git.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/readme-hardware-fix3

Thanks,
    Paul Eggleton <paul.eggleton@linux.intel.com>
---


Paul Eggleton (1):
  README.hardware: remove u-boot flashing instructions for mpc8315e-rdb

 README.hardware |   29 +++--------------------------
 1 files changed, 3 insertions(+), 26 deletions(-)

[PATCH 1/1] README.hardware: remove u-boot flashing instructions for mpc8315e-rdb

[Paul Eggleton]

From: Paul Eggleton <paul.eggleton@linux.intel.com>

Upgrading u-boot is apparently not necessary with current board revisions,
and these instructions may not work properly anyway (our toolchain seems not
to be able to compile u-boot in the way described), and given that they are
potentially risky they should be removed.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
---
 README.hardware |   29 +++--------------------------
 1 files changed, 3 insertions(+), 26 deletions(-)

diff --git a/README.hardware b/README.hardware
index 79607f7..025c678 100644
--- a/README.hardware
+++ b/README.hardware
@@ -234,32 +234,7 @@ You will need the following:
 * nfs root setup on your workstation
 * tftp server installed on your workstation
 
-The original U-Boot image on board can't boot kernel versions 2.6.34 or later
-successfully, so the U-Boot image should be upgraded to the latest U-Boot.
-
- 1. First build a new U-Boot image for mpc8315e-rdb, u-boot.bin.mpc8315erdb,
-    then make it available on your tftp server. To compile the new u-boot:
-
- $ git clone git://git.denx.de/u-boot.git
- $ cd u-boot
- $ git checkout -b v2010.09-mpc8315erdb v2010.09
- $ make ARCH=powerpc CROSS_COMPILE=<powerpc cross compiler path> MPC8315ERDB_config
- $ make ARCH=powerpc CROSS_COMPILE=<powerpc cross compiler path> all
- $ cp u-boot.bin u-boot.bin.mpc8315erdb
-
- 2. Set up the environment in U-Boot:
-
- =>setenv ipaddr <board ip>
- =>setenv serverip <tftp server ip>
-
- 3. Flash the new U-Boot image:
-
- =>tftp 200000 u-boot.bin.mpc8315erdb
- =>protect off all
- =>erase fe000000 +60000
- =>cp.b 200000 fe000000 60000
-
-Then the kernel can be booted successfully:
+Load the kernel and boot it as follows:
 
  1. Get the kernel (uImage.mpc8315erdb) and dtb (mpc8315erdb.dtb) files from
     the Poky build tmp/deploy directory, and make them available on your tftp
@@ -267,6 +242,8 @@ Then the kernel can be booted successfully:
 
  2. Set up the environment in U-Boot:
 
+ =>setenv ipaddr <board ip>
+ =>setenv serverip <tftp server ip>
  =>setenv bootargs root=/dev/nfs rw nfsroot=<nfsroot ip>:<rootfs path> ip=<board ip>:<server ip>:<gateway ip>:255.255.255.0:mpc8315e:eth0:off console=ttyS0,115200
 
  3. Download kernel and dtb to boot kernel.
-- 
1.7.1

Re: [poky] [PATCH 1/1] README.hardware: remove u-boot flashing instructions for mpc8315e-rdb

[Wolfgang Denk]

Dear Paul Eggleton,

In message <41ae31ba057b63d3c518e2edf217109c59b64603.1301578942.git.paul.eggleton@linux.intel.com> you wrote:
> From: Paul Eggleton <paul.eggleton@linux.intel.com>
> 
> Upgrading u-boot is apparently not necessary with current board revisions,
> and these instructions may not work properly anyway (our toolchain seems not
> to be able to compile u-boot in the way described), and given that they are
> potentially risky they should be removed.

The instructions you delete appear to be pretty generic ones, and I
see no reason why they would not work.

If the Poky too chain has issues with this, then there is a problem
with that tool chain, and you should enter a bug report.

What exactly would that problem be?

In any case, just papering over the problems seems not a good
startegy to me.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
It's a small world, but I wouldn't want to paint it.

Re: [poky] [PATCH 1/1] README.hardware: remove u-boot flashing instructions for mpc8315e-rdb

[Bruce Ashfield]

On Thu, Mar 31, 2011 at 10:19 AM, Wolfgang Denk <wd@denx.de> wrote:
> Dear Paul Eggleton,
>
> In message <41ae31ba057b63d3c518e2edf217109c59b64603.1301578942.git.paul.eggleton@linux.intel.com> you wrote:
>> From: Paul Eggleton <paul.eggleton@linux.intel.com>
>>
>> Upgrading u-boot is apparently not necessary with current board revisions,
>> and these instructions may not work properly anyway (our toolchain seems not
>> to be able to compile u-boot in the way described), and given that they are
>> potentially risky they should be removed.
>
> The instructions you delete appear to be pretty generic ones, and I
> see no reason why they would not work.

Agreed!

>
> If the Poky too chain has issues with this, then there is a problem
> with that tool chain, and you should enter a bug report.
>
> What exactly would that problem be?

There were a couple of build errors using u-boot master and
some specific branch tags, errors that we didn't see when using
some older toolchains. But the reports are not confirmed/formalized
yet. When we know more, the plan is to definitely address them and
hopefully do better than a bug report .. produce a patch.

>
> In any case, just papering over the problems seems not a good
> startegy to me.

Not really papering over, hopefully just temporarily removing an
implicit instruction to rebuild and reflash when the version on the
board already is sufficient to boot.

When the issues are worked out, we'll re-enable the instructions.

Cheers,

Bruce

>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
> It's a small world, but I wouldn't want to paint it.
> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"

Re: [poky] [PATCH 1/1] README.hardware: remove u-boot flashing instructions for mpc8315e-rdb

[Wolfgang Denk]

Dear Bruce Ashfield,

In message <AANLkTikSYNW=0rdzvaNnq9LO8agu0Vz67b_Fi-pNJmyx@mail.gmail.com> you wrote:
>
> There were a couple of build errors using u-boot master and
> some specific branch tags, errors that we didn't see when using
> some older toolchains. But the reports are not confirmed/formalized
> yet. When we know more, the plan is to definitely address them and
> hopefully do better than a bug report .. produce a patch.

If there are issues, please Cc: the U-Boot mailing list.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Reader, suppose you were an idiot. And suppose you were a  member  of
Congress. But I repeat myself.                           - Mark Twain

Re: [poky] [PATCH 1/1] README.hardware: remove u-boot flashing instructions for mpc8315e-rdb

[Darren Hart]

On 03/31/2011 07:19 AM, Wolfgang Denk wrote:
> Dear Paul Eggleton,
>
> In message<41ae31ba057b63d3c518e2edf217109c59b64603.1301578942.git.paul.eggleton@linux.intel.com>  you wrote:
>> From: Paul Eggleton<paul.eggleton@linux.intel.com>
>>
>> Upgrading u-boot is apparently not necessary with current board revisions,
>> and these instructions may not work properly anyway (our toolchain seems not
>> to be able to compile u-boot in the way described), and given that they are
>> potentially risky they should be removed.
>
> The instructions you delete appear to be pretty generic ones, and I
> see no reason why they would not work.
>

When I followed them I ended up with a dead mpc3815e-rdb. I suspect my 
u-boot image was bad in some way, but my concern was that others would 
end up in the same situation following the instructions. Since the 
existing u-boot version was able to boot the linux-yocto kernel recipe, 
there appears to be no need to reflash u-boot.

> If the Poky too chain has issues with this, then there is a problem
> with that tool chain, and you should enter a bug report.
>
> What exactly would that problem be?

Absolutely, this wasn't intended as a final "solution". The issue 
appears to be related to the 4.5.1 version of gcc failing in various 
ways to build either u-boot master or v2010.09, or v2010.12. I will 
report this to the u-boot mailing list just as soon as I can get back to it.

--
Darren

>
> In any case, just papering over the problems seems not a good
> startegy to me.
>
> Best regards,
>
> Wolfgang Denk
>

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Re: [poky] [PATCH 1/1] README.hardware: remove u-boot flashing instructions for mpc8315e-rdb

[Wolfgang Denk]

Dear Darren Hart,

In message <4D94ACBA.90409@linux.intel.com> you wrote:
> 
> Absolutely, this wasn't intended as a final "solution". The issue 
> appears to be related to the 4.5.1 version of gcc failing in various 
> ways to build either u-boot master or v2010.09, or v2010.12. I will 
> report this to the u-boot mailing list just as soon as I can get back to it.

Why did you not enter this as a bug in bugzilla, then?

Will we have a Yocto 1.0 releasse soon, with such known bugs?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
A conservative is a man who believes that nothing should be done for
the first time.                                   - Alfred E. Wiggam

Re: [poky] [PATCH 1/1] README.hardware: remove u-boot flashing instructions for mpc8315e-rdb

[Darren Hart]

On 03/31/2011 02:31 PM, Wolfgang Denk wrote:
> Dear Darren Hart,
>
> In message<4D94ACBA.90409@linux.intel.com>  you wrote:
>>
>> Absolutely, this wasn't intended as a final "solution". The issue
>> appears to be related to the 4.5.1 version of gcc failing in various
>> ways to build either u-boot master or v2010.09, or v2010.12. I will
>> report this to the u-boot mailing list just as soon as I can get back to it.
>
> Why did you not enter this as a bug in bugzilla, then?

Just hectic is all, was on my todo list for today.

http://bugzilla.pokylinux.org/show_bug.cgi?id=943

>
> Will we have a Yocto 1.0 releasse soon, with such known bugs?

Fortunately, the device in question appears to work fine with the stock 
u-boot. It doesn't seem prudent to delay the release with an adequate 
work-around for the problem.

Clearly this applies to all powerpc hardware, and it needs to be 
addressed. Per your request, I'll send a note to the u-boot list so we 
can discuss it in detail there.

Thanks,

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Re: [poky] [PATCH 1/1] README.hardware: remove u-boot flashing instructions for mpc8315e-rdb

[Darren Hart]

On 03/31/2011 06:46 AM, Paul Eggleton wrote:
> From: Paul Eggleton<paul.eggleton@linux.intel.com>
>
> Upgrading u-boot is apparently not necessary with current board revisions,
> and these instructions may not work properly anyway (our toolchain seems not
> to be able to compile u-boot in the way described), and given that they are
> potentially risky they should be removed.
>
> Signed-off-by: Paul Eggleton<paul.eggleton@linux.intel.com>

Acked-by: Darren Hart <dvhart@linux.intel.com>

> ---
>   README.hardware |   29 +++--------------------------
>   1 files changed, 3 insertions(+), 26 deletions(-)
>
> diff --git a/README.hardware b/README.hardware
> index 79607f7..025c678 100644
> --- a/README.hardware
> +++ b/README.hardware
> @@ -234,32 +234,7 @@ You will need the following:
>   * nfs root setup on your workstation
>   * tftp server installed on your workstation
>
> -The original U-Boot image on board can't boot kernel versions 2.6.34 or later
> -successfully, so the U-Boot image should be upgraded to the latest U-Boot.
> -
> - 1. First build a new U-Boot image for mpc8315e-rdb, u-boot.bin.mpc8315erdb,
> -    then make it available on your tftp server. To compile the new u-boot:
> -
> - $ git clone git://git.denx.de/u-boot.git
> - $ cd u-boot
> - $ git checkout -b v2010.09-mpc8315erdb v2010.09
> - $ make ARCH=powerpc CROSS_COMPILE=<powerpc cross compiler path>  MPC8315ERDB_config
> - $ make ARCH=powerpc CROSS_COMPILE=<powerpc cross compiler path>  all
> - $ cp u-boot.bin u-boot.bin.mpc8315erdb
> -
> - 2. Set up the environment in U-Boot:
> -
> - =>setenv ipaddr<board ip>
> - =>setenv serverip<tftp server ip>
> -
> - 3. Flash the new U-Boot image:
> -
> - =>tftp 200000 u-boot.bin.mpc8315erdb
> - =>protect off all
> - =>erase fe000000 +60000
> - =>cp.b 200000 fe000000 60000
> -
> -Then the kernel can be booted successfully:
> +Load the kernel and boot it as follows:
>
>    1. Get the kernel (uImage.mpc8315erdb) and dtb (mpc8315erdb.dtb) files from
>       the Poky build tmp/deploy directory, and make them available on your tftp
> @@ -267,6 +242,8 @@ Then the kernel can be booted successfully:
>
>    2. Set up the environment in U-Boot:
>
> + =>setenv ipaddr<board ip>
> + =>setenv serverip<tftp server ip>
>    =>setenv bootargs root=/dev/nfs rw nfsroot=<nfsroot ip>:<rootfs path>  ip=<board ip>:<server ip>:<gateway ip>:255.255.255.0:mpc8315e:eth0:off console=ttyS0,115200
>
>    3. Download kernel and dtb to boot kernel.

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel

Re: [PATCH 0/1] remove u-boot flashing instructions for mpc8315e-rdb

[Richard Purdie]

On Thu, 2011-03-31 at 14:46 +0100, Paul Eggleton wrote:
> From: Paul Eggleton <paul.eggleton@linux.intel.com>
> 
> Upgrading u-boot is apparently not necessary with current board revisions,
> and these instructions may not work properly anyway (our toolchain seems not
> to be able to compile u-boot in the way described), and given that they are
> potentially risky they should be removed.
> 
> Pull URL: git://git.openembedded.org/openembedded-core-contrib
>   Branch: paule/readme-hardware-fix3
>   Browse: http://git.openembedded.org/cgit.cgi/openembedded-core-contrib/log/?h=paule/readme-hardware-fix3
> 
> Thanks,
>     Paul Eggleton <paul.eggleton@linux.intel.com>
> ---
> 
> 
> Paul Eggleton (1):
>   README.hardware: remove u-boot flashing instructions for mpc8315e-rdb

Merged to master, thanks.

Richard