[PATCH] package.bbclass: convert unpackaged file message from 'info' to 'warn' so that it shows up on the console

[PATCH] package.bbclass: convert unpackaged file message from 'info' to 'warn' so that it shows up on the console

[Koen Kooi]

Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
---
 meta/classes/package.bbclass |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
index e6b3df7..082f233 100644
--- a/meta/classes/package.bbclass
+++ b/meta/classes/package.bbclass
@@ -676,9 +676,9 @@ python populate_packages () {
 				unshipped.append(path)
 
 	if unshipped != []:
-		bb.note("the following files were installed but not shipped in any package:")
+		bb.warn("the following files were installed but not shipped in any package:")
 		for f in unshipped:
-			bb.note("  " + f)
+			bb.warn("  " + f)
 
 	bb.build.exec_func("package_name_hook", d)
 
-- 
1.6.6.1

Re: [PATCH] package.bbclass: convert unpackaged file message from 'info' to 'warn' so that it shows up on the console

[Mark Hatle]

Acked-by: Mark Hatle <mark.hatle@windriver.com>

On 5/6/11 9:48 AM, Koen Kooi wrote:
> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> ---
>  meta/classes/package.bbclass |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
> index e6b3df7..082f233 100644
> --- a/meta/classes/package.bbclass
> +++ b/meta/classes/package.bbclass
> @@ -676,9 +676,9 @@ python populate_packages () {
>  				unshipped.append(path)
>  
>  	if unshipped != []:
> -		bb.note("the following files were installed but not shipped in any package:")
> +		bb.warn("the following files were installed but not shipped in any package:")
>  		for f in unshipped:
> -			bb.note("  " + f)
> +			bb.warn("  " + f)
>  
>  	bb.build.exec_func("package_name_hook", d)
>  

Re: [PATCH] package.bbclass: convert unpackaged file message from 'info' to 'warn' so that it shows up on the console

[Tom Rini]

On 05/06/2011 07:48 AM, Koen Kooi wrote:
> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> ---
>  meta/classes/package.bbclass |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
> index e6b3df7..082f233 100644
> --- a/meta/classes/package.bbclass
> +++ b/meta/classes/package.bbclass
> @@ -676,9 +676,9 @@ python populate_packages () {
>  				unshipped.append(path)
>  
>  	if unshipped != []:
> -		bb.note("the following files were installed but not shipped in any package:")
> +		bb.warn("the following files were installed but not shipped in any package:")
>  		for f in unshipped:
> -			bb.note("  " + f)
> +			bb.warn("  " + f)
>  
>  	bb.build.exec_func("package_name_hook", d)
>  

Acked-by: Tom Rini <tom_rini@mentor.com>

-- 
Tom Rini
Mentor Graphics Corporation

Re: [PATCH] package.bbclass: convert unpackaged file message from 'info' to 'warn' so that it shows up on the console

[Darren Hart]

According to my discussion with RP, bb.note() is supposed to appear on
the console. If it doesn't, that is a bug in bitbake, not the recipe
logging. I used this information to document the intended use of the
similarly named bbnote() in logging.bbclass.

--
Darren

On Fri, 2011-05-06 at 16:48 +0200, Koen Kooi wrote:
> Signed-off-by: Koen Kooi <koen@dominion.thruhere.net>
> ---
>  meta/classes/package.bbclass |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
> index e6b3df7..082f233 100644
> --- a/meta/classes/package.bbclass
> +++ b/meta/classes/package.bbclass
> @@ -676,9 +676,9 @@ python populate_packages () {
>  				unshipped.append(path)
>  
>  	if unshipped != []:
> -		bb.note("the following files were installed but not shipped in any package:")
> +		bb.warn("the following files were installed but not shipped in any package:")
>  		for f in unshipped:
> -			bb.note("  " + f)
> +			bb.warn("  " + f)
>  
>  	bb.build.exec_func("package_name_hook", d)
>  

-- 
Darren Hart
Yocto Linux Kernel

Re: [PATCH] package.bbclass: convert unpackaged file message from 'info' to 'warn' so that it shows up on the console

[Khem Raj]

On 5/7/2011 9:50 AM, Darren Hart wrote:
> According to my discussion with RP, bb.note() is supposed to appear on
> the console. If it doesn't, that is a bug in bitbake, not the recipe

it does if we increase verbosity but it also dumps a lot of other 
information along. Default is to print errors and warnings which seems a 
sane default to me. May be there is another level which dumps notes on
top and then as you increase the level you get more info dumped would be
a good to have

> logging. I used this information to document the intended use of the
> similarly named bbnote() in logging.bbclass.
>
> --
> Darren
>
> On Fri, 2011-05-06 at 16:48 +0200, Koen Kooi wrote:
>> Signed-off-by: Koen Kooi<koen@dominion.thruhere.net>
>> ---
>>   meta/classes/package.bbclass |    4 ++--
>>   1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
>> index e6b3df7..082f233 100644
>> --- a/meta/classes/package.bbclass
>> +++ b/meta/classes/package.bbclass
>> @@ -676,9 +676,9 @@ python populate_packages () {
>>   				unshipped.append(path)
>>
>>   	if unshipped != []:
>> -		bb.note("the following files were installed but not shipped in any package:")
>> +		bb.warn("the following files were installed but not shipped in any package:")
>>   		for f in unshipped:
>> -			bb.note("  " + f)
>> +			bb.warn("  " + f)
>>
>>   	bb.build.exec_func("package_name_hook", d)
>>
>

Re: [PATCH] package.bbclass: convert unpackaged file message from 'info' to 'warn' so that it shows up on the console

[Koen Kooi]

Op 8 mei 2011, om 08:23 heeft Khem Raj het volgende geschreven:

> On 5/7/2011 9:50 AM, Darren Hart wrote:
>> According to my discussion with RP, bb.note() is supposed to appear on
>> the console. If it doesn't, that is a bug in bitbake, not the recipe
> 
> it does if we increase verbosity but it also dumps a lot of other information along. Default is to print errors and warnings which seems a sane default to me. May be there is another level which dumps notes on
> top and then as you increase the level you get more info dumped would be
> a good to have

I still think that all unpackaged files are a bug, so it's more than a note anyway.

regards,

Koen

> 
>> logging. I used this information to document the intended use of the
>> similarly named bbnote() in logging.bbclass.
>> 
>> --
>> Darren
>> 
>> On Fri, 2011-05-06 at 16:48 +0200, Koen Kooi wrote:
>>> Signed-off-by: Koen Kooi<koen@dominion.thruhere.net>
>>> ---
>>>  meta/classes/package.bbclass |    4 ++--
>>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>> 
>>> diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
>>> index e6b3df7..082f233 100644
>>> --- a/meta/classes/package.bbclass
>>> +++ b/meta/classes/package.bbclass
>>> @@ -676,9 +676,9 @@ python populate_packages () {
>>>  				unshipped.append(path)
>>> 
>>>  	if unshipped != []:
>>> -		bb.note("the following files were installed but not shipped in any package:")
>>> +		bb.warn("the following files were installed but not shipped in any package:")
>>>  		for f in unshipped:
>>> -			bb.note("  " + f)
>>> +			bb.warn("  " + f)
>>> 
>>>  	bb.build.exec_func("package_name_hook", d)
>>> 
>> 
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core

Re: [PATCH] package.bbclass: convert unpackaged file message from 'info' to 'warn' so that it shows up on the console

[Graeme Gregory]

On 09/05/2011 08:11, Koen Kooi wrote:
> Op 8 mei 2011, om 08:23 heeft Khem Raj het volgende geschreven:
>
>> On 5/7/2011 9:50 AM, Darren Hart wrote:
>>> According to my discussion with RP, bb.note() is supposed to appear on
>>> the console. If it doesn't, that is a bug in bitbake, not the recipe
>> it does if we increase verbosity but it also dumps a lot of other information along. Default is to print errors and warnings which seems a sane default to me. May be there is another level which dumps notes on
>> top and then as you increase the level you get more info dumped would be
>> a good to have
> I still think that all unpackaged files are a bug, so it's more than a note anyway.
>
rpmbuild would agree with you there, so its not without precedence.

G

Re: [PATCH] package.bbclass: convert unpackaged file message from 'info' to 'warn' so that it shows up on the console

[Richard Purdie]

On Sat, 2011-05-07 at 09:50 -0700, Darren Hart wrote:
> According to my discussion with RP, bb.note() is supposed to appear on
> the console. If it doesn't, that is a bug in bitbake, not the recipe
> logging. I used this information to document the intended use of the
> similarly named bbnote() in logging.bbclass.

What we said was that bb.note from "core" context appears on the
console, bb.note from task context does not as it makes the default
console too verbose.

I'm in agreement that unpackaged files should be a warning.

Cheers,

Richard

Re: [PATCH] package.bbclass: convert unpackaged file message from 'info' to 'warn' so that it shows up on the console

[Saul Wold]

On 05/06/2011 07:48 AM, Koen Kooi wrote:
> Signed-off-by: Koen Kooi<koen@dominion.thruhere.net>
> ---
>   meta/classes/package.bbclass |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/package.bbclass b/meta/classes/package.bbclass
> index e6b3df7..082f233 100644
> --- a/meta/classes/package.bbclass
> +++ b/meta/classes/package.bbclass
> @@ -676,9 +676,9 @@ python populate_packages () {
>   				unshipped.append(path)
>
>   	if unshipped != []:
> -		bb.note("the following files were installed but not shipped in any package:")
> +		bb.warn("the following files were installed but not shipped in any package:")
>   		for f in unshipped:
> -			bb.note("  " + f)
> +			bb.warn("  " + f)
>
>   	bb.build.exec_func("package_name_hook", d)
>

Pulled into oe-Core

Thanks
	Sau!