[PATCH 0/1] kern-tools: error if features are not found

[PATCH 0/1] kern-tools: error if features are not found

[Bruce Ashfield]

Richard/Saul,
    
I'll repeat the patch contents here, since they explain
the change

---->---->---->---->---->---->
Fixes bug: [YOCTO #955]

Updating the SRCREV to pickup the kern-tools change:

[
    updateme: error if features are not found

    Rather than silently dropping addon features, we emit a warning
    and then exit with a failure code. The caller can then abort a
    build and not simply miss features.

    Passing --no-strict to the script disables this new functionality
    if for some reason a feature description is missing on purpose.
]
---->---->---->---->---->---->

This takes care of one thing we hit during 1.0 development,
and provides a clear message about features that are not
part of the kernel being built.

In a test of a forced invalid feature, the output is:

| WARNING: addon feature "cfg/non-exisistent" was not found
| ERROR: required features were not found. aborting

.. and the build stops.

Thanks,
    Bruce Ashfield <bruce.ashfield@windriver.com>

Pull URL: git://git.pokylinux.org/poky-contrib.git
  Branch: zedd/kernel
  Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=zedd/kernel

---


Bruce Ashfield (1):
  kern-tools: error if features are not found

 .../kern-tools/kern-tools-native_git.bb            |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

[PATCH 1/1] kern-tools: error if features are not found

[Bruce Ashfield]

Richard/Saul,

I'll just repeat the patch contents here:

Fixes bug: [YOCTO #955]

Updating the SRCREV to pickup the kern-tools change:

[
    updateme: error if features are not found

    Rather than silently dropping addon features, we emit a warning
    and then exit with a failure code. The caller can then abort a
    build and not simply miss features.

    Passing --no-strict to the script disables this new functionality
    if for some reason a feature description is missing on purpose.
]

We ran into this during 1.0 development, if someone tags an
extra feature into a bbapend (or wherever) and that feature
isn't valid they get a log to the console, and the build stops.

Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
---
 .../kern-tools/kern-tools-native_git.bb            |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb b/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb
index c808e17..829d105 100644
--- a/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb
+++ b/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb
@@ -4,7 +4,7 @@ LIC_FILES_CHKSUM = "file://git/tools/kgit;beginline=5;endline=9;md5=e2bf4415f3d8
 
 DEPENDS = "git-native guilt-native"
 
-SRCREV = "ab49d8e48b7e66d1b4f924385d65d062d25e44f7"
+SRCREV = "ecbdf3cdf6705a63dcb3c50bb24c311046f0b35c"
 PR = r10
 PV = "0.1+git${SRCPV}"
 
-- 
1.7.0.4

Re: [PATCH 1/1] kern-tools: error if features are not found

[Bruce Ashfield]

On Thu, May 12, 2011 at 4:21 PM, Bruce Ashfield
<bruce.ashfield@windriver.com> wrote:
> Richard/Saul,
>
> I'll just repeat the patch contents here:
>
> Fixes bug: [YOCTO #955]
>
> Updating the SRCREV to pickup the kern-tools change:
>
> [
>    updateme: error if features are not found
>
>    Rather than silently dropping addon features, we emit a warning
>    and then exit with a failure code. The caller can then abort a
>    build and not simply miss features.
>
>    Passing --no-strict to the script disables this new functionality
>    if for some reason a feature description is missing on purpose.
> ]
>
> We ran into this during 1.0 development, if someone tags an
> extra feature into a bbapend (or wherever) and that feature
> isn't valid they get a log to the console, and the build stops.

Urk. I have no idea what happened here :) This is NOT the
real content of the patch commit message.

Bruce

>
> Signed-off-by: Bruce Ashfield <bruce.ashfield@windriver.com>
> ---
>  .../kern-tools/kern-tools-native_git.bb            |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb b/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb
> index c808e17..829d105 100644
> --- a/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb
> +++ b/meta/recipes-kernel/kern-tools/kern-tools-native_git.bb
> @@ -4,7 +4,7 @@ LIC_FILES_CHKSUM = "file://git/tools/kgit;beginline=5;endline=9;md5=e2bf4415f3d8
>
>  DEPENDS = "git-native guilt-native"
>
> -SRCREV = "ab49d8e48b7e66d1b4f924385d65d062d25e44f7"
> +SRCREV = "ecbdf3cdf6705a63dcb3c50bb24c311046f0b35c"
>  PR = r10
>  PV = "0.1+git${SRCPV}"
>
> --
> 1.7.0.4
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"

Re: [PATCH 0/1] kern-tools: error if features are not found

[Saul Wold]

On 05/12/2011 01:21 PM, Bruce Ashfield wrote:
> Richard/Saul,
>
> I'll repeat the patch contents here, since they explain
> the change
>
> ---->---->---->---->---->---->
> Fixes bug: [YOCTO #955]
>
> Updating the SRCREV to pickup the kern-tools change:
>
> [
>      updateme: error if features are not found
>
>      Rather than silently dropping addon features, we emit a warning
>      and then exit with a failure code. The caller can then abort a
>      build and not simply miss features.
>
>      Passing --no-strict to the script disables this new functionality
>      if for some reason a feature description is missing on purpose.
> ]
> ---->---->---->---->---->---->
>
> This takes care of one thing we hit during 1.0 development,
> and provides a clear message about features that are not
> part of the kernel being built.
>
> In a test of a forced invalid feature, the output is:
>
> | WARNING: addon feature "cfg/non-exisistent" was not found
> | ERROR: required features were not found. aborting
>
> .. and the build stops.
>
> Thanks,
>      Bruce Ashfield<bruce.ashfield@windriver.com>
>
> Pull URL: git://git.pokylinux.org/poky-contrib.git
>    Branch: zedd/kernel
>    Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=zedd/kernel
>
> ---
>
>
> Bruce Ashfield (1):
>    kern-tools: error if features are not found
>
>   .../kern-tools/kern-tools-native_git.bb            |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
Merged into oe-core and master.

Thanks
	Sau!