From: Yu Ke <ke.yu@intel.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Cc: Chris Larson <clarson@kergoth.com>, paul.eggleton@intel.com
Subject: Re: [PATCH] RFC - combo layer repo tool
Date: Wed, 22 Jun 2011 21:10:59 +0800 [thread overview]
Message-ID: <4E01E9E3.9090202@intel.com> (raw)
In-Reply-To: <BANLkTinEe9RWC+mBf24OnggqaGfR-O8g5Q@mail.gmail.com>
on 2011-6-19 6:47, Chris Larson wrote:
> On Fri, Jun 17, 2011 at 10:42 AM, Paul Eggleton<paul.eggleton@intel.com> wrote:
>> Hi Ke,
>>
>> Great work. Here's my review so far:
>>
>> On Monday 13 June 2011 14:15:04 Yu, Ke wrote:
>>> --- /dev/null
>>> +++ b/scripts/combo-layer-hook-default.sh
>>> @@ -0,0 +1,14 @@
>>> +#!/bin/sh
>
> First thought on starting to read the patch: why are we home rolling a
> parser when the format is clearly ini style, which the ConfigParser
> module parses just fine?
Paul, Chris,
Thanks a lot for your valuable comment. I've sent out the V2 RFC patch,
and has all your comments included. Please review.
Regards
Ke
prev parent reply other threads:[~2011-06-22 13:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-13 13:15 [PATCH] RFC - combo layer repo tool Yu, Ke
2011-06-13 15:33 ` Otavio Salvador
2011-06-13 15:47 ` Koen Kooi
2011-06-13 18:15 ` Bruce Ashfield
2011-06-13 16:00 ` Paul Eggleton
2011-06-13 16:37 ` Otavio Salvador
2011-06-14 1:49 ` Yu Ke
2011-06-17 17:42 ` Paul Eggleton
2011-06-18 22:47 ` Chris Larson
2011-06-22 13:10 ` Yu Ke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E01E9E3.9090202@intel.com \
--to=ke.yu@intel.com \
--cc=clarson@kergoth.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=paul.eggleton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox