Openembedded Core Discussions
 help / color / mirror / Atom feed
* sstate skips STAGING_DIR_KERNEL?
@ 2011-06-23  0:20 Tom Rini
  2011-06-23 15:29 ` Richard Purdie
  0 siblings, 1 reply; 6+ messages in thread
From: Tom Rini @ 2011-06-23  0:20 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

Hey all,

As part of looking into the problem I had that I just posted a patch for
I was going "why isn't -c clean (or cleanall or cleansstate) knocking
out STAGING_DIR_KERNEL contents?  Answer, sstate is totally skipping
that out.  Is there some variable we need to be setting somewhere to add
this in?  Or are we going to have to take in the various bits of OE.dev
kernel.bbclass instead here?

-- 
Tom Rini
Mentor Graphics Corporation



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: sstate skips STAGING_DIR_KERNEL?
  2011-06-23  0:20 sstate skips STAGING_DIR_KERNEL? Tom Rini
@ 2011-06-23 15:29 ` Richard Purdie
  2011-06-23 16:15   ` Tom Rini
  0 siblings, 1 reply; 6+ messages in thread
From: Richard Purdie @ 2011-06-23 15:29 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer

On Wed, 2011-06-22 at 17:20 -0700, Tom Rini wrote:
> As part of looking into the problem I had that I just posted a patch for
> I was going "why isn't -c clean (or cleanall or cleansstate) knocking
> out STAGING_DIR_KERNEL contents?  Answer, sstate is totally skipping
> that out.  Is there some variable we need to be setting somewhere to add
> this in?  Or are we going to have to take in the various bits of OE.dev
> kernel.bbclass instead here?

I think there is a bug in kernel.bbclass. This should fix it:

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index aaf341b..9f09107 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -119,7 +119,7 @@ kernel_do_install() {
        # Support for external module building - create a minimal copy of the
        # kernel source tree.
        #
-       kerneldir=${STAGING_KERNEL_DIR}
+       kerneldir=${D}/kernel
        install -d $kerneldir
 
        #

I'll merge something like this is nobody objects.

Cheers,

Richard





^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: sstate skips STAGING_DIR_KERNEL?
  2011-06-23 15:29 ` Richard Purdie
@ 2011-06-23 16:15   ` Tom Rini
  2011-06-23 16:51     ` Tom Rini
  0 siblings, 1 reply; 6+ messages in thread
From: Tom Rini @ 2011-06-23 16:15 UTC (permalink / raw)
  To: openembedded-core

On 06/23/2011 08:29 AM, Richard Purdie wrote:
> On Wed, 2011-06-22 at 17:20 -0700, Tom Rini wrote:
>> As part of looking into the problem I had that I just posted a patch for
>> I was going "why isn't -c clean (or cleanall or cleansstate) knocking
>> out STAGING_DIR_KERNEL contents?  Answer, sstate is totally skipping
>> that out.  Is there some variable we need to be setting somewhere to add
>> this in?  Or are we going to have to take in the various bits of OE.dev
>> kernel.bbclass instead here?
> 
> I think there is a bug in kernel.bbclass. This should fix it:
> 
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index aaf341b..9f09107 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -119,7 +119,7 @@ kernel_do_install() {
>         # Support for external module building - create a minimal copy of the
>         # kernel source tree.
>         #
> -       kerneldir=${STAGING_KERNEL_DIR}
> +       kerneldir=${D}/kernel
>         install -d $kerneldir
>  
>         #
> 
> I'll merge something like this is nobody objects.

That makes sense, testing this now.

-- 
Tom Rini
Mentor Graphics Corporation



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: sstate skips STAGING_DIR_KERNEL?
  2011-06-23 16:15   ` Tom Rini
@ 2011-06-23 16:51     ` Tom Rini
  2011-06-23 17:12       ` Koen Kooi
  2011-06-23 19:47       ` Richard Purdie
  0 siblings, 2 replies; 6+ messages in thread
From: Tom Rini @ 2011-06-23 16:51 UTC (permalink / raw)
  To: openembedded-core, Koen Kooi

On 06/23/2011 09:15 AM, Tom Rini wrote:
> On 06/23/2011 08:29 AM, Richard Purdie wrote:
>> On Wed, 2011-06-22 at 17:20 -0700, Tom Rini wrote:
>>> As part of looking into the problem I had that I just posted a patch for
>>> I was going "why isn't -c clean (or cleanall or cleansstate) knocking
>>> out STAGING_DIR_KERNEL contents?  Answer, sstate is totally skipping
>>> that out.  Is there some variable we need to be setting somewhere to add
>>> this in?  Or are we going to have to take in the various bits of OE.dev
>>> kernel.bbclass instead here?
>>
>> I think there is a bug in kernel.bbclass. This should fix it:
>>
>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>> index aaf341b..9f09107 100644
>> --- a/meta/classes/kernel.bbclass
>> +++ b/meta/classes/kernel.bbclass
>> @@ -119,7 +119,7 @@ kernel_do_install() {
>>         # Support for external module building - create a minimal copy of the
>>         # kernel source tree.
>>         #
>> -       kerneldir=${STAGING_KERNEL_DIR}
>> +       kerneldir=${D}/kernel
>>         install -d $kerneldir
>>  
>>         #
>>
>> I'll merge something like this is nobody objects.
> 
> That makes sense, testing this now.

Yeah, that does it.

Tested-by: Tom Rini <tom_rini@mentor.com>

Koen, once this is in oe-core need a request to bring it over too or
just want to come grab it?

-- 
Tom Rini
Mentor Graphics Corporation



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: sstate skips STAGING_DIR_KERNEL?
  2011-06-23 16:51     ` Tom Rini
@ 2011-06-23 17:12       ` Koen Kooi
  2011-06-23 19:47       ` Richard Purdie
  1 sibling, 0 replies; 6+ messages in thread
From: Koen Kooi @ 2011-06-23 17:12 UTC (permalink / raw)
  To: Tom Rini; +Cc: openembedded-core


Op 23 jun 2011, om 18:51 heeft Tom Rini het volgende geschreven:

> On 06/23/2011 09:15 AM, Tom Rini wrote:
>> On 06/23/2011 08:29 AM, Richard Purdie wrote:
>>> On Wed, 2011-06-22 at 17:20 -0700, Tom Rini wrote:
>>>> As part of looking into the problem I had that I just posted a  
>>>> patch for
>>>> I was going "why isn't -c clean (or cleanall or cleansstate)  
>>>> knocking
>>>> out STAGING_DIR_KERNEL contents?  Answer, sstate is totally  
>>>> skipping
>>>> that out.  Is there some variable we need to be setting somewhere  
>>>> to add
>>>> this in?  Or are we going to have to take in the various bits of  
>>>> OE.dev
>>>> kernel.bbclass instead here?
>>>
>>> I think there is a bug in kernel.bbclass. This should fix it:
>>>
>>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/ 
>>> kernel.bbclass
>>> index aaf341b..9f09107 100644
>>> --- a/meta/classes/kernel.bbclass
>>> +++ b/meta/classes/kernel.bbclass
>>> @@ -119,7 +119,7 @@ kernel_do_install() {
>>>        # Support for external module building - create a minimal  
>>> copy of the
>>>        # kernel source tree.
>>>        #
>>> -       kerneldir=${STAGING_KERNEL_DIR}
>>> +       kerneldir=${D}/kernel
>>>        install -d $kerneldir
>>>
>>>        #
>>>
>>> I'll merge something like this is nobody objects.
>>
>> That makes sense, testing this now.
>
> Yeah, that does it.
>
> Tested-by: Tom Rini <tom_rini@mentor.com>
>
> Koen, once this is in oe-core need a request to bring it over too or
> just want to come grab it?

I have it applied locally, just waiting for it to land in oe-core so I  
can transplant the commit headers :)



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: sstate skips STAGING_DIR_KERNEL?
  2011-06-23 16:51     ` Tom Rini
  2011-06-23 17:12       ` Koen Kooi
@ 2011-06-23 19:47       ` Richard Purdie
  1 sibling, 0 replies; 6+ messages in thread
From: Richard Purdie @ 2011-06-23 19:47 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer; +Cc: Koen Kooi

On Thu, 2011-06-23 at 09:51 -0700, Tom Rini wrote:
> On 06/23/2011 09:15 AM, Tom Rini wrote:
> > On 06/23/2011 08:29 AM, Richard Purdie wrote:
> >> On Wed, 2011-06-22 at 17:20 -0700, Tom Rini wrote:
> >>> As part of looking into the problem I had that I just posted a patch for
> >>> I was going "why isn't -c clean (or cleanall or cleansstate) knocking
> >>> out STAGING_DIR_KERNEL contents?  Answer, sstate is totally skipping
> >>> that out.  Is there some variable we need to be setting somewhere to add
> >>> this in?  Or are we going to have to take in the various bits of OE.dev
> >>> kernel.bbclass instead here?
> >>
> >> I think there is a bug in kernel.bbclass. This should fix it:
> >>
> >> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> >> index aaf341b..9f09107 100644
> >> --- a/meta/classes/kernel.bbclass
> >> +++ b/meta/classes/kernel.bbclass
> >> @@ -119,7 +119,7 @@ kernel_do_install() {
> >>         # Support for external module building - create a minimal copy of the
> >>         # kernel source tree.
> >>         #
> >> -       kerneldir=${STAGING_KERNEL_DIR}
> >> +       kerneldir=${D}/kernel
> >>         install -d $kerneldir
> >>  
> >>         #
> >>
> >> I'll merge something like this is nobody objects.
> > 
> > That makes sense, testing this now.
> 
> Yeah, that does it.
> 
> Tested-by: Tom Rini <tom_rini@mentor.com>
> 
> Koen, once this is in oe-core need a request to bring it over too or
> just want to come grab it?

I've merged it into OE-Core.

Cheers,

Richard




^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-06-23 19:51 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-23  0:20 sstate skips STAGING_DIR_KERNEL? Tom Rini
2011-06-23 15:29 ` Richard Purdie
2011-06-23 16:15   ` Tom Rini
2011-06-23 16:51     ` Tom Rini
2011-06-23 17:12       ` Koen Kooi
2011-06-23 19:47       ` Richard Purdie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox