From: Mark Hatle <mark.hatle@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 5/5] package.bbclass: fixup_perms - symlink bug fix
Date: Mon, 25 Jul 2011 14:08:37 -0500 [thread overview]
Message-ID: <4E2DBF35.2020707@windriver.com> (raw)
In-Reply-To: <1311602747.30326.224.camel@phil-desktop>
On 7/25/11 9:05 AM, Phil Blundell wrote:
> On Mon, 2011-07-25 at 14:47 +0100, Richard Purdie wrote:
>> From: Mark Hatle <mark.hatle@windriver.com>
>>
>> We don't want to change the owner/mode of symlinks, as this may
>> affect the target of the link. Also broken links will fail as well.
>
> This seems like it will cause links themselves to end up getting shipped
> under the UID/GID that was used for building, which was the whole thing
> that fixup_perms was trying to avoid in the first place. Surely you do
> want to fix their ownership, it's just the mode that you oughtn't to be
> trying to change.
symlinks do not have an ownership/group on most filesystems. They automatically
inherit the uid/gid of the target. (I also believe this is the same for
permissions.)
How do you change the mode of the link itself? As far as I understood this
can't be done on most filesystems. I'd be happy to attempt to change the
owner/group (and mode) of symlinks if there is a way not to follow the link.
> Also, unrelated to the technical details, the subject line of this patch
> is not especially illuminating. It would be better to say something
> like "package.bbclass: don't change mode/owner of symlinks" rather than
> like "symlink bug fix".
This was discovered when I had a package that contained broken symlinks. The
fixup_perms broke on me. Thus the short description... [it can certainly be
changed]
--Mark
> p.
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
next prev parent reply other threads:[~2011-07-25 19:12 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 13:47 [PATCH 0/5] Various multilib related fixes Richard Purdie
2011-07-25 13:47 ` [PATCH 1/5] multilib_header.bbclass: Add oe_multilib_header wrapper Richard Purdie
2011-07-25 13:54 ` Phil Blundell
2011-07-25 17:11 ` Mark Hatle
2011-07-25 20:06 ` Phil Blundell
2011-07-26 15:25 ` Mark Hatle
2011-07-25 14:35 ` Phil Blundell
2011-07-25 13:47 ` [PATCH 2/5] Fix recipe multilib header conflicts Richard Purdie
2011-07-25 14:08 ` Phil Blundell
2011-07-25 19:11 ` Mark Hatle
2011-07-25 13:47 ` [PATCH 3/5] eglibc: Update 2.13 to avoid multilib conflicts Richard Purdie
2011-07-25 13:59 ` Phil Blundell
2011-07-25 19:04 ` Mark Hatle
2011-07-25 20:04 ` Phil Blundell
2011-07-25 13:47 ` [PATCH 4/5] ncurses: Uncompress man pages Richard Purdie
2011-07-25 14:13 ` Phil Blundell
2011-07-25 19:14 ` Mark Hatle
2011-07-25 14:42 ` Enrico Scholz
2011-07-25 15:28 ` Phil Blundell
2011-07-25 13:47 ` [PATCH 5/5] package.bbclass: fixup_perms - symlink bug fix Richard Purdie
2011-07-25 14:05 ` Phil Blundell
2011-07-25 14:14 ` Enrico Scholz
2011-07-25 14:15 ` Phil Blundell
2011-07-25 19:08 ` Mark Hatle [this message]
2011-07-25 19:42 ` Phil Blundell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E2DBF35.2020707@windriver.com \
--to=mark.hatle@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox