From: Mark Hatle <mark.hatle@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] eglibc_2.13: Add support for handling sqrt & sqrtf on powerpc
Date: Mon, 1 Aug 2011 09:53:46 -0500 [thread overview]
Message-ID: <4E36BDFA.4020409@windriver.com> (raw)
In-Reply-To: <1312208782-14078-1-git-send-email-galak@kernel.crashing.org>
On 8/1/11 9:26 AM, Kumar Gala wrote:
> Some of powerpc's dont support the fsqrt[s] instructions so we need an
> implementation of the library functions for those processors.
>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
> .../recipes-core/eglibc/eglibc-2.13/ppc-sqrt.patch | 538 ++++++++++++++++++++
> meta/recipes-core/eglibc/eglibc_2.13.bb | 3 +-
> 2 files changed, 540 insertions(+), 1 deletions(-)
> create mode 100644 meta/recipes-core/eglibc/eglibc-2.13/ppc-sqrt.patch
I'm a bit confused by this patch. Why is gcc even generating (or trying to) the
fsqrt instructions on cores that don't have it? Did someone optimize gcc so
that it always requires fsqrt on PPC? (This is horribly broken behavior BTW...)
As for the patch, I don't object.. but this just looks like the wrong solution
to me..
--Mark
next prev parent reply other threads:[~2011-08-01 14:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 14:26 [PATCH] eglibc_2.13: Add support for handling sqrt & sqrtf on powerpc Kumar Gala
2011-08-01 14:53 ` Mark Hatle [this message]
2011-08-01 14:56 ` Kumar Gala
2011-08-01 15:03 ` Mark Hatle
2011-08-02 23:15 ` Kumar Gala
2011-08-02 23:33 ` Saul Wold
2011-08-03 3:27 ` Kumar Gala
2011-08-03 1:58 ` Khem Raj
2011-08-04 14:55 ` Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E36BDFA.4020409@windriver.com \
--to=mark.hatle@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox