From: Mark Hatle <mark.hatle@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] eglibc_2.13: Add support for handling sqrt & sqrtf on powerpc
Date: Mon, 1 Aug 2011 10:03:02 -0500 [thread overview]
Message-ID: <4E36C026.2050804@windriver.com> (raw)
In-Reply-To: <24530743-BB87-468D-908B-4321D5C8D9F6@kernel.crashing.org>
On 8/1/11 9:56 AM, Kumar Gala wrote:
>
> On Aug 1, 2011, at 9:53 AM, Mark Hatle wrote:
>
>> On 8/1/11 9:26 AM, Kumar Gala wrote:
>>> Some of powerpc's dont support the fsqrt[s] instructions so we need an
>>> implementation of the library functions for those processors.
>>>
>>> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
>>> ---
>>> .../recipes-core/eglibc/eglibc-2.13/ppc-sqrt.patch | 538 ++++++++++++++++++++
>>> meta/recipes-core/eglibc/eglibc_2.13.bb | 3 +-
>>> 2 files changed, 540 insertions(+), 1 deletions(-)
>>> create mode 100644 meta/recipes-core/eglibc/eglibc-2.13/ppc-sqrt.patch
>>
>> I'm a bit confused by this patch. Why is gcc even generating (or trying to) the
>> fsqrt instructions on cores that don't have it? Did someone optimize gcc so
>> that it always requires fsqrt on PPC? (This is horribly broken behavior BTW...)
>>
>> As for the patch, I don't object.. but this just looks like the wrong solution
>> to me..
>>
>
> Mark, the issue isn't w/gcc but glibc itself. It will use inline asm of the 'fsqrt[s]' instruction. This we need a different implementation of the math lib functions for these cores.
Ahh, I see. That makes a lot more sense.
--Mark
> - k
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
next prev parent reply other threads:[~2011-08-01 15:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-01 14:26 [PATCH] eglibc_2.13: Add support for handling sqrt & sqrtf on powerpc Kumar Gala
2011-08-01 14:53 ` Mark Hatle
2011-08-01 14:56 ` Kumar Gala
2011-08-01 15:03 ` Mark Hatle [this message]
2011-08-02 23:15 ` Kumar Gala
2011-08-02 23:33 ` Saul Wold
2011-08-03 3:27 ` Kumar Gala
2011-08-03 1:58 ` Khem Raj
2011-08-04 14:55 ` Saul Wold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E36C026.2050804@windriver.com \
--to=mark.hatle@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox