* [PATCH] kernel,cml1.bbclass: Move menuconfig to cml1
@ 2011-07-29 12:24 Noor, Ahsan
2011-07-29 20:03 ` Ahsan, Noor
` (2 more replies)
0 siblings, 3 replies; 9+ messages in thread
From: Noor, Ahsan @ 2011-07-29 12:24 UTC (permalink / raw)
To: openembedded-core; +Cc: Noor, Ahsan
* The menuconfig target exists in places other than the kernel that use kernel style config.
Signed-off-by: Noor, Ahsan <noor_ahsan@mentor.com>
---
meta/classes/cml1.bbclass | 12 ++++++++++++
meta/classes/kernel.bbclass | 15 ---------------
2 files changed, 12 insertions(+), 15 deletions(-)
diff --git a/meta/classes/cml1.bbclass b/meta/classes/cml1.bbclass
index 79218b4..a747af5 100644
--- a/meta/classes/cml1.bbclass
+++ b/meta/classes/cml1.bbclass
@@ -6,3 +6,15 @@ cml1_do_configure() {
EXPORT_FUNCTIONS do_configure
addtask configure after do_unpack do_patch before do_compile
+
+do_menuconfig() {
+ export TERMWINDOWTITLE="${PN} Configuration"
+ export SHELLCMDS="make menuconfig"
+ ${TERMCMDRUN}
+ if [ $? -ne 0 ]; then
+ oefatal "'${TERMCMD}' not found. Check TERMCMD variable."
+ fi
+}
+do_menuconfig[nostamp] = "1"
+addtask menuconfig after do_configure
+
diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 9c492a3..25d2629 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -197,21 +197,6 @@ kernel_do_configure() {
do_configure[depends] += "${INITRAMFS_TASK}"
-do_menuconfig() {
- export DISPLAY='${DISPLAY}'
- export DBUS_SESSION_BUS_ADDRESS='${DBUS_SESSION_BUS_ADDRESS}'
- export XAUTHORITY='${XAUTHORITY}'
- export TERMWINDOWTITLE="${PN} Kernel Configuration"
- export SHELLCMDS="make menuconfig"
- ${TERMCMDRUN}
- if [ $? -ne 0 ]; then
- echo "Fatal: '${TERMCMD}' not found. Check TERMCMD variable."
- exit 1
- fi
-}
-do_menuconfig[nostamp] = "1"
-addtask menuconfig after do_configure
-
pkg_postinst_kernel () {
cd /${KERNEL_IMAGEDEST}; update-alternatives --install /${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE}-${KERNEL_VERSION} ${KERNEL_PRIORITY} || true
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] kernel,cml1.bbclass: Move menuconfig to cml1
2011-07-29 12:24 [PATCH] kernel,cml1.bbclass: Move menuconfig to cml1 Noor, Ahsan
@ 2011-07-29 20:03 ` Ahsan, Noor
2011-07-30 13:07 ` Andrea Adami
2011-08-02 18:36 ` Saul Wold
2011-08-04 14:54 ` Saul Wold
2 siblings, 1 reply; 9+ messages in thread
From: Ahsan, Noor @ 2011-07-29 20:03 UTC (permalink / raw)
To: openembedded-core; +Cc: Ahsan, Noor
* The menuconfig target exists in places other than the kernel that use
kernel style config.
Signed-off-by: Noor, Ahsan <noor_ahsan@mentor.com>
---
meta/classes/cml1.bbclass | 12 ++++++++++++
meta/classes/kernel.bbclass | 15 ---------------
2 files changed, 12 insertions(+), 15 deletions(-)
diff --git a/meta/classes/cml1.bbclass b/meta/classes/cml1.bbclass
index 79218b4..a747af5 100644
--- a/meta/classes/cml1.bbclass
+++ b/meta/classes/cml1.bbclass
@@ -6,3 +6,15 @@ cml1_do_configure() {
EXPORT_FUNCTIONS do_configure
addtask configure after do_unpack do_patch before do_compile
+
+do_menuconfig() {
+ export TERMWINDOWTITLE="${PN} Configuration"
+ export SHELLCMDS="make menuconfig"
+ ${TERMCMDRUN}
+ if [ $? -ne 0 ]; then
+ oefatal "'${TERMCMD}' not found. Check TERMCMD
variable."
+ fi
+}
+do_menuconfig[nostamp] = "1"
+addtask menuconfig after do_configure
+
diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 9c492a3..25d2629 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -197,21 +197,6 @@ kernel_do_configure() {
do_configure[depends] += "${INITRAMFS_TASK}"
-do_menuconfig() {
- export DISPLAY='${DISPLAY}'
- export DBUS_SESSION_BUS_ADDRESS='${DBUS_SESSION_BUS_ADDRESS}'
- export XAUTHORITY='${XAUTHORITY}'
- export TERMWINDOWTITLE="${PN} Kernel Configuration"
- export SHELLCMDS="make menuconfig"
- ${TERMCMDRUN}
- if [ $? -ne 0 ]; then
- echo "Fatal: '${TERMCMD}' not found. Check TERMCMD
variable."
- exit 1
- fi
-}
-do_menuconfig[nostamp] = "1"
-addtask menuconfig after do_configure
-
pkg_postinst_kernel () {
cd /${KERNEL_IMAGEDEST}; update-alternatives --install
/${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE}
${KERNEL_IMAGETYPE}-${KERNEL_VERSION} ${KERNEL_PRIORITY} || true
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] kernel,cml1.bbclass: Move menuconfig to cml1
2011-07-29 20:03 ` Ahsan, Noor
@ 2011-07-30 13:07 ` Andrea Adami
2011-08-01 17:54 ` Ahsan, Noor
0 siblings, 1 reply; 9+ messages in thread
From: Andrea Adami @ 2011-07-30 13:07 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Fri, Jul 29, 2011 at 10:03 PM, Ahsan, Noor <Noor_Ahsan@mentor.com> wrote:
> * The menuconfig target exists in places other than the kernel that use
> kernel style config.
>
> Signed-off-by: Noor, Ahsan <noor_ahsan@mentor.com>
> ---
> meta/classes/cml1.bbclass | 12 ++++++++++++
> meta/classes/kernel.bbclass | 15 ---------------
> 2 files changed, 12 insertions(+), 15 deletions(-)
>
> diff --git a/meta/classes/cml1.bbclass b/meta/classes/cml1.bbclass
> index 79218b4..a747af5 100644
> --- a/meta/classes/cml1.bbclass
> +++ b/meta/classes/cml1.bbclass
> @@ -6,3 +6,15 @@ cml1_do_configure() {
>
> EXPORT_FUNCTIONS do_configure
> addtask configure after do_unpack do_patch before do_compile
> +
> +do_menuconfig() {
> + export TERMWINDOWTITLE="${PN} Configuration"
> + export SHELLCMDS="make menuconfig"
> + ${TERMCMDRUN}
> + if [ $? -ne 0 ]; then
> + oefatal "'${TERMCMD}' not found. Check TERMCMD
> variable."
> + fi
> +}
> +do_menuconfig[nostamp] = "1"
> +addtask menuconfig after do_configure
> +
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 9c492a3..25d2629 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -197,21 +197,6 @@ kernel_do_configure() {
>
> do_configure[depends] += "${INITRAMFS_TASK}"
>
> -do_menuconfig() {
> - export DISPLAY='${DISPLAY}'
> - export DBUS_SESSION_BUS_ADDRESS='${DBUS_SESSION_BUS_ADDRESS}'
> - export XAUTHORITY='${XAUTHORITY}'
> - export TERMWINDOWTITLE="${PN} Kernel Configuration"
> - export SHELLCMDS="make menuconfig"
> - ${TERMCMDRUN}
> - if [ $? -ne 0 ]; then
> - echo "Fatal: '${TERMCMD}' not found. Check TERMCMD
> variable."
> - exit 1
> - fi
> -}
> -do_menuconfig[nostamp] = "1"
> -addtask menuconfig after do_configure
> -
> pkg_postinst_kernel () {
> cd /${KERNEL_IMAGEDEST}; update-alternatives --install
> /${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE}
> ${KERNEL_IMAGETYPE}-${KERNEL_VERSION} ${KERNEL_PRIORITY} || true
> }
> --
> 1.7.0.4
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
While you're doing that, please think about adding the following task:
+do_savedefconfig() {
+ oe_runmake savedefconfig
+}
+
+addtask savedefconfig after do_configure
It is very handy way to shrink kernel defconfigs and minimize the diffs.
Regards
Andrea
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] kernel,cml1.bbclass: Move menuconfig to cml1
2011-07-30 13:07 ` Andrea Adami
@ 2011-08-01 17:54 ` Ahsan, Noor
0 siblings, 0 replies; 9+ messages in thread
From: Ahsan, Noor @ 2011-08-01 17:54 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
Hi Andrea,
I'll send its separate patch.
Regards,
Noor
-----Original Message-----
From: openembedded-core-bounces@lists.openembedded.org [mailto:openembedded-core-bounces@lists.openembedded.org] On Behalf Of Andrea Adami
Sent: Saturday, July 30, 2011 6:08 PM
To: Patches and discussions about the oe-core layer
Subject: Re: [OE-core] [PATCH] kernel,cml1.bbclass: Move menuconfig to cml1
On Fri, Jul 29, 2011 at 10:03 PM, Ahsan, Noor <Noor_Ahsan@mentor.com> wrote:
> * The menuconfig target exists in places other than the kernel that use
> kernel style config.
>
> Signed-off-by: Noor, Ahsan <noor_ahsan@mentor.com>
> ---
> meta/classes/cml1.bbclass | 12 ++++++++++++
> meta/classes/kernel.bbclass | 15 ---------------
> 2 files changed, 12 insertions(+), 15 deletions(-)
>
> diff --git a/meta/classes/cml1.bbclass b/meta/classes/cml1.bbclass
> index 79218b4..a747af5 100644
> --- a/meta/classes/cml1.bbclass
> +++ b/meta/classes/cml1.bbclass
> @@ -6,3 +6,15 @@ cml1_do_configure() {
>
> EXPORT_FUNCTIONS do_configure
> addtask configure after do_unpack do_patch before do_compile
> +
> +do_menuconfig() {
> + export TERMWINDOWTITLE="${PN} Configuration"
> + export SHELLCMDS="make menuconfig"
> + ${TERMCMDRUN}
> + if [ $? -ne 0 ]; then
> + oefatal "'${TERMCMD}' not found. Check TERMCMD
> variable."
> + fi
> +}
> +do_menuconfig[nostamp] = "1"
> +addtask menuconfig after do_configure
> +
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 9c492a3..25d2629 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -197,21 +197,6 @@ kernel_do_configure() {
>
> do_configure[depends] += "${INITRAMFS_TASK}"
>
> -do_menuconfig() {
> - export DISPLAY='${DISPLAY}'
> - export DBUS_SESSION_BUS_ADDRESS='${DBUS_SESSION_BUS_ADDRESS}'
> - export XAUTHORITY='${XAUTHORITY}'
> - export TERMWINDOWTITLE="${PN} Kernel Configuration"
> - export SHELLCMDS="make menuconfig"
> - ${TERMCMDRUN}
> - if [ $? -ne 0 ]; then
> - echo "Fatal: '${TERMCMD}' not found. Check TERMCMD
> variable."
> - exit 1
> - fi
> -}
> -do_menuconfig[nostamp] = "1"
> -addtask menuconfig after do_configure
> -
> pkg_postinst_kernel () {
> cd /${KERNEL_IMAGEDEST}; update-alternatives --install
> /${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE}
> ${KERNEL_IMAGETYPE}-${KERNEL_VERSION} ${KERNEL_PRIORITY} || true
> }
> --
> 1.7.0.4
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
While you're doing that, please think about adding the following task:
+do_savedefconfig() {
+ oe_runmake savedefconfig
+}
+
+addtask savedefconfig after do_configure
It is very handy way to shrink kernel defconfigs and minimize the diffs.
Regards
Andrea
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] kernel,cml1.bbclass: Move menuconfig to cml1
2011-07-29 12:24 [PATCH] kernel,cml1.bbclass: Move menuconfig to cml1 Noor, Ahsan
2011-07-29 20:03 ` Ahsan, Noor
@ 2011-08-02 18:36 ` Saul Wold
2011-08-02 18:41 ` Koen Kooi
2011-08-02 18:45 ` Phil Blundell
2011-08-04 14:54 ` Saul Wold
2 siblings, 2 replies; 9+ messages in thread
From: Saul Wold @ 2011-08-02 18:36 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On 07/29/2011 05:24 AM, Noor, Ahsan wrote:
> * The menuconfig target exists in places other than the kernel that use kernel style config.
>
> Signed-off-by: Noor, Ahsan<noor_ahsan@mentor.com>
> ---
> meta/classes/cml1.bbclass | 12 ++++++++++++
> meta/classes/kernel.bbclass | 15 ---------------
> 2 files changed, 12 insertions(+), 15 deletions(-)
>
> diff --git a/meta/classes/cml1.bbclass b/meta/classes/cml1.bbclass
> index 79218b4..a747af5 100644
> --- a/meta/classes/cml1.bbclass
> +++ b/meta/classes/cml1.bbclass
> @@ -6,3 +6,15 @@ cml1_do_configure() {
>
> EXPORT_FUNCTIONS do_configure
> addtask configure after do_unpack do_patch before do_compile
> +
> +do_menuconfig() {
> + export TERMWINDOWTITLE="${PN} Configuration"
> + export SHELLCMDS="make menuconfig"
> + ${TERMCMDRUN}
> + if [ $? -ne 0 ]; then
> + oefatal "'${TERMCMD}' not found. Check TERMCMD variable."
> + fi
> +}
> +do_menuconfig[nostamp] = "1"
> +addtask menuconfig after do_configure
> +
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 9c492a3..25d2629 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -197,21 +197,6 @@ kernel_do_configure() {
>
> do_configure[depends] += "${INITRAMFS_TASK}"
>
> -do_menuconfig() {
> - export DISPLAY='${DISPLAY}'
> - export DBUS_SESSION_BUS_ADDRESS='${DBUS_SESSION_BUS_ADDRESS}'
> - export XAUTHORITY='${XAUTHORITY}'
> - export TERMWINDOWTITLE="${PN} Kernel Configuration"
> - export SHELLCMDS="make menuconfig"
> - ${TERMCMDRUN}
> - if [ $? -ne 0 ]; then
> - echo "Fatal: '${TERMCMD}' not found. Check TERMCMD variable."
> - exit 1
> - fi
> -}
> -do_menuconfig[nostamp] = "1"
> -addtask menuconfig after do_configure
> -
> pkg_postinst_kernel () {
> cd /${KERNEL_IMAGEDEST}; update-alternatives --install /${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE}-${KERNEL_VERSION} ${KERNEL_PRIORITY} || true
> }
I think this patch will break the linux-* recipes if someone tries to
use the menuconfig task.
I think you need to also modify the linux-* recipes that currently
inherit kernel to also include cmd1
Thanks
Sau!
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] kernel,cml1.bbclass: Move menuconfig to cml1
2011-08-02 18:36 ` Saul Wold
@ 2011-08-02 18:41 ` Koen Kooi
2011-08-02 18:45 ` Phil Blundell
1 sibling, 0 replies; 9+ messages in thread
From: Koen Kooi @ 2011-08-02 18:41 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
Op 2 aug. 2011, om 20:36 heeft Saul Wold het volgende geschreven:
> On 07/29/2011 05:24 AM, Noor, Ahsan wrote:
>> * The menuconfig target exists in places other than the kernel that use kernel style config.
>>
>> Signed-off-by: Noor, Ahsan<noor_ahsan@mentor.com>
>> ---
>> meta/classes/cml1.bbclass | 12 ++++++++++++
>> meta/classes/kernel.bbclass | 15 ---------------
>> 2 files changed, 12 insertions(+), 15 deletions(-)
>>
>> diff --git a/meta/classes/cml1.bbclass b/meta/classes/cml1.bbclass
>> index 79218b4..a747af5 100644
>> --- a/meta/classes/cml1.bbclass
>> +++ b/meta/classes/cml1.bbclass
>> @@ -6,3 +6,15 @@ cml1_do_configure() {
>>
>> EXPORT_FUNCTIONS do_configure
>> addtask configure after do_unpack do_patch before do_compile
>> +
>> +do_menuconfig() {
>> + export TERMWINDOWTITLE="${PN} Configuration"
>> + export SHELLCMDS="make menuconfig"
>> + ${TERMCMDRUN}
>> + if [ $? -ne 0 ]; then
>> + oefatal "'${TERMCMD}' not found. Check TERMCMD variable."
>> + fi
>> +}
>> +do_menuconfig[nostamp] = "1"
>> +addtask menuconfig after do_configure
>> +
>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>> index 9c492a3..25d2629 100644
>> --- a/meta/classes/kernel.bbclass
>> +++ b/meta/classes/kernel.bbclass
>> @@ -197,21 +197,6 @@ kernel_do_configure() {
>>
>> do_configure[depends] += "${INITRAMFS_TASK}"
>>
>> -do_menuconfig() {
>> - export DISPLAY='${DISPLAY}'
>> - export DBUS_SESSION_BUS_ADDRESS='${DBUS_SESSION_BUS_ADDRESS}'
>> - export XAUTHORITY='${XAUTHORITY}'
>> - export TERMWINDOWTITLE="${PN} Kernel Configuration"
>> - export SHELLCMDS="make menuconfig"
>> - ${TERMCMDRUN}
>> - if [ $? -ne 0 ]; then
>> - echo "Fatal: '${TERMCMD}' not found. Check TERMCMD variable."
>> - exit 1
>> - fi
>> -}
>> -do_menuconfig[nostamp] = "1"
>> -addtask menuconfig after do_configure
>> -
>> pkg_postinst_kernel () {
>> cd /${KERNEL_IMAGEDEST}; update-alternatives --install /${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE}-${KERNEL_VERSION} ${KERNEL_PRIORITY} || true
>> }
>
> I think this patch will break the linux-* recipes if someone tries to use the menuconfig task.
>
> I think you need to also modify the linux-* recipes that currently inherit kernel to also include cmd1
or make kernel.bbclass inherit it?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] kernel,cml1.bbclass: Move menuconfig to cml1
2011-08-02 18:36 ` Saul Wold
2011-08-02 18:41 ` Koen Kooi
@ 2011-08-02 18:45 ` Phil Blundell
2011-08-02 18:47 ` Saul Wold
1 sibling, 1 reply; 9+ messages in thread
From: Phil Blundell @ 2011-08-02 18:45 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Tue, 2011-08-02 at 11:36 -0700, Saul Wold wrote:
> I think this patch will break the linux-* recipes if someone tries to
> use the menuconfig task.
>
> I think you need to also modify the linux-* recipes that currently
> inherit kernel to also include cmd1
kernel.bbclass already does "inherit cml1" so I think it should be fine.
p.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] kernel,cml1.bbclass: Move menuconfig to cml1
2011-08-02 18:45 ` Phil Blundell
@ 2011-08-02 18:47 ` Saul Wold
0 siblings, 0 replies; 9+ messages in thread
From: Saul Wold @ 2011-08-02 18:47 UTC (permalink / raw)
To: openembedded-core
On 08/02/2011 11:45 AM, Phil Blundell wrote:
> On Tue, 2011-08-02 at 11:36 -0700, Saul Wold wrote:
>> I think this patch will break the linux-* recipes if someone tries to
>> use the menuconfig task.
>>
>> I think you need to also modify the linux-* recipes that currently
>> inherit kernel to also include cmd1
>
> kernel.bbclass already does "inherit cml1" so I think it should be fine.
>
Thanks, missed that, searched other places, but did not notice it there!
Issue resolved, will pull it now.
Sau!
> p.
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] kernel,cml1.bbclass: Move menuconfig to cml1
2011-07-29 12:24 [PATCH] kernel,cml1.bbclass: Move menuconfig to cml1 Noor, Ahsan
2011-07-29 20:03 ` Ahsan, Noor
2011-08-02 18:36 ` Saul Wold
@ 2011-08-04 14:54 ` Saul Wold
2 siblings, 0 replies; 9+ messages in thread
From: Saul Wold @ 2011-08-04 14:54 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On 07/29/2011 05:24 AM, Noor, Ahsan wrote:
> * The menuconfig target exists in places other than the kernel that use kernel style config.
>
> Signed-off-by: Noor, Ahsan<noor_ahsan@mentor.com>
> ---
> meta/classes/cml1.bbclass | 12 ++++++++++++
> meta/classes/kernel.bbclass | 15 ---------------
> 2 files changed, 12 insertions(+), 15 deletions(-)
>
> diff --git a/meta/classes/cml1.bbclass b/meta/classes/cml1.bbclass
> index 79218b4..a747af5 100644
> --- a/meta/classes/cml1.bbclass
> +++ b/meta/classes/cml1.bbclass
> @@ -6,3 +6,15 @@ cml1_do_configure() {
>
> EXPORT_FUNCTIONS do_configure
> addtask configure after do_unpack do_patch before do_compile
> +
> +do_menuconfig() {
> + export TERMWINDOWTITLE="${PN} Configuration"
> + export SHELLCMDS="make menuconfig"
> + ${TERMCMDRUN}
> + if [ $? -ne 0 ]; then
> + oefatal "'${TERMCMD}' not found. Check TERMCMD variable."
> + fi
> +}
> +do_menuconfig[nostamp] = "1"
> +addtask menuconfig after do_configure
> +
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 9c492a3..25d2629 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -197,21 +197,6 @@ kernel_do_configure() {
>
> do_configure[depends] += "${INITRAMFS_TASK}"
>
> -do_menuconfig() {
> - export DISPLAY='${DISPLAY}'
> - export DBUS_SESSION_BUS_ADDRESS='${DBUS_SESSION_BUS_ADDRESS}'
> - export XAUTHORITY='${XAUTHORITY}'
> - export TERMWINDOWTITLE="${PN} Kernel Configuration"
> - export SHELLCMDS="make menuconfig"
> - ${TERMCMDRUN}
> - if [ $? -ne 0 ]; then
> - echo "Fatal: '${TERMCMD}' not found. Check TERMCMD variable."
> - exit 1
> - fi
> -}
> -do_menuconfig[nostamp] = "1"
> -addtask menuconfig after do_configure
> -
> pkg_postinst_kernel () {
> cd /${KERNEL_IMAGEDEST}; update-alternatives --install /${KERNEL_IMAGEDEST}/${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE} ${KERNEL_IMAGETYPE}-${KERNEL_VERSION} ${KERNEL_PRIORITY} || true
> }
Merged into OE-Core
Thanks
Sau!
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2011-08-04 14:58 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-07-29 12:24 [PATCH] kernel,cml1.bbclass: Move menuconfig to cml1 Noor, Ahsan
2011-07-29 20:03 ` Ahsan, Noor
2011-07-30 13:07 ` Andrea Adami
2011-08-01 17:54 ` Ahsan, Noor
2011-08-02 18:36 ` Saul Wold
2011-08-02 18:41 ` Koen Kooi
2011-08-02 18:45 ` Phil Blundell
2011-08-02 18:47 ` Saul Wold
2011-08-04 14:54 ` Saul Wold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox