[PATCH] Update intltool to set perl shebang correctly for installed tools

Openembedded Core Discussions
 help / color / mirror / Atom feed

* [PATCH] Update intltool to set perl shebang correctly for installed tools
@ 2011-08-03 16:33 Matthew McClintock
  2011-08-03 16:44 ` [yocto] " Gary Thomas
  0 siblings, 1 reply; 4+ messages in thread
From: Matthew McClintock @ 2011-08-03 16:33 UTC (permalink / raw)
  To: yocto, openembedded-core

Several installed scripts set the perl shebang that is too long
which can cause failures on certian older bash versions.

Signed-off-by: Matthew McClintock <msm@freescale.com>
---
 meta/recipes-devtools/intltool/intltool.inc       |    2 +-
 meta/recipes-devtools/intltool/intltool_0.40.6.bb |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/recipes-devtools/intltool/intltool.inc b/meta/recipes-devtools/intltool/intltool.inc
index c934654..d8917ad 100644
--- a/meta/recipes-devtools/intltool/intltool.inc
+++ b/meta/recipes-devtools/intltool/intltool.inc
@@ -12,5 +12,5 @@ RRECOMMENDS_${PN} = "perl-modules"
 
 inherit autotools pkgconfig perlnative
 
-export PERL_virtclass-native = "/usr/bin/env perl"
+export PERL = "/usr/bin/env perl"
 BBCLASSEXTEND = "native"
diff --git a/meta/recipes-devtools/intltool/intltool_0.40.6.bb b/meta/recipes-devtools/intltool/intltool_0.40.6.bb
index c7938e5..8b52cf8 100644
--- a/meta/recipes-devtools/intltool/intltool_0.40.6.bb
+++ b/meta/recipes-devtools/intltool/intltool_0.40.6.bb
@@ -1,7 +1,7 @@
 require intltool.inc
 LICENSE="GPLv2"
 LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
-PR = "r3"
+PR = "r4"
 
 SRC_URI_append = " file://intltool-nowarn-0.40.0.patch"
 
-- 
1.7.5





^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [yocto] [PATCH] Update intltool to set perl shebang correctly for installed tools
  2011-08-03 16:33 [PATCH] Update intltool to set perl shebang correctly for installed tools Matthew McClintock
@ 2011-08-03 16:44 ` Gary Thomas
       [not found]   ` <CAEsOVNf5eZ6PLkqw_Ya8XEEzr1uQprGXOeqc4aS7BCcja7Bsmw@mail.gmail.com>
  0 siblings, 1 reply; 4+ messages in thread
From: Gary Thomas @ 2011-08-03 16:44 UTC (permalink / raw)
  To: Matthew McClintock; +Cc: yocto, openembedded-core

On 2011-08-03 10:33, Matthew McClintock wrote:
> Several installed scripts set the perl shebang that is too long
> which can cause failures on certian older bash versions.

How does the change below correspond to this comment?  It's not
clear [at least to me] how changing that environment variable
affects shebang constructs.  Can you give a more thorough explanation?

>
> Signed-off-by: Matthew McClintock<msm@freescale.com>
> ---
>   meta/recipes-devtools/intltool/intltool.inc       |    2 +-
>   meta/recipes-devtools/intltool/intltool_0.40.6.bb |    2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-devtools/intltool/intltool.inc b/meta/recipes-devtools/intltool/intltool.inc
> index c934654..d8917ad 100644
> --- a/meta/recipes-devtools/intltool/intltool.inc
> +++ b/meta/recipes-devtools/intltool/intltool.inc
> @@ -12,5 +12,5 @@ RRECOMMENDS_${PN} = "perl-modules"
>
>   inherit autotools pkgconfig perlnative
>
> -export PERL_virtclass-native = "/usr/bin/env perl"
> +export PERL = "/usr/bin/env perl"
>   BBCLASSEXTEND = "native"
> diff --git a/meta/recipes-devtools/intltool/intltool_0.40.6.bb b/meta/recipes-devtools/intltool/intltool_0.40.6.bb
> index c7938e5..8b52cf8 100644
> --- a/meta/recipes-devtools/intltool/intltool_0.40.6.bb
> +++ b/meta/recipes-devtools/intltool/intltool_0.40.6.bb
> @@ -1,7 +1,7 @@
>   require intltool.inc
>   LICENSE="GPLv2"
>   LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
> -PR = "r3"
> +PR = "r4"
>
>   SRC_URI_append = " file://intltool-nowarn-0.40.0.patch"
>

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------



^ permalink raw reply	[flat|nested] 4+ messages in thread

[parent not found: <CAEsOVNf5eZ6PLkqw_Ya8XEEzr1uQprGXOeqc4aS7BCcja7Bsmw@mail.gmail.com>]

* Re: [yocto] [PATCH] Update intltool to set perl shebang correctly for installed tools
       [not found]   ` <CAEsOVNf5eZ6PLkqw_Ya8XEEzr1uQprGXOeqc4aS7BCcja7Bsmw@mail.gmail.com>
@ 2011-08-03 20:01     ` Gary Thomas
  2011-08-03 20:08       ` Phil Blundell
  0 siblings, 1 reply; 4+ messages in thread
From: Gary Thomas @ 2011-08-03 20:01 UTC (permalink / raw)
  To: McClintock Matthew-B29882
  Cc: yocto@yoctoproject.org, openembedded-core@openembedded.org

On 2011-08-03 13:52, McClintock Matthew-B29882 wrote:
> (Sorry if this get sent twice...)
>
> On Wed, Aug 3, 2011 at 11:44 AM, Gary Thomas<gary@mlbassoc.com>  wrote:
>> On 2011-08-03 10:33, Matthew McClintock wrote:
>>>
>>> Several installed scripts set the perl shebang that is too long
>>> which can cause failures on certian older bash versions.
>>
>> How does the change below correspond to this comment?  It's not
>> clear [at least to me] how changing that environment variable
>> affects shebang constructs.  Can you give a more thorough explanation?
>
> The scripts intltool-{update,etc} installed in sysroot end up having
> *really* long shebangs without this change. On older distros this
> causes the intltool scripts to just fail usually during the configure
> task. intltools recipe itself will
> build and install fine. However, when a package that requires
> intltool's is being configured they will all fail withing invoking
> intltools.

This much was already clear from your explanation - the "what happens and
why it needs fixing" part.

What I don't see is the "why" - why does defining PERL vs PERL_virtclass-native
have this effect?

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [yocto] [PATCH] Update intltool to set perl shebang correctly for installed tools
  2011-08-03 20:01     ` Gary Thomas
@ 2011-08-03 20:08       ` Phil Blundell
  0 siblings, 0 replies; 4+ messages in thread
From: Phil Blundell @ 2011-08-03 20:08 UTC (permalink / raw)
  To: Patches and discussions about the oe-core layer
  Cc: McClintock Matthew-==B29882, openembedded-core@openembedded.org

[ Removed yocto@ from Cc.  Please don't crosspost between oe-core and
yocto. ]

On Wed, 2011-08-03 at 14:01 -0600, Gary Thomas wrote:
> On 2011-08-03 13:52, McClintock Matthew-B29882 wrote:
> > (Sorry if this get sent twice...)
> >
> > On Wed, Aug 3, 2011 at 11:44 AM, Gary Thomas<gary@mlbassoc.com>  wrote:
> >> On 2011-08-03 10:33, Matthew McClintock wrote:
> >>>
> >>> Several installed scripts set the perl shebang that is too long
> >>> which can cause failures on certian older bash versions.
> >>
> >> How does the change below correspond to this comment?  It's not
> >> clear [at least to me] how changing that environment variable
> >> affects shebang constructs.  Can you give a more thorough explanation?
> >
> > The scripts intltool-{update,etc} installed in sysroot end up having
> > *really* long shebangs without this change. On older distros this
> > causes the intltool scripts to just fail usually during the configure
> > task. intltools recipe itself will
> > build and install fine. However, when a package that requires
> > intltool's is being configured they will all fail withing invoking
> > intltools.
> 
> This much was already clear from your explanation - the "what happens and
> why it needs fixing" part.
> 
> What I don't see is the "why" - why does defining PERL vs PERL_virtclass-native
> have this effect?

Agreed, that seems weird and bogus.  Surely the scripts which go into
the sysroot (and later get executed on the build host) are going to be
the ones that were built with virtclass-native, in which case this would
be a no-op.  

And for scripts that are going to be packaged for installation on the
target, I'm not sure it is safe to assume that env is installed at all
and, even if it is guaranteed to be there, it is certainly not safe to
hardcode "/usr/bin" as the path to find it.  So I'm pretty sure that
this patch is the wrong thing.

p.





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-08-03 20:13 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-03 16:33 [PATCH] Update intltool to set perl shebang correctly for installed tools Matthew McClintock
2011-08-03 16:44 ` [yocto] " Gary Thomas
     [not found]   ` <CAEsOVNf5eZ6PLkqw_Ya8XEEzr1uQprGXOeqc4aS7BCcja7Bsmw@mail.gmail.com>
2011-08-03 20:01     ` Gary Thomas
2011-08-03 20:08       ` Phil Blundell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox