Re: [PATCH 04/10] meta-rt: add linux-yocto-rt_3.0 recipe

[Darren Hart <dvhart@linux.intel.com>]

On 08/11/2011 05:40 PM, Bruce Ashfield wrote:
> On 11-08-11 7:08 PM, Darren Hart wrote:
>> Add the initial linux-yocto-rt_3.0 recipe.
>>
>> TODO: replace the AUTOREV with real commit ids.
> 
> I think you did this!
> 
>>
>> Signed-off-by: Darren Hart<dvhart@linux.intel.com>
>> Signed-off-by: Bruce Ashfield<bruce.ashfield@windriver.com>
>> ---
>>   meta-rt/recipes-kernel/linux/linux-yocto-rt_3.0.bb |   55 ++++++++++++++++++++
>>   1 files changed, 55 insertions(+), 0 deletions(-)
>>   create mode 100644 meta-rt/recipes-kernel/linux/linux-yocto-rt_3.0.bb
>>
>> diff --git a/meta-rt/recipes-kernel/linux/linux-yocto-rt_3.0.bb b/meta-rt/recipes-kernel/linux/linux-yocto-rt_3.0.bb
>> new file mode 100644
>> index 0000000..7eaeb0f
>> --- /dev/null
>> +++ b/meta-rt/recipes-kernel/linux/linux-yocto-rt_3.0.bb
>> @@ -0,0 +1,55 @@
>> +inherit kernel
>> +require recipes-kernel/linux/linux-yocto.inc
>> +
>> +KMACHINE = "yocto/standard/preempt-rt/base"
> 
> I just noticed this on the way through, this could likely just
> be set to "common-pc", all it really is supposed to be
> is a fallback if a machine specific override doesn't work.
> 
> (I see that you actually do this in patch 8/10 for 2.6.34 anyway).
> 
>> +KMACHINE_qemux86  = "common-pc"
>> +KMACHINE_qemux86-64  = "common-pc-64"
>> +KMACHINE_qemuarm  = "arm-versatile-926ejs"
>> +# qemuppc hangs at boot
>> +#KMACHINE_qemuppc  = "qemu-ppc32"
>> +# qemumips panics at boot
>> +#KMACHINE_qemumips = "mti-malta32-be"
>> +
>> +KBRANCH = ${KMACHINE}
> 
> And instead of the above, you could just say:
> 
> KBRANCH = "yocto/standard/preempt-rt/base"
> 
> to have a fallback in place that keeps the fetcher chugging along.
> That's all that the KMACHINE default was doing in the end anyway.
> 
> Sorry I didn't see this earlier, but seeing it in front of me
> here, it jumped out.
> 
> The rest looks good.

All good points, I'll respin and send out V2.

--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel