Adding kernel patches using "git am"?

Adding kernel patches using "git am"?

[Ulf Samuelsson]

Is there a reason for using "patch" instead of "git am" on let's say the 
kernel.

If I want to do some modification, of the kernel, I can like Graeme 
description at
http://www.slimlogic.co.uk/2011/05/openembeddedangstrom-kernel-workflow/   
do
bitbake -c configure virtual/kernel

and then have an initialized git tree ready to be modified.

"git am" is of course more sensitive to the patch quality than "patch"
but that has some advantages as well.

It also makes the recipe more complex at this stage.

--
Best Regards
Ulf Samuelsson
eMagii

Re: Adding kernel patches using "git am"?

[Chris Larson]

On Wed, Nov 30, 2011 at 3:35 AM, Ulf Samuelsson
<openembedded-core@emagii.com> wrote:
> Is there a reason for using "patch" instead of "git am" on let's say the
> kernel.
>
> If I want to do some modification, of the kernel, I can like Graeme
> description at
> http://www.slimlogic.co.uk/2011/05/openembeddedangstrom-kernel-workflow/
> do
> bitbake -c configure virtual/kernel
>
> and then have an initialized git tree ready to be modified.
>
> "git am" is of course more sensitive to the patch quality than "patch"
> but that has some advantages as well.
>
> It also makes the recipe more complex at this stage.

echo PATCHTOOL_pn-linux = "git" >> conf/local.conf # (note, uses
git-apply, not git-am, but it's a step in the direction you want,
anyway, and by inspecting patch.bbclass and lib/oe/patch.py and
looking for that patch tool, you can see how you'd go about adding one
for git-am if you desired it)
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

Re: Adding kernel patches using "git am"?

[Bruce Ashfield]

On 11-11-30 05:35 AM, Ulf Samuelsson wrote:
> Is there a reason for using "patch" instead of "git am" on let's say the
> kernel.
>
> If I want to do some modification, of the kernel, I can like Graeme
> description at
> http://www.slimlogic.co.uk/2011/05/openembeddedangstrom-kernel-workflow/ do
> bitbake -c configure virtual/kernel
>
> and then have an initialized git tree ready to be modified.
>
> "git am" is of course more sensitive to the patch quality than "patch"
> but that has some advantages as well.

Not answering the question directly, but if you use the linux-yocto
kernel and related infrastructure, patch is not used to apply changes
to the tree. It is done under the covers with guilt or git am applying
changes to the tree (along with other git operations for more complex 
situations).

Cheers,

Bruce

>
> It also makes the recipe more complex at this stage.
>
> --
> Best Regards
> Ulf Samuelsson
> eMagii
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core